public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [patch] tc-m68k.c: Add various missing control registers.
@ 2007-08-27 22:01 Kazu Hirata
  2007-08-28  6:58 ` Ben Elliston
  0 siblings, 1 reply; 2+ messages in thread
From: Kazu Hirata @ 2007-08-27 22:01 UTC (permalink / raw)
  To: binutils; +Cc: nathan

Hi,

Attached is a patch to add various missing control registers to
mcf5*_ctrl.

Tested by using the registers in assembly files.  OK to apply?

Kazu Hirata

2007-08-27  Nathan Sidwell  <nathan@codesourcery.com>

	* config/tc-m68k.c (mcf52235_ctrl): Add cache registers.
	(mcf5253_ctrl): Add RAMBAR, MBAR, MBAR2.
	(mcf5407_ctrl): New.
	(m68k_cpus): Adjust 5407 entry.

Index: gas/config/tc-m68k.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-m68k.c,v
retrieving revision 1.94
diff -u -r1.94 tc-m68k.c
--- gas/config/tc-m68k.c	3 Jul 2007 11:01:04 -0000	1.94
+++ gas/config/tc-m68k.c	27 Aug 2007 19:18:08 -0000
@@ -201,7 +201,7 @@
   0
 };
 static const enum m68k_register mcf52235_ctrl[] = {
-  VBR, FLASHBAR, RAMBAR, RAMBAR1,
+  VBR, CACR, ACR0, ACR1, FLASHBAR, RAMBAR, RAMBAR1,
   0
 };
 static const enum m68k_register mcf5225_ctrl[] = {
@@ -221,7 +221,7 @@
   0
 };
 static const enum m68k_register mcf5253_ctrl[] = {
-  VBR, CACR, ACR0, ACR1, RAMBAR0, RAMBAR1, MBAR,
+  VBR, CACR, ACR0, ACR1, RAMBAR0, RAMBAR1, RAMBAR, MBAR, MBAR2,
   0
 };
 static const enum m68k_register mcf5271_ctrl[] = {
@@ -268,6 +268,15 @@
   ROMBAR /* ROMBAR0 */, RAMBAR /* RAMBAR1 */,
   0
 };
+static const enum m68k_register mcf5407_ctrl[] = {
+  CACR, ASID, ACR0, ACR1, ACR2, ACR3,
+  VBR, PC, RAMBAR0, RAMBAR1, MBAR,
+  /* Legacy names */
+  TC /* ASID */,
+  ITT0 /* ACR0 */, ITT1 /* ACR1 */, DTT0 /* ACR2 */, DTT1 /* ACR3 */,
+  MBAR1 /* MBAR */, RAMBAR /* RAMBAR1 */,
+  0
+};
 static const enum m68k_register mcf54455_ctrl[] = {
   CACR, ASID, ACR0, ACR1, ACR2, ACR3, MMUBAR,
   VBR, PC, RAMBAR1, MBAR,
@@ -626,7 +635,7 @@
   {mcfisa_a|mcfisa_aa|mcfhwdiv|mcfemac|mcfusp,	mcf5373_ctrl, "5373", -1},
   {mcfisa_a|mcfisa_aa|mcfhwdiv|mcfemac|mcfusp,	mcf5373_ctrl, "537x", 0},
   
-  {mcfisa_a|mcfisa_b|mcfhwdiv|mcfmac,		mcf_ctrl, "5407",0},
+  {mcfisa_a|mcfisa_b|mcfhwdiv|mcfmac,		mcf5407_ctrl, "5407",0},
 
   {mcfisa_a|mcfisa_c|mcfhwdiv|mcfemac|mcfusp,   mcf54455_ctrl, "54450", -1},
   {mcfisa_a|mcfisa_c|mcfhwdiv|mcfemac|mcfusp,   mcf54455_ctrl, "54451", -1},

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] tc-m68k.c: Add various missing control registers.
  2007-08-27 22:01 [patch] tc-m68k.c: Add various missing control registers Kazu Hirata
@ 2007-08-28  6:58 ` Ben Elliston
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Elliston @ 2007-08-28  6:58 UTC (permalink / raw)
  To: Kazu Hirata; +Cc: binutils, nathan

On Mon, 2007-08-27 at 12:21 -0700, Kazu Hirata wrote:

> 2007-08-27  Nathan Sidwell  <nathan@codesourcery.com>
> 
> 	* config/tc-m68k.c (mcf52235_ctrl): Add cache registers.
> 	(mcf5253_ctrl): Add RAMBAR, MBAR, MBAR2.
> 	(mcf5407_ctrl): New.
> 	(m68k_cpus): Adjust 5407 entry.

This is OK, but can you add test cases for each of the new registers to
testsuite/gas/m68k, please?  (I know the testsuite is incomplete for
other register names, but it doesn't mean we shouldn't try)  :-)

Thanks, Ben

-- 
Ben Elliston <bje@au.ibm.com>
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-28  1:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-27 22:01 [patch] tc-m68k.c: Add various missing control registers Kazu Hirata
2007-08-28  6:58 ` Ben Elliston

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).