[patch] coffgen.c, degenerate case

[patch] coffgen.c, degenerate case

[msnyder]

[-- Attachment #1: Type: text/plain, Size: 127 bytes --]

If size == 0 and bfd_malloc returns NULL, just return.
No actual work to do anyway, and avoids passing null ptr to bfd_bread.


[-- Attachment #2: coffgen1.txt --]
[-- Type: text/plain, Size: 1088 bytes --]

2007-07-25  Michael Snyder  <msnyder@access-company.com>

	* coffgen.c (_bfd_coff_get_external_symbols): Nothing to be done
	if size == 0; return and avoid possible null pointer issues.

Index: coffgen.c
===================================================================
RCS file: /cvs/src/src/bfd/coffgen.c,v
retrieving revision 1.59
diff -p -r1.59 coffgen.c
*** coffgen.c	12 Jul 2007 07:16:40 -0000	1.59
--- coffgen.c	25 Jul 2007 23:30:25 -0000
*************** _bfd_coff_get_external_symbols (bfd *abf
*** 1446,1453 ****
    size = obj_raw_syment_count (abfd) * symesz;
  
    syms = bfd_malloc (size);
!   if (syms == NULL && size != 0)
!     return FALSE;
  
    if (bfd_seek (abfd, obj_sym_filepos (abfd), SEEK_SET) != 0
        || bfd_bread (syms, size, abfd) != size)
--- 1446,1456 ----
    size = obj_raw_syment_count (abfd) * symesz;
  
    syms = bfd_malloc (size);
!   if (syms == NULL)
!     if (size == 0)
!       return TRUE;
!     else
!       return FALSE;
  
    if (bfd_seek (abfd, obj_sym_filepos (abfd), SEEK_SET) != 0
        || bfd_bread (syms, size, abfd) != size)

Re: [patch] coffgen.c, degenerate case

[DJ Delorie]

This is OK.

> 2007-07-25  Michael Snyder  <msnyder@access-company.com>
> 
> 	* coffgen.c (_bfd_coff_get_external_symbols): Nothing to be done
> 	if size == 0; return and avoid possible null pointer issues.
> 
> Index: coffgen.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/coffgen.c,v
> retrieving revision 1.59
> diff -p -r1.59 coffgen.c
> *** coffgen.c	12 Jul 2007 07:16:40 -0000	1.59
> --- coffgen.c	26 Jul 2007 01:27:09 -0000
> *************** _bfd_coff_get_external_symbols (bfd *abf
> *** 1444,1452 ****
>     symesz = bfd_coff_symesz (abfd);
>   
>     size = obj_raw_syment_count (abfd) * symesz;
>   
>     syms = bfd_malloc (size);
> !   if (syms == NULL && size != 0)
>       return FALSE;
>   
>     if (bfd_seek (abfd, obj_sym_filepos (abfd), SEEK_SET) != 0
> --- 1449,1459 ----
>     symesz = bfd_coff_symesz (abfd);
>   
>     size = obj_raw_syment_count (abfd) * symesz;
> +   if (size == 0)
> +     return TRUE;
>   
>     syms = bfd_malloc (size);
> !   if (syms == NULL)
>       return FALSE;
>   
>     if (bfd_seek (abfd, obj_sym_filepos (abfd), SEEK_SET) != 0
> ------=_20070725183021_75864--
> 
> 

Re: [patch] coffgen.c, degenerate case

[msnyder]

>
> This is OK.

Committed, thanks.

By the way, I hope I'm not making you guys too crazy with all the
patches.  I'll be taking a break from it now.   ;-)