From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2084.outbound.protection.outlook.com [40.107.8.84]) by sourceware.org (Postfix) with ESMTPS id B9A923858D1E for ; Tue, 31 Oct 2023 07:30:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9A923858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B9A923858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.8.84 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698737420; cv=pass; b=v860UvUEz7gTER2IbYuvux6z13Up4U93TvNuYNwI8TRYh4heB+TVrSWcdJOmQLFm8Bu9V0FKiQLyTSVYE/0BbyszoAhUeiU8jwNO8qF93ylRCww9Yb23P5UbLS8ro6NdUhMQFpfA2x7eGexFc3g4UqYEq9Z+GsSNkphdrt8ADAA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698737420; c=relaxed/simple; bh=lX31MOjj/kCcvIVL8juFWf1QU4G+7uAjJOmlcRTMUZc=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=VCyahI/rChcbowjrd+srrzhzSEP1kNrjCXsMRbtKnFl2gpkhPrmvS8+Zmz+P/UJnbiPLrUK7MmRsMKyy/vXN07nf8EuZxYOBcMFpxmc/sR+khevJIAmTXmD5gvI0XR625ujJixERqZpJkPmmgUgxPty0G+dk+IWnoYzLz1CiMvI= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TyN1ASfKwhOLnSUdDAj3yJzuMkSCfwWEVQDrCAR6h5KKu3GBi1rzOJDcKTCFrJOxTUJsSO37XFUv6oXNQhuFsfu94dblaTGU2pIDtuUdEVPDoLQWJI0ychxSoBJl+6Xy0AonkLzeSsc3QVavQFhlahFfWEJVyZzcV9OMCSWU2SSbV+30dAQcFdCfwtOuI5yIVYe66En3bmUJOIbwuSwdDjVIYrTi/21tmclxCfTLNiVvSAbqlUoHng3w4cklFg0b29AGlNuzyp31N+dsLM0jLbT6T29fm/a43pxn0ILPUWn597CDgrfG/TEJtiOE4+W9Vw9Sde26RrExEPPjhmW0wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uXaCqOoXF6eHHmgq5zXXF9c8r291D1tb7/Vq3HI/zWg=; b=T0gnnm15LgWSglhW4I1hw6SoycylzQpzxh8qLvbE8gtYtm59Mm8JmNsSC89ADm7ByQYOkmiHg95TI9TnyxnhSrQ/oLJV026jRffbuIhCkM29Yq6Lrt/dB3zDvatBIhSk0yYoIyriKXY891VZUCFMybXckmpd3RKk0zmG8Lj3pb6RDMz6Evpt4faA0cC3INF5ATAQMX2NU6y5V0quBtB7lA5qoxgURYHVd0KxOYNprvFPnjm/Js8JH9faEy1J3kM9dQhxutZ6mB9KNUxIjIGHO0mvwSbun9AlzRkkdKFyaF5JAcWkQiki/BsNwpmJ3AP/T8H41Ua2rDV/Kl9aAg9hqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uXaCqOoXF6eHHmgq5zXXF9c8r291D1tb7/Vq3HI/zWg=; b=jxc7wvaLEHt3en6VNSJrp6Tl9m+/H1arenISHmdmBZOloRstKJiyx8Ky+bPrezY5BnLn0O4YCKy+3KY217x/fWYAO2tgWof4mcE/ykpw3N5UuRj1FijXcOpK7UjYqXJtWzCbuSr5JdJBdIjCwdMeQhVd3tZwPnR9qjFRXM8FWWyxAjcMb46oawjLeGCxKoHN6AoDDaqGDi9linf80P7bhACWIsPO4SjttIuKLrzwRITm2jLrIuTUiTVACiseA5rVe9lb4PVLljMpJPoJPiXiNNCq5zVHNgTksHVp4Y2d4/mwkUniLpB6Wlr10jzS8EZGFS8UDqHFG5vCQ6BQYg4/GQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS1PR04MB9240.eurprd04.prod.outlook.com (2603:10a6:20b:4c4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.17; Tue, 31 Oct 2023 07:30:16 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25%3]) with mapi id 15.20.6954.016; Tue, 31 Oct 2023 07:30:16 +0000 Message-ID: <11cf8b73-7b95-5957-3bf0-c49a7e740773@suse.com> Date: Tue, 31 Oct 2023 08:30:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] gas: bpf: new test for MOV with C-like numbers ll suffix Content-Language: en-US To: "Jose E. Marchesi" Cc: binutils@sourceware.org References: <20231030150212.21445-1-jose.marchesi@oracle.com> <87wmv4ko9w.fsf@oracle.com> From: Jan Beulich In-Reply-To: <87wmv4ko9w.fsf@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0116.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9d::9) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS1PR04MB9240:EE_ X-MS-Office365-Filtering-Correlation-Id: 33861194-956a-4302-8397-08dbd9e33a40 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1wtW4mrepqSjN1I1g8LMWpIaORDGwnOBXXkkoHEaBs8zaEnwzdxfkomP5DClBdcK4vgcAogLxQY0trbgH1KUSoHB+oUOYMIfHgUqIQdxMNA8s1OKpOHWE7KNwHhF5vnzIHaA5E9KG6XGS0k05IJle4F5gnvUPpq6X7xtQlF19LEdNtOyhNXbP04Ktt1v8Gr1qVzOBqE33e1bne/EUEw4Jm37mOAC7n0VGDlX9zNCZs+z9herKtnWmsSrMxPXcs4cIbyHq4ohS5OZD3PYZRYI1dssmETBd4ieSMtoJZV8eCNBaUOfytPWdUde3wpayEqk3y7cA/8gd63xGmQTXygRNPhOH4xJ4m6gqj8X/2cqLLZD+bfanhh8HM/2t1Lsk2iyrG/63eVOaSvgxnnONxWJe4qouYCRZp7RshiIBEOfQDJw5Dn0PSi+/T9O/z2ttlk08A3NLo8h4AlXXE9qk7dbLnCD9O8BHF5zv1TrBpH8tIWwUmID/okDZnJLDKQdLIazgSVqV549lWTbl8fHeuzgHj/1S/dkm8euGAfffYz6Cjx8rZW6zNO8QXPfTcQ0HVngfmLdGv8B7F/I/Lr+qNfuuJmwv2yCxhHL+iSSoKUggERDDw/uLyvaH3f1zzbh95DfnBYJDphnv1GkHRuss4vSEA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(366004)(346002)(376002)(396003)(136003)(230922051799003)(186009)(451199024)(1800799009)(64100799003)(6486002)(66476007)(31696002)(36756003)(41300700001)(478600001)(86362001)(66556008)(66946007)(316002)(6916009)(8676002)(8936002)(4326008)(38100700002)(2906002)(4744005)(2616005)(26005)(5660300002)(6512007)(6506007)(31686004)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVBtdXVYSnhVN0xKSyt3a1dmYzBBMVByY2ZQRXdhTnFOWGI3WmdZK2d2SnlM?= =?utf-8?B?dk1ObnlkQXRsV0hHakhOQ2xHOHNDazlSbUNQcXcxc080U0xnR25mMFJLZWNa?= =?utf-8?B?ZnhndTF0aEtaa2JsK0hpYUFLSk9GQjUxTllWMGdhRG9SUVFCd2hEYmR0MWJs?= =?utf-8?B?OUZkSVp2cHBaK2hLVmRkVDFuWXdaamVUS00zaTZSNS9uY3BzTGhYZEZNWVhr?= =?utf-8?B?MWJhbm4ycWNSMlRHNmhadkVRaTlXSU1UNjBCbEI0dGgyWWoyQXI4My9DdjNn?= =?utf-8?B?Q3VDNHBDM0czOWZ4bjFCdnZLbjkwc29WbmlMSjRuZFN0eURhRjFkYlBoMC9V?= =?utf-8?B?bWlhbjVCT3V5dldDbEZRd1NLRTkvLzdsWXIyMTArN21lemFRRTBvM01XOEgv?= =?utf-8?B?cE5ZeDRSaFFNdEtxQXdtK3BrTmt6TDJ5c1BvTlZ5Yis5Q09GQnVUWFhMcnZo?= =?utf-8?B?RTFiWG5KczFFNHpUQzBZcG1meEZVOGU2K1NiS1dab1BSSm90dVByVXI5Qy93?= =?utf-8?B?RlB4bEZQSnhiVnhydDJXVVl2bjJKYWhsRDlySzRPYzBmNmFUTmR2eHc5RnhC?= =?utf-8?B?MTF1aEE2OWZucUtUTSt4VEF5S3gwQVN3VlZzRzlvcTVyMWpQT0piWHc4c1E1?= =?utf-8?B?alhERlByT1V2cm55R1R0NUtSYU9hNWo0WmFvazNjbjg0YklxcnRWbjUxaXdj?= =?utf-8?B?TWJKbml3d3hpVzk5UXVwMW9YVHFCbVRCc0gxVm9QZmNIZ21MR2Jsek5ZYmY4?= =?utf-8?B?dmtud2pTdnlnOWluaUFBQ2N4VTNjVnY5OVhmSWM1TjYxdzFxSUNmS1NkTDEy?= =?utf-8?B?QkdrdmJwZ3NSSmx3eUlPK1liQ2ZZQXBTOER5MGRIanZhQjQvVUkwOTVWUTcw?= =?utf-8?B?WHZ3ODhtY0t0NHVBMVRxNDhSTG1kS3ZPZ0E2b3Nmd3pBdHJnRmdYbUtSQkZs?= =?utf-8?B?QUVtQUVUeFhYMks3R0IzVlJycTlndXVuQzkvUDdGbVRNOWpkeGxxM3MxTDdL?= =?utf-8?B?N2V6VE1nMmQwbVBYVWdQa2lhd3d3elhKNXE1bndqVk5lU2JJWmNITEhnYVdW?= =?utf-8?B?c21xN0FDNm9DKzhOL3JXaUI0VWxXeHBXUXRmTjZaWTRNNTZCamxwZnRoVUFk?= =?utf-8?B?OG8vU3RIT1BDZU14S2NDblBhWWE3NFNPTDJxdTVsWFBUNGZsOVFyUVZOV05C?= =?utf-8?B?SDFrYVVzRFhpRjRRQ0FpUDRRNktTakphVjBWQUs4aWF0ZE5XcVB5VDIyOE8v?= =?utf-8?B?YlZFUXdWdXU0VHJZdUxFRGl4OVRSeEEwdzJQZWhDTW5Xd256ZGV3NVNSWE1O?= =?utf-8?B?SjQwc2laOFN5aDVhdDdnWm9RUUowd2hESzRwRG02V2lQenRQRHIzNHd6OTBN?= =?utf-8?B?Y2ZvUURpaE5kKzJIbjZEQXJpcWk5MVNtYXNFd0VrVFROdGMySEUzbzA0d2xp?= =?utf-8?B?azFUSnlmVEFxWHB6WkJLMXQwTVFkMjJIRS9wYVN6b3NHNERKc0oxbVZkNjBr?= =?utf-8?B?S2FuRUZjUy80K1lqR0xadEVQbG56UDZIaDhNRWhaUmlTNDhwU3BBUGpiM2t1?= =?utf-8?B?SStBNGJNQ2NEdjVKUGlMTXZNOHZSQlZGMDB3a3dNZ3JjQ0Y2bllxeVRxa2hm?= =?utf-8?B?bVkvaFpiN1IzUkk5UFBEV0EzV3FQS3NkSUZ6amFFZ0dNYWdPdGV0b082VCt6?= =?utf-8?B?ZmthWHMySE1zYXhqVDlZbzlXOEw3K2hoUE9aN2F3SGY1cVVJUE1jQWttNEx6?= =?utf-8?B?dkJncXdUYVR0R1RHUzljQzNlK3BzQVZiVEk1Q0ZIOTdtdmpQRE1aUmpTR0Mz?= =?utf-8?B?K2dxMGxUSGczZ2ZzZFNONVFlS1FqcURMZzB4Z1RBK0dHOU9tRTMwdC9OVHl6?= =?utf-8?B?TCs3NGt6VFRJNlRJcWxIQ0ZIMk50WjA1R29KZFhqZndSRVVnUGFCYk9hbytP?= =?utf-8?B?dVRJOEkzTjl4c3FPSExaS3lweTNqR0VjZDErUFNwRTl2Nm5IRXZTbVJtV0dl?= =?utf-8?B?MjhuZlVMeWl5MTQ1SkhUdmdvZ3dBRjBGbHhIZGpFMnhKWkJpc25GZFNrb0Q2?= =?utf-8?B?UDBYM0JZSmxUeWs5ZU1Md3Q3cnBqSjNRVnpoR0Rza0M3dnYrd2hzM0N4bUhH?= =?utf-8?Q?eDEaYAH2pYoTI5imqVEa04F1s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33861194-956a-4302-8397-08dbd9e33a40 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 07:30:16.2835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LHXvHGFbF1vAmNLXa5H/Tid7i4tk8clBifQsjqrOQvSY3l45YwMV9pkEkUXSlGGvr+TyZLM2XADLjMMt26s+0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9240 X-Spam-Status: No, score=-3028.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30.10.2023 18:34, Jose E. Marchesi wrote: > >> On 30.10.2023 16:02, Jose E. Marchesi wrote: >>> --- a/gas/testsuite/gas/bpf/alu-pseudoc.d >>> +++ b/gas/testsuite/gas/bpf/alu-pseudoc.d >>> @@ -69,3 +69,4 @@ Disassembly of section .text: >>> 1d0: d7 01 00 00 10 00 00 00 r1 = bswap16 r1 >>> 1d8: d7 02 00 00 20 00 00 00 r2 = bswap32 r2 >>> 1e0: d7 03 00 00 40 00 00 00 r3 = bswap64 r3 >>> + 1e8: b7 02 00 00 9a 02 00 00 r2=0x29a >>> \ No newline at end of file >> >> Just as a remark - issues like this would be really nice to be taken >> care of as files are touched. Imo much better than waiting for a >> separate cleanup patch. > > Your point being? "No newline at end of file" is something that shouldn't happen in any source files. Therefore when changing adjacent code it would be nice if the missing newline was inserted at the same time. Jan