From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2048.outbound.protection.outlook.com [40.107.20.48]) by sourceware.org (Postfix) with ESMTPS id BC80E382E291 for ; Thu, 13 Oct 2022 08:16:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BC80E382E291 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=STjyYXL5juzshJoYREBl5pMQfsiTUm0xrnTvybvJ/4JoiUxxIR9cHOmxGWJdnzBEiOLrW8ctcQoKo8UjEimc14BFibOAwA9t1HFJMAYj9cC0YTYo2nHHOz09p3ZHFwflYYSiJPZ0TdTrm7TLiwT3lZ2DMSroPf36CZXaFBbo+bftGajrcFNr/7MEdclOGy+6PRKh97kWDHvVE6UvlDhNySfJmabfDRtLzzR4a5FrLdcvbLtgJMQC92Wad/VT8BgJRqtGdYTlvBxh5RI2dnk0+fXWxhyJxwFMf7XwWYq4d4TmC96BxS5TfJrOd/7ceMzide/qNij968W5EA8cn5knBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RtSJnUVRppuZ6XK+Qu/A6Fp5nzWhqEYNnSRHovHBytI=; b=cO9E/LZMXlqOrCtd+dQnOyaKjtZji8IjJUYGE6YN7fdR8O5Q4gSf4rwOSxZliRIzKPwxpqeErSS7NfckIz5G3Gl9ljT9BoSWyzc9wRLXveXwL0G8h21JstkSZjcGmY1XTgw/12W2ruIzBdMi7ihJYO4XVOL2aGrRf8lZLMoeq85SOShseOpZthSUcdVeszusM+eLRcquG+OiX0hZKGoRjCkxeiu5LR2fy6h7eFHZJD3Tcm4uGZ3bXtehzX01vadRr1/AcmnPic5F7P9zdXg2Irb3tMxMzqUkuKkEN2rjP/7H2SeldntK6rLqfWIJgFffd6FX7WyehUzs1Dkv82dSwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RtSJnUVRppuZ6XK+Qu/A6Fp5nzWhqEYNnSRHovHBytI=; b=T/jDnWtYT/Ey6tOtUi5SChyZcpzLsb+bAuVHnLL6opxwdoUyDJL3mBgpR/052a6V7z7UzWAhV5vE/W8YXKHwP4lnBdHs6TRZk3bSM6r0BhnoHc86IyXjjIDbOZEAw9RoQNgkqFUWDYbRvpIgBSnzCrfO+TmZEbcShZmZnRvbqNFm1DfhjMrfCP7jDnCWLhCFtRmPSEROk+Jnd9tRuNBAJpngQckrlTmFpdf4LYUZi/uyZy3MiznxERv6a/HkWLXsynzGR0G/qg6mICyK5S8hw3uBG3AFJgn8Fs/8UCHKTLr0BWMZhAS79KybG+/xHxZgS8rXDOrAmpMPjfNgB70EOQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9220.eurprd04.prod.outlook.com (2603:10a6:102:228::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.19; Thu, 13 Oct 2022 08:16:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022 08:16:50 +0000 Message-ID: <1216a3f8-2273-8681-f528-9493a66891f0@suse.com> Date: Thu, 13 Oct 2022 10:16:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: [PATCH v4 1/8] x86: constify parse_insn()'s input Content-Language: en-US To: Binutils References: <4aa2665c-535f-da2d-1edb-4eb1f4195c3e@suse.com> Cc: "H.J. Lu" From: Jan Beulich In-Reply-To: <4aa2665c-535f-da2d-1edb-4eb1f4195c3e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB9220:EE_ X-MS-Office365-Filtering-Correlation-Id: 560e4f72-587a-4cf3-81ee-08daacf347b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2suCi3VJEzgW3F779wKszWAVFP7u8zwE7ff37k4vrHDbsSbo3LbBqfYqiPIrTSfYF5jpX1mU48UH9Rv7DkPDdbL7bf5qCgIdK0U8dTdEKpaHEjLmiZ/4I8TuB3kuHUSWjpDAvZiVmXbC2y5dTWbEVFU7uHoeIYIe/pcyuybuaLBV1ZPN4TQI4Hh0zWal0jQpt6SF9B2IOvhy/B7nv5qm80HzhBGeQSIQc0vakLThNwVvPZPVgQERI0ua4fxjcGblLWD1fdRBl4N+tjOSVUs/Is9fupNA5P4NTyxfZXhQ51loyMKNaogZiDtC/IjJ7cTs2nm4mc9A0ZBB6TEgaOPiDLkoO2/xBD2Te8RHUPcwshnJ6EstBQhTHkR2S++w6OHIiO+ZlEm7TQQxUA9+4RB6xgqEJhLliUkY2+t6L8gDk+Z5xH/6n0LqG1jo4dSFMD29yPqE7O5McdDQ3fcjV01l6NYI/eA0Eg3Q/8UB58L8Z15+iW55Ow5H6AJlLlkhjNPFdalNCHBt7nFm0nE75FKsInAaO5bNieaInT0WXEkrGMar4s9Vthxtust0XLPWI0QeQ67AhUjhHPzFBi4V7NFn/mhoqDj8X4cFOa0rfx7gDBOozCt6dVHmfkmNyo1TEH7zSyLv3U8MYr0LxE5w/iJeZrbGUZqZfp5Mma9NsfoPwYea530qN91A5U22fSJrElEb3mbRqreOlnr2wFldL20X7ckxsQXeQRHS0L5NPC0Le6B7p6ZmSllzQxWwDwHJI2Cm4en7HajhIzc08PUugVpHvCuAl6l5cMBP2QqIC0Do7E4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(366004)(396003)(376002)(136003)(39860400002)(451199015)(36756003)(31686004)(31696002)(86362001)(5660300002)(38100700002)(2616005)(186003)(2906002)(6506007)(478600001)(26005)(66476007)(66946007)(66556008)(6512007)(316002)(83380400001)(8676002)(6916009)(8936002)(4326008)(41300700001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djFCbW45WjU2Qm1GUnkycm0yMWZoRGtiWlkrU0NycXFBNmZCc05MRy9uSnh2?= =?utf-8?B?dGJxdXhYMDFmNzk1YUtaUGV1Vng0T0ZyNlZLVFpLSU95UmZ4S1NzcVRkTzQz?= =?utf-8?B?Y3FQK20rZFI4STBiM0RGbUpOelRoM21kdEFqUnBKNHBZcVRzeXlVeXE3SU5a?= =?utf-8?B?SUlUYUFpaFMzeXVwMjJ4blRHYVUwcFo1L2NHSVN6ZnlZamhsOE1BUTJMVW90?= =?utf-8?B?Rk5YWWZiNjVjaE1ReWhIb3EwaXZoNnNhbGR1aWI0cVhhRzFrdis5QThmTm9Q?= =?utf-8?B?TXI5cDh0cWdLR3J3dGFkaG9PMm5ZS3ZyTngzYWtGYSt6YnAyc1BEalRRK0s4?= =?utf-8?B?N005czlOMzhYZkF5Rk53ZUppWWx6QkFnR3haSXVySG9KNG9lN2U4bGFlUVhw?= =?utf-8?B?VlVPVzZYV0RYamh4c3ZyUXpGTk0wNGxsVWhHLzNmUXpDekExLzFSWlc5WjNC?= =?utf-8?B?R2dHNUM2WUJWYVl1ZkxJKzdMaUtyMDBjeGltaEdiQjdaTzJLRi9lVWU4NFBp?= =?utf-8?B?OHdHTjJTRlhzZWI4cVpVY280UzRmVUNUU2w3NzNCN005LzYxY1FkdXpTa0Z6?= =?utf-8?B?Q0ZqVy8xVXBUVERCdFRUNUluSFFEYW9WZlhYNkZYWUd1Q0N0NDEyc3cvQTRP?= =?utf-8?B?Q0VmNkJjQnp2VzI5RjVKelAybFUyZ3dNV2E1ZnZvVjZlWXJscU1FOGdVT0Rj?= =?utf-8?B?UnNvTUJGQ3lzOXJrcHNuN1MwQTFzQ1ptbW5pcFQ0SVZNOThQQWdtdHN2ZFZH?= =?utf-8?B?YzRYUVZBd2U5WjZOWTZRbHJLNW9SYzNTTmZjLzZEWnFOQnJ0VE1ITEhMcGxH?= =?utf-8?B?RGtYMHlsNGVQYTFKSGJGQWEvbmNQMWJ2c2hNbTlsOEtjNEhNTGZHSmRmT1Y3?= =?utf-8?B?a252VlVJZFkzelcySFJ3clExeDNXMXpWZHBBOFUzS2FuTkRuOWRuS091b0Zm?= =?utf-8?B?aUhPY0diODd6MFBOVW9MbEsyKzZYelZ5S0tZV3EvdmNhS2pGUTM5dll5dG5v?= =?utf-8?B?eFlBa0xvNnVHTUMrSTZMMGhSWnZtRUYwWmVZMDRUYmJBWkJqQXRoTU1TUms2?= =?utf-8?B?UVI3dTBIL3FnNTZpRnVqa01LYkU3MlJHc1FpTDlWUjdVdlEyYkNSWU9KNkp3?= =?utf-8?B?VUh1RFU2eXZuSGtUREdHNFhReHpkYnpkaVlRQlQ1VlFENEtUcms1Y2ZjYmIy?= =?utf-8?B?bjk0MVhSNVhrQnlwMjFmdldKMGtIOG1rQ1AzRzZ4MEJrb0xBTktJaXk3MEg4?= =?utf-8?B?L1NFcEZzYUI4SzV2QXI1VXh4SVBnMXRMcWdPeFpzMWltcGNaRHE2L3FDWVAw?= =?utf-8?B?VlAzanRDS0NIVjM1RytzUXlhK0hPZ2FmUTY5cjZMZlZVY1hwU1dHeXByWG14?= =?utf-8?B?UGJ3R0Q5aGU4LzdkMUhqZktrc1ZrK3Rqa05hQ0duazJzY0J4a3FYQURpTmVw?= =?utf-8?B?U2R1dGFXYnF0NWRaTUhQZFpoVkpaUDdDL2o4WlZBU250R0MwRHhQYWk0N3pF?= =?utf-8?B?V1Bick5ob3R5TnBrUy84dDViUy80aklOV3hJeXlaY3FTUUpjVHloTEc3YkpK?= =?utf-8?B?OVVBU081ZFpYOG9zd25NWVM4VHVQQ3kzdm1va2JTS2IwNVhYeVQzb2JGM05V?= =?utf-8?B?SDZnc2lqTXljV3JyU3VJektteDFuYTR1UGZIczR3TGFQbVRyek1XK0c0NHdu?= =?utf-8?B?RkF4MEtZbkZzRXV1OTVaZm5Pb1l2QVhwNTJheXY5Z2NqUlZQWHhkVG9CY2wr?= =?utf-8?B?M3ZHSGtVemw1R1MxaDFvSUtDOWlHOGxuV1MwZlV6RnZaWXNqWjJhdThNK0VE?= =?utf-8?B?RytBNWlnSXcyT2tXWU5JeTlaT3BJN3NQQnl2eWtjZ3VxZ2R5Tm5DbnBNSGw2?= =?utf-8?B?eVZVNUQrQm9EcTIyNVgySWhUTkZRUzF6UU42dWlENVhubUpIK252ZzB5Y3Q4?= =?utf-8?B?cnRsRGlKcnNnVVhNMm9ndXI1VGFuaGRsTitja3VMeFZYZGlteWpmSUlQVlZj?= =?utf-8?B?L3QxZk5PTEordVpVS1hKZXhYS3J4dEloT2JtYkc1STNEbVY5dmxMOXVGTSs5?= =?utf-8?B?NGk0elMrNkYySExMaVBpWEJ6a1FLU2FBNmZnbnlPQ21xRmJ1UWZzK3RuYUc4?= =?utf-8?Q?TYhsmQZ2FZIDnzxLkWaJmkl7H?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 560e4f72-587a-4cf3-81ee-08daacf347b2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2022 08:16:50.7820 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WlPycbBBp9cl46Cz6urw9snMBGNmSYpj6oAi4hGnTm8HC5ziY8zzE9ZN+KYruyQHP9lIiihAw5oXZoeA9HNVRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9220 X-Spam-Status: No, score=-3029.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The function doesn't alter its input buffer: Reflect this in its prototype. To avoid using any kind of cast, simply calculate the update of "line" from the function's input and output. --- Avoiding a cast the way it's done here is going to be useful in subsequent patches (there'll be code added between the call and the update of "line"), so switching to a cast is not really an option. --- v3: New. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -157,7 +157,7 @@ static int i386_intel_operand (char *, i static int i386_intel_simplify (expressionS *); static int i386_intel_parse_name (const char *, expressionS *); static const reg_entry *parse_register (char *, char **); -static char *parse_insn (char *, char *); +static const char *parse_insn (const char *, char *); static char *parse_operands (char *, const char *); static void swap_operands (void); static void swap_2_operands (unsigned int, unsigned int); @@ -4820,6 +4820,7 @@ md_assemble (char *line) { unsigned int j; char mnemonic[MAX_MNEM_SIZE], mnem_suffix; + const char *end; const insn_template *t; /* Initialize globals. */ @@ -4835,9 +4836,10 @@ md_assemble (char *line) We assume that the scrubber has arranged it so that line[0] is the valid start of a (possibly prefixed) mnemonic. */ - line = parse_insn (line, mnemonic); - if (line == NULL) + end = parse_insn (line, mnemonic); + if (end == NULL) return; + line += end - line; mnem_suffix = i.suffix; line = parse_operands (line, mnemonic); @@ -5217,11 +5219,10 @@ md_assemble (char *line) last_insn.kind = last_insn_other; } -static char * -parse_insn (char *line, char *mnemonic) +static const char * +parse_insn (const char *line, char *mnemonic) { - char *l = line; - char *token_start = l; + const char *l = line, *token_start = l; char *mnem_p; int supported; const insn_template *t;