* [PATCH] opcodes: blackfin: constify formatting related structures
@ 2010-09-21 6:21 Mike Frysinger
2010-09-22 20:33 ` Mike Frysinger
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2010-09-21 6:21 UTC (permalink / raw)
To: binutils
No need for these local structures related to formatting of output to
be writable, so constify the whole shebang.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2010-09-21 Mike Frysinger <vapier@gentoo.org>
* bfin-dis.c (constant_formats): Constify the whole structure.
(fmtconst): Add const to return value.
(reg_names): Mark const.
(decode_multfunc): Mark s0/s1 as const.
(decode_macfunc): Mark a/sop as const.
---
opcodes/bfin-dis.c | 44 ++++++++++++++++++++++----------------------
1 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/opcodes/bfin-dis.c b/opcodes/bfin-dis.c
index 4741d20..2f77c61 100644
--- a/opcodes/bfin-dis.c
+++ b/opcodes/bfin-dis.c
@@ -53,6 +53,9 @@ typedef long TIword;
typedef unsigned int bu32;
+static char comment = 0;
+static char parallel = 0;
+
typedef enum
{
c_0, c_1, c_4, c_2, c_uimm2, c_uimm3, c_imm3, c_pcrel4,
@@ -62,20 +65,20 @@ typedef enum
c_uimm16s4d, c_uimm16, c_pcrel24, c_uimm32, c_imm32, c_huimm32, c_huimm32e,
} const_forms_t;
-static struct
+static const struct
{
- char *name;
- int nbits;
- char reloc;
- char issigned;
- char pcrel;
- char scale;
- char offset;
- char negative;
- char positive;
- char decimal;
- char leading;
- char exact;
+ const char *name;
+ const int nbits;
+ const char reloc;
+ const char issigned;
+ const char pcrel;
+ const char scale;
+ const char offset;
+ const char negative;
+ const char positive;
+ const char decimal;
+ const char leading;
+ const char exact;
} constant_formats[] =
{
{ "0", 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0},
@@ -123,11 +126,8 @@ static struct
{ "huimm32e", 32, 1, 0, 0, 0, 0, 0, 0, 0, 0, 1},
};
-static char comment = 0;
-static char parallel = 0;
-
-static char *
-fmtconst (const_forms_t cf, TIword x, bfd_vma pc, disassemble_info * outf)
+static const char *
+fmtconst (const_forms_t cf, TIword x, bfd_vma pc, disassemble_info *outf)
{
static char buf[60];
@@ -254,7 +254,7 @@ enum reg_class
LIM_REG_CLASSES
};
-static char *reg_names[] =
+static const char *reg_names[] =
{
"R0.L", "R1.L", "R2.L", "R3.L", "R4.L", "R5.L", "R6.L", "R7.L",
"R0.H", "R1.H", "R2.H", "R3.H", "R4.H", "R5.H", "R6.H", "R7.H",
@@ -557,7 +557,7 @@ aligndir (int r0, disassemble_info *outf)
static int
decode_multfunc (int h0, int h1, int src0, int src1, disassemble_info * outf)
{
- char *s0, *s1;
+ const char *s0, *s1;
if (h0)
s0 = dregs_hi (src0);
@@ -578,8 +578,8 @@ decode_multfunc (int h0, int h1, int src0, int src1, disassemble_info * outf)
static int
decode_macfunc (int which, int op, int h0, int h1, int src0, int src1, disassemble_info * outf)
{
- char *a;
- char *sop = "<unknown op>";
+ const char *a;
+ const char *sop = "<unknown op>";
if (which)
a = "A1";
--
1.7.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] opcodes: blackfin: constify formatting related structures
2010-09-21 6:21 [PATCH] opcodes: blackfin: constify formatting related structures Mike Frysinger
@ 2010-09-22 20:33 ` Mike Frysinger
0 siblings, 0 replies; 2+ messages in thread
From: Mike Frysinger @ 2010-09-22 20:33 UTC (permalink / raw)
To: binutils
[-- Attachment #1: Type: Text/Plain, Size: 197 bytes --]
On Tuesday, September 21, 2010 02:20:46 Mike Frysinger wrote:
> No need for these local structures related to formatting of output to
> be writable, so constify the whole shebang.
committed
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-22 20:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-21 6:21 [PATCH] opcodes: blackfin: constify formatting related structures Mike Frysinger
2010-09-22 20:33 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).