[PATCH] gas: blackfin: clarify some errors with register usage in insns

[PATCH] gas: blackfin: clarify some errors with register usage in insns

[Mike Frysinger]

From: Robin Getz <robin.getz@analog.com>

Using "Register mismatch" everywhere can be a bit vague, so clarify
why exactly we're barfing on these unsupported insns.

Signed-off-by: Robin Getz <robin.getz@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>

gas/:
2010-09-21  Robin Getz  <robin.getz@analog.com>

	* config/bfin-parse.y: Improve error messages.

gas/testsuite/:
2010-09-21  Robin Getz  <robin.getz@analog.com>

	* gas/bfin/expected_move_errors.l: Update error output.
---
 gas/config/bfin-parse.y                       |    6 +++---
 gas/testsuite/gas/bfin/expected_move_errors.l |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/gas/config/bfin-parse.y b/gas/config/bfin-parse.y
index a520226..4549b53 100644
--- a/gas/config/bfin-parse.y
+++ b/gas/config/bfin-parse.y
@@ -1737,7 +1737,7 @@ asm_1:
 	      $$ = bfin_gen_regmv (&$3, &$1);
 	    }
 	  else
-	    return yyerror ("Register mismatch");
+	    return yyerror ("Unsupported register move");
 	}
 
 	| CCREG ASSIGN REG
@@ -1748,7 +1748,7 @@ asm_1:
 	      $$ = bfin_gen_cc2dreg (1, &$3);
 	    }
 	  else
-	    return yyerror ("Register mismatch");
+	    return yyerror ("Only 'CC = Dreg' supported");
 	}
 
 	| REG ASSIGN CCREG
@@ -1759,7 +1759,7 @@ asm_1:
 	      $$ = bfin_gen_cc2dreg (0, &$1);
 	    }
 	  else
-	    return yyerror ("Register mismatch");
+	    return yyerror ("Only 'Dreg = CC' supported");
 	}
 
 	| CCREG _ASSIGN_BANG CCREG
diff --git a/gas/testsuite/gas/bfin/expected_move_errors.l b/gas/testsuite/gas/bfin/expected_move_errors.l
index 9a98746..524822e 100644
--- a/gas/testsuite/gas/bfin/expected_move_errors.l
+++ b/gas/testsuite/gas/bfin/expected_move_errors.l
@@ -3,4 +3,4 @@
 .*:4: Error: Cannot move A0 to high half of register. Input text was A0.
 .*:5: Error: Cannot move A1 to even register.
 .*:6: Error: Cannot move A0 to odd register.
-.*:7: Error: Register mismatch.
+.*:7: Error: Unsupported register move.
-- 
1.7.2

Re: [PATCH] gas: blackfin: clarify some errors with register usage in insns

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 259 bytes --]

On Tuesday, September 21, 2010 03:38:27 Mike Frysinger wrote:
> From: Robin Getz <robin.getz@analog.com>
> 
> Using "Register mismatch" everywhere can be a bit vague, so clarify
> why exactly we're barfing on these unsupported insns.

committed
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]