From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19507 invoked by alias); 21 Feb 2011 17:14:04 -0000 Received: (qmail 19215 invoked by uid 22791); 21 Feb 2011 17:14:01 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Feb 2011 17:13:57 +0000 Received: from localhost.localdomain (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id C03871B414F; Mon, 21 Feb 2011 17:13:55 +0000 (UTC) From: Mike Frysinger To: binutils@sourceware.org Cc: toolchain-devel@blackfin.uclinux.org Subject: [PATCH] opcodes: blackfin: drop null/nul checks in OUTS Date: Mon, 21 Feb 2011 17:14:00 -0000 Message-Id: <1298308450-18769-1-git-send-email-vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00262.txt.bz2 Parts of the disassembler rely on the disasm info never being NULL (such as being able to read memory to disassemble in the first place). So drop useless null checks in the OUTS helper. Signed-off-by: Mike Frysinger 2011-02-05 Mike Frysinger * bfin-dis.c (OUTS): Remove p NULL check and txt NUL check. --- opcodes/bfin-dis.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/opcodes/bfin-dis.c b/opcodes/bfin-dis.c index e7c81b4..3a23fd9 100644 --- a/opcodes/bfin-dis.c +++ b/opcodes/bfin-dis.c @@ -490,7 +490,7 @@ static const enum machine_registers decode_allregs[] = /* (arch.pm)arch_disassembler_functions. */ #ifndef OUTS -#define OUTS(p, txt) ((p) ? (((txt)[0]) ? (p->fprintf_func)(p->stream, "%s", txt) :0) :0) +#define OUTS(p, txt) (p)->fprintf_func ((p)->stream, "%s", txt) #endif static void -- 1.7.4.1