From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D9E173857C4F; Thu, 2 Dec 2021 02:44:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D9E173857C4F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1B22iPkv009666 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 1 Dec 2021 21:44:30 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1B22iPkv009666 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 8800C1EDF0; Wed, 1 Dec 2021 21:44:25 -0500 (EST) Message-ID: <129a1b7e-84dd-224c-6624-92dfb6e69dcb@polymtl.ca> Date: Wed, 1 Dec 2021 21:44:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 1/2] gdb: replace pragmas with DIAGNOSTIC macros Content-Language: en-US To: Simon Marchi , Tom de Vries , gdb-patches@sourceware.org, binutils@sourceware.org References: <20211123211437.3783065-1-simon.marchi@efficios.com> <1eb6f676-06f2-d091-19c9-f3b522fb4a6e@efficios.com> From: Simon Marchi In-Reply-To: <1eb6f676-06f2-d091-19c9-f3b522fb4a6e@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 2 Dec 2021 02:44:25 +0000 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2021 02:44:34 -0000 On 2021-12-01 20:56, Simon Marchi via Gdb-patches wrote: > On 2021-12-01 19:09, Tom de Vries wrote: >> On 11/23/21 10:14 PM, Simon Marchi via Gdb-patches wrote: >>> When introducing this code, I forgot that we had some macros for this. >>> Replace some "manual" pragma diagnostic with some DIAGNOSTIC_* macros, >>> provided by include/diagnostics.h. >>> >>> In diagnostics.h: >>> >>> - Add DIAGNOSTIC_ERROR, to enable a diagnostic at error level. >>> - Add DIAGNOSTIC_ERROR_SWITCH, to enable -Wswitch at error level, for >>> both gcc and clang. >>> >> >> I think you forgot the default definition >> ... >> #ifndef DIAGNOSTIC_ERROR_SWITCH >> # define DIAGNOSTIC_ERROR_SWITCH >> #endif >> ... >> >> Otherwise, LGTM. >> >> Thanks, >> - Tom > > Right, fixed locally. > > I would just like to get an Ack from a binutils maintainer, if possible, > since this touches the include directory. > > Simon > Actually, I posted a v2 which obsoletes this patch, see: https://sourceware.org/pipermail/gdb-patches/2021-December/184043.html Simon