From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 5CD4D385701E for ; Tue, 25 Oct 2022 14:54:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5CD4D385701E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 0EC53300089; Tue, 25 Oct 2022 14:54:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com; s=2017s01; t=1666709652; bh=q1vCkzvRhadNFconDNrtp9q8Z23S2qqUqrbPbtjP1yA=; h=Message-ID:Date:Mime-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=oPzUSTeijgBxU9BIcjeAQ5mnlQDcaWwsSeKRBNCeWm731d/rIVIa5X6l6EKxSyqW3 +cWYiAn+2IVAgQBHzJMqb7FHx0pWAzzwk0oIURNLim5FI7kNymr2UatpfgemUgrfig N+Yk+hNgR7WqsinVovjGO5PTHWm2dw9RLL7QzzCc= Message-ID: <131a0f94-91c3-c850-130b-598ee0afb998@irq.a4lg.com> Date: Tue, 25 Oct 2022 23:54:10 +0900 Mime-Version: 1.0 Subject: Re: [PATCH 0/2] RISC-V: Use only real extension names on testsuite Content-Language: en-US To: Nelson Chu , Kito Cheng , Palmer Dabbelt Cc: binutils@sourceware.org References: From: Tsukasa OI In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping. On 2022/09/23 16:49, Tsukasa OI wrote: > Hi, > > Most of the RISC-V GAS testsuite uses real extension names but there are a > few counterexamples. I will talk about following tests: > > - b-ext{,-64} for ("Zb*" except "Zbk*") > - k-ext{,-64} for ("Zk*" and "Zbk*") > > They: > - provide unnecessary confusion (that major "B" and "K" extensions exist), > for example shown in: > and > - do not test separate extension > (they are multiple subextensions). > > To avoid confusion and test individual extensions separately, this patchset > provides per-extension testcases and removes b-ext{,-64} and k-ext{,-64}. > > There's another effect. Splitting "B" testcases will clarify that "zext.h" > and "zext.w" (seemingly similar) instructions belong to different extension: > > - "zext.h" (RV32/64_Zbb) > - "zext.w" (RV64_Zba) <-- not Zbb! > > [Changes] > > - Split b-ext and b-ext-64 to: > - zba{,-64} > - zbb{,-64} > - zbc > - zbs{,-64} > - Reuse existing "zk*" and "zbk*" testcases because they are fine as is, > - Add new testcases for separate extension: > - zkr (along with 'Zicsr', to test "seed" CSR accessibility) > - zkt (just to test extension support) > - Remove: > - b-ext{,-64} > - k-ext{,-64} > > For vector-insn*, I'll leave this for now but it might possible to split > (e.g. to three testcases for two instruction classes and INSN_V_EEW64). > Still, I think this is not as important as b-ext{,-64} and k-ext{,-64} and > I don't complain about using vector-insn* names themselves. > > Thanks, > Tsukasa > > > > > Tsukasa OI (2): > RISC-V: Reorganize "K"-related subextension tests > RISC-V: Reorganize "B"-related subextension tests > > gas/testsuite/gas/riscv/b-ext-64.d | 72 ------------------------------ > gas/testsuite/gas/riscv/b-ext-64.s | 64 -------------------------- > gas/testsuite/gas/riscv/b-ext.d | 51 --------------------- > gas/testsuite/gas/riscv/b-ext.s | 43 ------------------ > gas/testsuite/gas/riscv/k-ext-64.d | 47 ------------------- > gas/testsuite/gas/riscv/k-ext-64.s | 38 ---------------- > gas/testsuite/gas/riscv/k-ext.d | 44 ------------------ > gas/testsuite/gas/riscv/k-ext.s | 35 --------------- > gas/testsuite/gas/riscv/zba-64.d | 19 ++++++++ > gas/testsuite/gas/riscv/zba.d | 12 +++++ > gas/testsuite/gas/riscv/zba.s | 14 ++++++ > gas/testsuite/gas/riscv/zbb-64.d | 36 +++++++++++++++ > gas/testsuite/gas/riscv/zbb.d | 28 ++++++++++++ > gas/testsuite/gas/riscv/zbb.s | 34 ++++++++++++++ > gas/testsuite/gas/riscv/zbc.d | 12 +++++ > gas/testsuite/gas/riscv/zbc.s | 4 ++ > gas/testsuite/gas/riscv/zbs-64.d | 34 ++++++++++++++ > gas/testsuite/gas/riscv/zbs.d | 25 +++++++++++ > gas/testsuite/gas/riscv/zbs.s | 32 +++++++++++++ > gas/testsuite/gas/riscv/zkr.d | 10 +++++ > gas/testsuite/gas/riscv/zkr.s | 2 + > gas/testsuite/gas/riscv/zkt.d | 5 +++ > 22 files changed, 267 insertions(+), 394 deletions(-) > delete mode 100644 gas/testsuite/gas/riscv/b-ext-64.d > delete mode 100644 gas/testsuite/gas/riscv/b-ext-64.s > delete mode 100644 gas/testsuite/gas/riscv/b-ext.d > delete mode 100644 gas/testsuite/gas/riscv/b-ext.s > delete mode 100644 gas/testsuite/gas/riscv/k-ext-64.d > delete mode 100644 gas/testsuite/gas/riscv/k-ext-64.s > delete mode 100644 gas/testsuite/gas/riscv/k-ext.d > delete mode 100644 gas/testsuite/gas/riscv/k-ext.s > create mode 100644 gas/testsuite/gas/riscv/zba-64.d > create mode 100644 gas/testsuite/gas/riscv/zba.d > create mode 100644 gas/testsuite/gas/riscv/zba.s > create mode 100644 gas/testsuite/gas/riscv/zbb-64.d > create mode 100644 gas/testsuite/gas/riscv/zbb.d > create mode 100644 gas/testsuite/gas/riscv/zbb.s > create mode 100644 gas/testsuite/gas/riscv/zbc.d > create mode 100644 gas/testsuite/gas/riscv/zbc.s > create mode 100644 gas/testsuite/gas/riscv/zbs-64.d > create mode 100644 gas/testsuite/gas/riscv/zbs.d > create mode 100644 gas/testsuite/gas/riscv/zbs.s > create mode 100644 gas/testsuite/gas/riscv/zkr.d > create mode 100644 gas/testsuite/gas/riscv/zkr.s > create mode 100644 gas/testsuite/gas/riscv/zkt.d > > > base-commit: 8e037eae6823caf5b9cb5b4feb3de838abb25956