Re: Release 2.22: Next week ...

[James Murray <jsm@jsm-net.demon.co.uk>]

On 17/11/11 14:50, Tristan Gingold wrote: 

References: <ADFB3A72-FDFA-4402-A6D5-CADEA94D0ED2@adacore.com>
<1747C46F-9EE9-4FE6-B84C-09DC53F21DE0@adacore.com>
<2E7397C5-D6E3-4DEC-812E-156DEBA441A8@adacore.com>

> I have run the testsuite for most of the targets. 
> m68hc11-elf: OK

Seems ok, but what about the sub-targets? They fail the test-suite.
m68hc11-elf  PASS
m68hc12-elf - 10 gas failures
m6811-elf - 5 gas failures
m6812-elf - 15 gas failures

Does this matter? Should the tests only be run with the 'main' target?

I believe the following patch resolves the 10 gas failures on
m68hc12-elf, the hc11 tests were being run without a target specified,
so will only work if the target is built as m68hc11. When they then run
as hc12 they do not spit out the expected error as those operands/modess
are valid on hc12.

###########################
diff -Nuar -x '.#*' -x CVS src/gas/testsuite/gas/m68hc11/m68hc11.exp
binutils-20111216/gas/testsuite/gas/m68hc11/m68hc11.exp
--- src/gas/testsuite/gas/m68hc11/m68hc11.exp 2004-08-01
20:59:51.000000000 +0100
+++ binutils-20111216/gas/testsuite/gas/m68hc11/m68hc11.exp 2011-12-17
02:07:50.000000000 +0000
@@ -78,28 +82,29 @@
     gas_m68hc11_message "Warning" $options $line $expect
}

+#add machine option as default is now m9s12x
# ------------------
# 68HC11 error tests
-gas_m68hc11_error "" "puld\n" "Opcode .puld. is not recognized"
-gas_m68hc11_error "" "ldab\n" "Invalid operand for .ldab."
-gas_m68hc11_error "" "ldab 256,x\n" "Operand out of 8-bit range:.*256"
-gas_m68hc11_error "" "ldab 257,y\n" "Operand out of 8-bit range:.*257"
-gas_m68hc11_error "" "ldab -1,y\n" "Operand out of 8-bit range:.*-1"
-gas_m68hc11_error "" "ldab bar,y\nbar=300" "value of 300 too large for
field of 1 byte"
-gas_m68hc11_error "" "jmp \#23\n" "Immediate operand is not allowed"
-gas_m68hc11_error "" "ldab \[d,pc\]\n" "Indirect indexed addressing is
not valid for 68HC11"
-gas_m68hc11_error "" "ldab ,t\n" "Spurious .,. or bad indirect
register"
-gas_m68hc11_error "" "ldab 1,t\n" "Garbage at end of instruction:.*,t"
-gas_m68hc11_error "" "ldab 1,,x\n" "Garbage at end of instruction:.*,x"
-gas_m68hc11_error "" "ldab 1,+x\n" "Pre-increment mode is not valid"
-gas_m68hc11_error "" "ldab 1,-x\n" "Pre-increment mode is not valid"
-gas_m68hc11_error "" "ldab 1,x+\n" "Post-increment mode is not valid"
-gas_m68hc11_error "" "ldab 1,x-\n" "Post-decrement mode is not valid"
-gas_m68hc11_error "" "ldd \#65536\n" "Operand out of 16-bit range"
-gas_m68hc11_error "--short-branchs" "bne 200\n" \
+gas_m68hc11_error "-m68hc11" "puld\n" "Opcode .puld. is not recognized"
+gas_m68hc11_error "-m68hc11" "ldab\n" "Invalid operand for .ldab."
+gas_m68hc11_error "-m68hc11" "ldab 256,x\n" "Operand out of 8-bit
range:.*256"
+gas_m68hc11_error "-m68hc11" "ldab 257,y\n" "Operand out of 8-bit
range:.*257"
+gas_m68hc11_error "-m68hc11" "ldab -1,y\n" "Operand out of 8-bit
range:.*-1"
+gas_m68hc11_error "-m68hc11" "ldab bar,y\nbar=300" "value of 300 too
large for field of 1 byte"
+gas_m68hc11_error "-m68hc11" "jmp \#23\n" "Immediate operand is not
allowed"
+gas_m68hc11_error "-m68hc11" "ldab \[d,pc\]\n" "Indirect indexed
addressing is not valid for 68HC11"
+gas_m68hc11_error "-m68hc11" "ldab ,t\n" "Spurious .,. or bad indirect
register"
+gas_m68hc11_error "-m68hc11" "ldab 1,t\n" "Garbage at end of
instruction:.*,t"
+gas_m68hc11_error "-m68hc11" "ldab 1,,x\n" "Garbage at end of
instruction:.*,x"
+gas_m68hc11_error "-m68hc11" "ldab 1,+x\n" "Pre-increment mode is not
valid"
+gas_m68hc11_error "-m68hc11" "ldab 1,-x\n" "Pre-increment mode is not
valid"
+gas_m68hc11_error "-m68hc11" "ldab 1,x+\n" "Post-increment mode is not
valid"
+gas_m68hc11_error "-m68hc11" "ldab 1,x-\n" "Post-decrement mode is not
valid"
+gas_m68hc11_error "-m68hc11" "ldd \#65536\n" "Operand out of 16-bit
range"
+gas_m68hc11_error "-m68hc11 --short-branchs" "bne 200\n" \
     "Operand out of range for a relative branch"
-gas_m68hc11_error "" "bar\n" "Opcode .bar. is not recognized."
-gas_m68hc11_error "--print-insn-syntax" "bne\n" \
+gas_m68hc11_error "-m68hc11" "bar\n" "Opcode .bar. is not recognized."
+gas_m68hc11_error "-m68hc11 --print-insn-syntax" "bne\n" \
     "Instruction formats for .bne..*"

# ------------------
###########################

However, resolving those then exposes 10 test failures in ld. I have not
yet investigated those.

My reason for asking is that I have some work to submit on the m68hc11
target and don't want to be rejected on these testsuite failures.
(My previous attempt at submission in Feb/Mar did expose some genuine
regressions which I have since corrected.)

regards

James Murray

PS. I hope the References works ok, I find it tricky to reply with
correct headers when I receive only the digest and the online version
doesn't display the Message-id. Any tips?