From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26512 invoked by alias); 12 Jan 2012 19:39:26 -0000 Received: (qmail 26503 invoked by uid 22791); 12 Jan 2012 19:39:26 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from anchor-post-3.mail.demon.net (HELO anchor-post-3.mail.demon.net) (195.173.77.134) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jan 2012 19:39:12 +0000 Received: from jsm-net.demon.co.uk ([80.176.88.36]) by anchor-post-3.mail.demon.net with esmtp (Exim 4.69) id 1RlQUR-00004n-oh for binutils@sourceware.org; Thu, 12 Jan 2012 19:39:11 +0000 Received: (from jsm@localhost) by jsm-net.demon.co.uk (8.14.4/8.12.5/Submit) id q0CJd7oh013294 for binutils@sourceware.org; Thu, 12 Jan 2012 19:39:07 GMT Subject: Re: 68hc11/12/s12x/xgate patch - style question From: James Murray To: binutils@sourceware.org In-Reply-To: <1326210316.20629.199.camel@jsm2> References: <1298845471.12108.12.camel@jsm2> <1299515895.3262.1.camel@jsm2> <4D7F247D.6070303@redhat.com> <1300201861.20997.3.camel@jsm2> <1324419607.8652.84.camel@jsm2> <1324423375.8652.94.camel@jsm2> <4EF36049.3050802@ipdatasys.com> <1324575421.2430.42.camel@jsm2> <1325800936.20629.53.camel@jsm2> <4F0C4DFE.4050801@redhat.com> <1326210316.20629.199.camel@jsm2> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Date: Thu, 12 Jan 2012 19:39:00 -0000 Message-ID: <1326397146.20629.242.camel@jsm2> Mime-Version: 1.0 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00168.txt.bz2 On Tue, 2012-01-10 at 15:45 +0000, James Murray wrote: > On Tue, 2012-01-10 at 14:41 +0000, nick clifton wrote: > *) There are some formatting problems. Ideally we like code that=20 > > follows the GNU Coding Standard: >=20=20 I've read through the document and the main issues as-is are the ones Nick already highlighted (brace style and space after function name.) The document mentions that "indent" can apply the desired formatting. It would be straightforward enough for me to do that, but then the patch would also include any formatting changes to the existing code which could obscure that functional changes. So what do the maintainers prefer? Should the patch be just what I've changed or should I use indent and reformat the whole of hc11 files I've touched. regards James Murray