From: James Murray <jsm@jsm-net.demon.co.uk>
To: binutils@sourceware.org
Cc: nick clifton <nickc@redhat.com>
Subject: Re: 68hc11/12/s12x/xgate patch
Date: Sun, 26 Feb 2012 23:54:00 -0000 [thread overview]
Message-ID: <1330300482.15684.10.camel@jsm2> (raw)
In-Reply-To: <4F0C4DFE.4050801@redhat.com>
Status update.
On Tue, 2012-01-10 at 14:41 +0000, nick clifton wrote:
> Hi James,
> *) You have included a patch to the top level configure file, but not
> the top level configure.ac file (from which the configure file is
> generated).
I've removed my changes and used the existing build targets.
> *) You have included a patch to the top level config.sub file. Are you
> aware that this patch needs to be submitted to a different project ?
> (config-patches@gnu.org)
I've removed my changes and used the existing build targets.
> *) You have included patches to various ChangeLogs. Common practice is
> just to include changelog entries as plain text, since they almost never
> apply cleanly as patches.
Ready to submit as plain text.
> *) You have added new options to the m68hc11 GAS port, but not added
> documentation for these new options to the gas/doc/c-m68hc11.texi file.
OK, added.
> *) You have added support for a new processor, but not mentioned it in
> either gas/NEWS or ld/NEWS.
OK, added.
> *) There are some formatting problems. Ideally we like code that
> follows the GNU Coding Standard: http://www.gnu.org/prep/standards/
Understood and hopefully now addressed.
I intend to spend some more time reviewing my patch and will re-submit
once I have completed that.
regards
James Murray
next prev parent reply other threads:[~2012-02-26 23:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-27 22:22 James Murray
2011-03-07 16:35 ` James Murray
2011-03-15 8:33 ` Nick Clifton
2011-03-15 15:08 ` James Murray
2011-12-20 22:20 ` James Murray
2011-12-20 22:29 ` Fred Cooke
2011-12-20 23:23 ` James Murray
2011-12-21 22:29 ` Fred Cooke
2011-12-22 16:52 ` Sean Keys
2011-12-22 17:37 ` James Murray
2012-01-05 22:03 ` James Murray
2012-01-05 23:11 ` Fred Cooke
2012-01-10 14:42 ` nick clifton
2012-01-10 15:45 ` James Murray
2012-01-12 19:39 ` 68hc11/12/s12x/xgate patch - style question James Murray
2012-01-12 20:14 ` Fred Cooke
2012-02-26 23:54 ` James Murray [this message]
2012-03-12 15:07 ` 68hc11/12/s12x/xgate patch James Murray
2012-03-12 15:26 ` Fred Cooke
2012-03-13 20:28 ` James Murray
2012-03-13 20:56 ` Fred Cooke
2012-04-02 12:37 ` James Murray
2012-04-23 17:05 ` James Murray
[not found] ` <1337003987.27195.60.camel@jsm2>
2012-05-15 12:59 ` nick clifton
2012-05-15 18:38 ` Fred Cooke
2012-05-15 20:26 ` James Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330300482.15684.10.camel@jsm2 \
--to=jsm@jsm-net.demon.co.uk \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).