From: Tristan Gingold <gingold@adacore.com>
To: Hans-Peter Nilsson <hp@bitrange.com>
Cc: Steve Ellcey <sje@cup.hp.com>, binutils@sourceware.org
Subject: Re: [patch/gas]: simplify frag_grow
Date: Wed, 27 Jul 2011 07:39:00 -0000 [thread overview]
Message-ID: <134B1A59-19A0-4748-8EA5-EC14F2DDF4B3@adacore.com> (raw)
In-Reply-To: <alpine.BSF.2.00.1107262056480.70579@dair.pair.com>
On Jul 27, 2011, at 3:06 AM, Hans-Peter Nilsson wrote:
> On Tue, 26 Jul 2011, Steve Ellcey wrote:
>>
>> Tristan Gingold wrote:
>>
>>> The 'while' loop can only be executed once. The function 'frag_new' can
>>> either succeed or abort via exit (it uses xmalloc to allocate memory as
>>> defined by as.h).
>>
>> This doesn't seem to be true. I used the previous version of frag_grow
>> and put some print statements in frag_grow and I see multiple passes
>> through the while loop in some calls to frag_grow. If I change the
>> while to an if (so that it can only be done once) and make no other
>> changes, my test case fails.
>
> I'm guessing that bug is also the cause for these regressions
> for cris-elf exposed by Tristan's changes:
Ok, I will investigate that.
Tristan.
next prev parent reply other threads:[~2011-07-27 6:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 17:49 Tristan Gingold
2011-07-06 4:45 ` Alan Modra
2011-07-06 7:25 ` Tristan Gingold
2011-07-11 12:05 ` Alan Modra
2011-07-25 14:49 ` Tristan Gingold
2011-07-26 20:14 ` Steve Ellcey
2011-07-26 21:14 ` Steve Ellcey
2011-07-27 6:56 ` Hans-Peter Nilsson
2011-07-27 7:39 ` Tristan Gingold [this message]
2011-07-27 10:06 ` Tristan Gingold
2011-07-27 16:08 ` [patch v2/gas]: " Tristan Gingold
2011-07-29 6:01 ` Alan Modra
2011-08-01 8:06 ` Tristan Gingold
2011-07-27 11:42 ` [patch/gas]: " Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=134B1A59-19A0-4748-8EA5-EC14F2DDF4B3@adacore.com \
--to=gingold@adacore.com \
--cc=binutils@sourceware.org \
--cc=hp@bitrange.com \
--cc=sje@cup.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).