From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2082.outbound.protection.outlook.com [40.107.22.82]) by sourceware.org (Postfix) with ESMTPS id F285438515DD for ; Wed, 12 Oct 2022 07:13:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F285438515DD Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ObdgN/43hOkQ7fqo71Txx2Zlgk8APwxi00gWyrlIYgfJ0XhjAQ8b6SBNQugXiIx5brIq26uoPl6DIRUjk9K0in0y9+RvPW5T7Xnhy6p8vekyKHJx5WXb3ikf+ZvV/2SmxtUszL5e6Sn0l6JIcgvmsQajwKxLuRVQ0klju8D6ignzsQz46ML93yLp6FexmIf8WDJ+M/O/ll8GSU28Sd9yT8zb7VHFL99IbrX1te6cL8E+YHZKS9d9SLKIQzv5JCo+BkqPg5Nep1jb21NJh9Lrmhp8S42KTYCv6d/GFGsWoeaJDCSJuZqL8MyhD1f4fQO5YDuKirVhtZndQFEgvVmTnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=syT0mLYD62430wSEdcHtdiiZ58M5jvRnlt9v0aCMSI0=; b=BALF24QZ5tTC1Msh96KUn2EsLYwxVKNgUoe6spuuHTiJ1Bb52WCwOWDXNjOk4N74BVV2525THCzloaHVPWtj/094D3+x0QaowfnsmqiHN98HxfsvStzXZPnLaobiMjiTwdYaJzF15h6zX+IRAHDKz1nWVTuwf+wofP1Y6RSms1BtGAWsUhfFxqRWj3l5/opbRbd3aemMngkHdgw1VlOc0VvTApex60J51bVzCj6nm5mlwhil81iSYJDPHtUtLd7mWDgia0xoilfbrZSKnWfegbmeQk+vt+k5M+B0HocLiRX7bT2Qm5OI53wUHwPG/8VTB37B1yLV4wb3Tye4OJFC2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=syT0mLYD62430wSEdcHtdiiZ58M5jvRnlt9v0aCMSI0=; b=BcRt6ubL+xGvyOIvqUxBnrMI5dZ4uLAdRA1a7fC4Oa8ZdGShZAq47sGQCGprUescxEZeKsizc6IrCBHM6BdwApQqyT6GsM+MisbUI2hxhR5YVPRSdGY+W/Rju91Rv0f9u2wW5n+ilDZfk2hBKQDhXUqqioya7+qB9UT+Zpj2cfRcNvvAzVHihSbbaUeMWSD/g48cq0KhfmYGyMV/XISnuAELhqKeHSXXPqUMp0/q/lE4iEsOYB6DQzw7ooshllWdYZypatOHjudaW8nqqdy7MJbaZCv49TIUS5Apb1quHvyeOtvyux2w01zLE8pZ5zScgAlwpoFYPzA0YmtpFNmieQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7132.eurprd04.prod.outlook.com (2603:10a6:10:12e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.34; Wed, 12 Oct 2022 07:13:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Wed, 12 Oct 2022 07:13:11 +0000 Message-ID: <13901424-7999-aeac-c1a2-52baedaa593c@suse.com> Date: Wed, 12 Oct 2022 09:13:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v3 7/7] x86: move bad-use-of-TLS-reloc check Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <20e2773a-2e47-869b-1900-709f8ad4cd6b@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5P194CA0012.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB7132:EE_ X-MS-Office365-Filtering-Correlation-Id: d4774c3f-e2c3-480d-6bb3-08daac21388c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6F9B4/a6cGFI2eSoKkvvquiALZhMXDzSGkNl8m3uZCmHhbPSWZl0HeZ72zJLWPvEbNkWETvDN1vgbx9fPms7w1vTmHtiYzEvQSr09GsriRZOgv4HPJDx9YzwjDYzHhKhqQXI1vJZfWVD0EPS7co8BsVHAZmWNE8TcnFRXsIPd6pcEG8s+VYHPCRMI592CmSDJlF0bFddSGN7qiZw8v76/ZDN6r2LCV+GFqYjrySB/ao1lsbprB0ksoHmNw4Zhb9Ea2Z95+YZQiD7tRzvunBYk1uPIrWZ7tAFmk9GDZ1Lr5LuvRwNX16yTlb+3oFRh5cJlS/RtsXOfK4ao7Y+iN/BOOaLxbpv41O6pXLttdPX9FjPQVNY3CySlID0HLXmlyUuoQMXbR2nr+iguqvpTmdO1pLhFH2naUXGjHRw/i2nk/YVIfxh/VFQwKAfv552bfjzcehan5dDfyvOT3gWsf43cNGUo88JbHRzAqDe0EmTjZq+STBNXMzqOX5pKrpbCGMwD8sm9Gr4KGvF3A++dVSvQF5Qug2mDL/IdQGl3omI+sXgSBLNWc+x0ohAvYov3Bm+q/xI26PPw8I6pkyRsWN2WSG4Bw7TK+MfWoWY3N9RtQbW+yPI6F7IkG1Bebi0sGzg9w18MTqrQY/HWAdLBkW9FfKdhzUhCUxFKbwHjw7GiKwOkfgo4NGs3WBzNcbn5ELZjNEVjr5wSWh0TdezI2ROgBzuQxL3+eKDAl1cL7dGEkCXaekp9O/iAwDIC8IJ6himuWibkJTZ9mSw4K9Z3rALB1vVkNnxDmpPmTtqH4GcaGk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(39860400002)(136003)(366004)(451199015)(8676002)(2616005)(53546011)(66946007)(66476007)(4326008)(478600001)(6512007)(38100700002)(36756003)(316002)(66556008)(31696002)(6916009)(86362001)(6486002)(186003)(5660300002)(4744005)(41300700001)(6506007)(8936002)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dytGZVBWNDJ2dzJzRkI3NUw4NkJESGF1azVsU2ZWeUtoQXlYYURHY2JqTmYy?= =?utf-8?B?UXYyY1ZYT0o0Qk9aN2IrSHJ3WUU5NXQ2MmJKcGxHamRnQzlzcFpGa3RUS2Ni?= =?utf-8?B?YUlTVVExNWFqZWNOdHRJWFI4d3JEeGxoek80MnVGaXJWNUk4K2hFOE5TN0Fo?= =?utf-8?B?ZXRtVjcxL1ZtS3BnbHNNU3BLZkxPMHIxUnZkK1J1KzFKdnpXUFIwUWhZQTJM?= =?utf-8?B?blNLek1LUUhtdThyM1c1TVhjVFhIdTRtdFg3OFl0T0xZUWlBVnRFRU9kaklX?= =?utf-8?B?MVRFMnpvcnFmeGRPSURxMlNBZExpSHE4YkNCQXozWEEyMHQ3c0QwVm5qZlRu?= =?utf-8?B?SFg1Y3FEa0dvMEdlVHBwUG9oOGhETGRQVE1UYnB2MEN2Z0NFWXdUaENNcGZx?= =?utf-8?B?Q3BFd3E4U1ZPb05TdGxUblhZcVNwWWZUZWxIL1NhQmVEZklmMlFWU1VQdW5Z?= =?utf-8?B?aEl5Q2FlRlBnemx4UWVpWnQ3NXE5dVRxN0tqdFRQMGRXSUZNVk80RHMwS1J0?= =?utf-8?B?OGdPczlGZDk5dmNYUlowamdXMUtyeVlnTjg3dzJNU1BrbVdCRytCQWhlbjJB?= =?utf-8?B?VXJTVEt2Qjc2TmVpejFYRWtxeTdTQjhYMlpBdE82L0YyWGduY2x2VE1pMmNE?= =?utf-8?B?NXhRQ2o1VFJsUGQ5eStoUHM2THlZeTBTQVpWUW5HclZOYmVZRVZzc1doV2Z2?= =?utf-8?B?ekkzVWx2OHpqdGJ1UXh6SG9ybkVMdVZIYm44MXdYMnRadXVLYTErbDNaVUlp?= =?utf-8?B?OW93ZXA1TTM3bHNZdmpYbkFNWTBMVE5wV0Fmd3lSbWwvU3ZJSzExdG9MUG5X?= =?utf-8?B?clpZaHNnckFUd1lDR3JDbWlHRk1vcmRBSUs4RFY4Qi9ZcW90S0lXN1ExK1JF?= =?utf-8?B?eFRaTStDUjdVeDk3VkVhZzQ4dnRkakh1cUVrTmtWTnFwNlZaQllXazJNL3F4?= =?utf-8?B?SFlEOVc1ajRNRjk1TlJldkpYYzhZQkVVWDNGQTB2bGk3VlpGOWNvVERTOWNN?= =?utf-8?B?bk1MUUFKN2FwUER2eDRMQXVvWnJvSlRCbDQ1bGU3emJMbWpQR1ZtNEFlcTAr?= =?utf-8?B?cGlGWWIvSC9NQjNhcVVsUVZiSDU2bUx2UTVHNWliWlViaHZYSnFRUlRoWFEx?= =?utf-8?B?WVNzZkN6bVo1NFNUdnQraERRTHFrUUxiVHRRR0pNbFdsK09FcWFveVkvNkJ1?= =?utf-8?B?RHdRdGYrS1ZzQ3RQNkU1RUdlYkxBcThFcGxVNzBtTndzendmbWEzUWJjU2xu?= =?utf-8?B?OHZPV3NGcnZsc1R3RkdRRlNlcGR0eU5vWVd6STZOSGZPMk9zVDZxOW16bHl6?= =?utf-8?B?cVRFZXN4TlZSaUNFSWFucjgzUklNSS9MNVpNTndOajZzSHlXNDBzOUtyTitv?= =?utf-8?B?cVpWcFY2b3JDcXNLYmh3LzBFek9qNHRrb3lWbm9RZVBlTHZMRVlReVhkSWd5?= =?utf-8?B?ODRHK0xOenJnRGxpM0RPdjZ4ODVISlFnZG5FUDIwam1TbUFxU0RWQXJxQVYr?= =?utf-8?B?amJKYjV5eHBacWk2Q0hGbW9KdWdnRnowSUhDYitkekc0dk95Vjk1ajlVN0Vo?= =?utf-8?B?dVZZMmVqcmVvSDNhWXQyNXNDcEUvUjFZZjFPa3AyOUoxRzluT3pJajFFZS96?= =?utf-8?B?ZW9WcS8wdE9QQ3Qvem9rOXdpODBCQldGeHRGYmpROGErUEtWRHVkTm1XVFox?= =?utf-8?B?N01UZ3NIY1A4SmtTcUlFak1ONHZLK0h2TjlrNWpzSlgrK3JxQXUvWUxoZ28x?= =?utf-8?B?WjZvaERIT0NZMkV2d3NHT3NmZjRFL0N5VXRsWnE5d3JnanlhZmhxTU9rcUZi?= =?utf-8?B?RUlKT3psdHNYNjg4Mk9kcHFqQ1Rka0srdWtkd1lWYUtjSUFuU3VpZmdnVjhF?= =?utf-8?B?UEYxemFRb0h6aUdmSi9CWHFQZTNqeWtBRGtCUFZVNU5CNVRzNjRPbGp1L25Y?= =?utf-8?B?ZGRYemM0cTlHWTlRK3BzdlFWMnNtakxBTXhOTVgxaWpnbFRES2o1N3hhVUxH?= =?utf-8?B?SWZZdUZVandNT1BYNzlWb1dBaFVoZ2tjZWxzN3pwT2NURWphU0dwb3I0bU5Q?= =?utf-8?B?b3JnYXVSMkdIanUyMXdQMGV6aXZGeWFxR2NvWWRlYk1NUE1WcUdLTDFrUy84?= =?utf-8?B?VzVEMFM4UHBMYkpoaElrY3NFeTk0eHlkUTR5Mk5sOXFsZVZKQVhBQkNVUXZo?= =?utf-8?Q?T9A26izlk5vphcD2fdudu6cNkDmBj9y+ppTIn/GTEiwl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4774c3f-e2c3-480d-6bb3-08daac21388c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2022 07:13:11.0690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DMYXiAODpftOrHHV7kwxOEKl/ZVhVt0XK6xSctVsqZCwj/zLmtC1mkidQ7h5AhmW8TMAKSx4mYS02E8N90jkYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7132 X-Spam-Status: No, score=-3030.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11.10.2022 19:57, H.J. Lu wrote: > On Wed, Oct 5, 2022 at 12:25 AM Jan Beulich wrote: >> >> Having it in match_template() is unhelpful. Neither does looking for the >> next template to possibly match make any sense in that case, nor is the >> resulting diagnostic making clear what the problem is. >> >> While moving the check, also generalize it to include all SIMD and VEX- >> encoded insns. This way an existing conditional can be re-used in >> md_assemble(). Note though that this still leaves a lof of insns which >> are also wrong to use with these relocations. > > These TLS instruction sequences are generated by compilers. > The check is only meant to check for invalid master registers. The sequence involving a mask register was generated (aiui) by mistake. Why would it not be possible to see another similar mistake involve an XMM register, with a legacy, VEX-, or EVEX-encoded insn? Anyway - thanks for approving the patch. Jan