From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 4D1D7383F221 for ; Wed, 7 Dec 2022 13:01:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D1D7383F221 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8B96F21CA0; Wed, 7 Dec 2022 13:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1670418118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TIsufD8g7uhfbvnXWiEBtZ8H0xb5c6ancbJroJ2ndw0=; b=Gq0B+mRfQj9FE/aLEkoEDRAASNRsskdZAK8GJOOFn6mh/csOj6vZRSmgOm7eCtDzj1rAlg nmRJMzVpv3VWZ2MpKBTE9rJThIo2ByTL4j+dggeVvuG7bgOog5xOjq4iYcIoaWD1eh7315 hpWAzdIPtI1PHAjK85R0DsZUI4WCRGA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1670418118; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TIsufD8g7uhfbvnXWiEBtZ8H0xb5c6ancbJroJ2ndw0=; b=C44qQYGYAT4nZ09slO46b2OvFCrtnxzv46OnVSjFb+512V5gg+3QoMV8uW/vdztj5FfKLc nK+SetHt2NbC13BA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 624EF134CD; Wed, 7 Dec 2022 13:01:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id 7OQlFsaOkGNEYAAAGKfGzw (envelope-from ); Wed, 07 Dec 2022 13:01:58 +0000 Message-ID: <13c7b67e-c49c-c135-cfed-d82915594181@suse.cz> Date: Wed, 7 Dec 2022 14:01:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH V3] testsuite: support mold linker Content-Language: en-US To: Fangrui Song , Jan Beulich Cc: binutils@sourceware.org References: <2eb01f7a-2430-b0bc-9c58-d15d06ca6bf9@suse.cz> <20221207003638.46fnrj32r56i2ynl@gmail.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <20221207003638.46fnrj32r56i2ynl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/7/22 01:36, Fangrui Song wrote: > On 2022-12-05, Jan Beulich via Binutils wrote: >> On 05.12.2022 15:41, Martin Liška wrote: >>> Mold linker demotes symbols like main to be local and the patch >>> adjusts expected output from nm. >>> >>> Moreover, simplify the regex patterns. >> >> Okay. >> >> Jan >> > > Not okai to me.  mold seems to wrongly make `main` STB_LOCAL while it > has default visibility which should stay STB_GLOBAL. Sure, I noticed that but thought it's a correct optimization a linker can do. Anyway, I'm ready to revert this once the mold issue is somehow resolved. Thanks for heads up, Martin