From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id DEF1E3858D28 for ; Thu, 28 Dec 2023 06:33:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DEF1E3858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DEF1E3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703745233; cv=none; b=wgbfloe1mIgsVxtUwYdSd/WyIE1XobElTkw5Qbo6nVrE9p6OfXUJbO8cvHPxOBsyBhFeZaDArxysuXx+NCfSEiOWuXsKHRb2/di0OpMmli9MztUXqwtGSbEAth0aijMjzROIGLU2CGN0v4W14WoZv4QBFDARlrH8Qulc5hp4MF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703745233; c=relaxed/simple; bh=iN7QbQ8XFLVSE3cpt0k1l0iRbqVVrPteaEdz72UQbyY=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=vRZ6V7YmfTcEZ7FmIq1bOr/9A2GC/SvY5wBwfWVdL5zVMhythMflOzR5QXJxDm64EexGzxIraZjy4oCGGK5bwHD+yK0W6tPsWRqn2wDRXjbHTXhfwOjLnwq5b1YqkoYQliTvr8JnftebDiQC9CEp9mPneAuFf873fskpz5RHWks= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.171]) by gateway (Coremail) with SMTP id _____8BxLuvJFo1l_wgAAA--.220S3; Thu, 28 Dec 2023 14:33:48 +0800 (CST) Received: from [10.20.4.171] (unknown [10.20.4.171]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Bxib3HFo1ldMcNAA--.19141S3; Thu, 28 Dec 2023 14:33:44 +0800 (CST) Subject: Re: [PATCH v1] LoongArch: Add support for and To: Alan Modra Cc: binutils@sourceware.org References: <20231210094132.3236040-1-mengqinggang@loongson.cn> From: mengqinggang Message-ID: <13dc5821-2059-3858-c61c-fae6ce7279ca@loongson.cn> Date: Thu, 28 Dec 2023 14:33:43 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8Bxib3HFo1ldMcNAA--.19141S3 X-CM-SenderInfo: 5phqw15lqjwttqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoW7CFyDuw4UGw1fGr4rtFyfXwc_yoW8Wr4DpF WUuFs3KF95Jrs7AF1kur1DWFs5Grs3WrW2vFyft3WUCrnxXr17XFySkws7uF1DJ3sa9r42 qr4vqr95ZFyUXFcCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUv0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr0_Gr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzV AYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jrv_JF1lIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1CPfJUU UUU== X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_SHORT,MIME_CHARSET_FARAWAY,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: To consistent with other architectures, we don't need to support quoted registers. The second feature is a good idea and it can be merged. Thank you very much. ÔÚ 2023/12/25 ÉÏÎç8:01, Alan Modra дµÀ: > This adds some extra features > 1) All args have double-quotes removed, not just the last one, and > 2) Commas now are allowed as part of a double-quote string. > > I am not sure this change in behaviour is wanted (ie. it's not an > obvious bug fix to me), so I'll leave it to the loongarch maintainers > to decide whether this patch goes in. > > * loongarch-coder.c (loongarch_split_args_by_comma): Support > quotes in more than just last arg. Commas inside quotes are > not arg delimiters. > > diff --git a/opcodes/loongarch-coder.c b/opcodes/loongarch-coder.c > index b68352769ca..1bff3b005f9 100644 > --- a/opcodes/loongarch-coder.c > +++ b/opcodes/loongarch-coder.c > @@ -18,6 +18,7 @@ > along with this program; see the file COPYING3. If not, > see . */ > #include "sysdep.h" > +#include > #include "opcode/loongarch.h" > > int > @@ -256,12 +257,20 @@ loongarch_split_args_by_comma (char *args, const char *arg_strs[]) > > if (*args) > { > + bool inquote = false; > arg_strs[num++] = args; > for (; *args; args++) > - if (*args == ',') > + if (*args == '"') > + inquote = !inquote; > + else if (*args == ',' && !inquote) > { > if (MAX_ARG_NUM_PLUS_2 - 1 == num) > goto out; > + if (*(args - 1) == '"' && *arg_strs[num] == '"') > + { > + *(args - 1) = '\0'; > + arg_strs[num] += 1; > + } > *args = '\0'; > arg_strs[num++] = args + 1; > } >