From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2A8D23857801; Fri, 25 Sep 2020 14:25:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2A8D23857801 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id AD59D1E509; Fri, 25 Sep 2020 10:25:39 -0400 (EDT) Subject: Re: [PATCH] Import mklog.py from gcc repo To: Simon Marchi , gdb-patches@sourceware.org, binutils@sourceware.org References: <20200917202922.4179305-1-simon.marchi@polymtl.ca> From: Simon Marchi Message-ID: <13ec4b5c-5489-ecbb-0300-e606d1c8ad92@simark.ca> Date: Fri, 25 Sep 2020 10:25:39 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2020 14:25:41 -0000 On 2020-09-21 11:31 a.m., Simon Marchi via Gdb-patches wrote: > On 2020-09-17 4:29 p.m., Simon Marchi wrote: >> I've been using the mklog utility from the gcc repo for a while to >> generate skeleton of ChangeLog entries. It recently got a rewrite as a >> Python script. Unfortunately, to find the repository root, and >> eventually to find in which ChangeLog file each entry goes, the new >> script assumes it is located in the same git repository that it >> generates ChangeLog entries for. >> >> This means that if you make a change in the gcc source tree and run >> mklog.py from that same source tree, it works. But if you make changes >> in your ~/src/binutils-gdb tree and run ~/src/gcc/contrib/mklog.py, it >> won't work. >> >> IIRC, the old script required that you ran it with the project's root >> directory as the CWD. >> >> The simplest way to fix this is to import the script in binutils-gdb and >> use it from there. It's also nice because we can use it without having >> a clone of the gcc repo. >> >> I also thought of adding a "--root" switch to the script to override the >> project's base directory. However: >> >> 1) It is more work. >> 2) If the script still lives in the gcc repo, it's less convenient than >> having it in binutils-gdb. >> >> This patch imports contrib/mklog.py from the gcc repo, revision >> c560591408440f441b8b327f5b41f9328d20b67b. >> >> contrib/ChangeLog: >> >> * mklog.py: New file, imported from gcc. >> >> Note: the ChangeLog entry above was generated using >> `git show | ./mklog.py`! > > I'll push this at the end of the week if nobody disagrees. > > Simon > I pushed this patch. Simon