From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24495 invoked by alias); 14 May 2014 21:19:31 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 24477 invoked by uid 89); 14 May 2014 21:19:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f182.google.com Received: from mail-wi0-f182.google.com (HELO mail-wi0-f182.google.com) (209.85.212.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 14 May 2014 21:19:28 +0000 Received: by mail-wi0-f182.google.com with SMTP id r20so3148014wiv.3 for ; Wed, 14 May 2014 14:19:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bG1VVhyVbVXepbeAt5Y+YowEFZ3/ngZLsOsv/R659DQ=; b=ITjWFDMNfk/AZ/EIbYYyqbZutd9pSmRp/GKGW5aF4uTx/7KV1d3asACBGlmedyJDlv gMqyjjoqEKERTBnqodWT70p8Cd0rY/WVX8XhicUCinhwc9Z5Ek8rTVAP3zLVXeK4e/zk 9Mu42pf/jAp4TC1jGWpDf0LtFLQF7X8rEEIi+bAiwo2ADUoal9S+qatEoWSvBoQvwo1c PKg0SXZ/AmC9UiP1hZH68LB5N0BElS2qyRzttvPb2ftGmOu3yQfgddZDFaEOr7qp727R JJ4mGn0HV1ihhi8OWoes2nwu5AuQyYdAqVQNFQUgIvPdEFvECCAROnhAsZvSFgavqcUQ p+kQ== X-Gm-Message-State: ALoCoQn3XNPCIeRU/02Mk83AOWPrB7vZta4Y1VhhVSGH9pKfXelRBz0n7J7GKAsF7CaNksveJBWi X-Received: by 10.180.212.48 with SMTP id nh16mr27745805wic.49.1400102365812; Wed, 14 May 2014 14:19:25 -0700 (PDT) Received: from localhost.localdomain ([182.185.131.35]) by mx.google.com with ESMTPSA id kp5sm4013896wjb.30.2014.05.14.14.19.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 14 May 2014 14:19:24 -0700 (PDT) From: Omair Javaid To: binutils@sourceware.org Cc: patches@linaro.org Subject: [PATCH] aarch64 linux core dump support Date: Wed, 14 May 2014 21:19:00 -0000 Message-Id: <1400102354-9296-1-git-send-email-omair.javaid@linaro.org> X-SW-Source: 2014-05/txt/msg00126.txt.bz2 2014-05-15 Omair Javaid bfd/ * elfxx-aarch64.c (stdarg.h): Include. (_bfd_aarch64_elf_grok_prstatus): Updated. (_bfd_aarch64_elf_grok_psinfo): New function. (_bfd_aarch64_elf_write_core_note): New function. * elfxx-aarch64.h (elf_backend_grok_psinfo): Define. (elf_backend_write_core_note): Define. --- bfd/elfxx-aarch64.c | 102 +++++++++++++++++++++++++++++++++++++++++++--------- bfd/elfxx-aarch64.h | 12 +++++-- 2 files changed, 96 insertions(+), 18 deletions(-) diff --git a/bfd/elfxx-aarch64.c b/bfd/elfxx-aarch64.c index 7db6295..23e2ef1 100644 --- a/bfd/elfxx-aarch64.c +++ b/bfd/elfxx-aarch64.c @@ -20,6 +20,7 @@ #include "sysdep.h" #include "elfxx-aarch64.h" +#include #define MASK(n) ((1u << (n)) - 1) @@ -498,25 +499,94 @@ _bfd_aarch64_elf_grok_prstatus (bfd *abfd, Elf_Internal_Note *note) switch (note->descsz) { default: - return FALSE; + return FALSE; + + /* sizeof(struct elf_prstatus) on Linux/aarch64. */ + case 392: + elf_tdata (abfd)->core->signal = bfd_get_16 (abfd, note->descdata + 12); + elf_tdata (abfd)->core->lwpid = bfd_get_32 (abfd, note->descdata + 32); + offset = 112; + size = 272; + break; + } - case 392: /* sizeof(struct elf_prstatus) on Linux/arm64. */ - /* pr_cursig */ - elf_tdata (abfd)->core->signal - = bfd_get_16 (abfd, note->descdata + 12); + /* Make a ".reg/999" section. */ + return _bfd_elfcore_make_pseudosection (abfd, ".reg", + size, note->descpos + offset); +} - /* pr_pid */ - elf_tdata (abfd)->core->lwpid - = bfd_get_32 (abfd, note->descdata + 32); +bfd_boolean +_bfd_aarch64_elf_grok_psinfo (bfd *abfd, Elf_Internal_Note *note) +{ + switch (note->descsz) + { + default: + return FALSE; + + case 136: /* sizeof(struct elf_prpsinfo) on Linux/x86_64 */ + elf_tdata (abfd)->core->pid = bfd_get_32 (abfd, note->descdata + 24); + elf_tdata (abfd)->core->program = + _bfd_elfcore_strndup (abfd, note->descdata + 40, 16); + elf_tdata (abfd)->core->command = + _bfd_elfcore_strndup (abfd, note->descdata + 56, 80); + } - /* pr_reg */ - offset = 112; - size = 272; + /* Note that for some reason, a spurious space is tacked + onto the end of the args in some (at least one anyway) + implementations, so strip it off if it exists. */ - break; - } + { + char *command = elf_tdata (abfd)->core->command; + int n = strlen (command); - /* Make a ".reg/999" section. */ - return _bfd_elfcore_make_pseudosection (abfd, ".reg", - size, note->descpos + offset); + if (0 < n && command[n - 1] == ' ') + command[n - 1] = '\0'; + } + + return TRUE; +} + +char * +_bfd_aarch64_elf_write_core_note (bfd *abfd, char *buf, int *bufsiz, int note_type, + ...) +{ + switch (note_type) + { + default: + return NULL; + + case NT_PRPSINFO: + { + char data[136]; + va_list ap; + va_start (ap, note_type); + memset (data, 0, sizeof (data)); + strncpy (data + 40, va_arg (ap, const char *), 16); + strncpy (data + 56, va_arg (ap, const char *), 80); + va_end (ap); + return elfcore_write_note (abfd, buf, bufsiz, + "CORE", note_type, data, sizeof (data)); + } + + case NT_PRSTATUS: + { + char data[392]; + va_list ap; + long pid; + int cursig; + const void *greg; + + va_start (ap, note_type); + memset (data, 0, sizeof (data)); + pid = va_arg (ap, long); + bfd_put_32 (abfd, pid, data + 32); + cursig = va_arg (ap, int); + bfd_put_16 (abfd, cursig, data + 12); + greg = va_arg (ap, const void *); + memcpy (data + 112, greg, 272); + va_end (ap); + return elfcore_write_note (abfd, buf, bufsiz, + "CORE", note_type, data, sizeof (data)); + } + } } diff --git a/bfd/elfxx-aarch64.h b/bfd/elfxx-aarch64.h index 5ca3b7f..1d61d96 100644 --- a/bfd/elfxx-aarch64.h +++ b/bfd/elfxx-aarch64.h @@ -42,6 +42,14 @@ _bfd_aarch64_elf_add_symbol_hook (bfd *, struct bfd_link_info *, extern bfd_boolean _bfd_aarch64_elf_grok_prstatus (bfd *, Elf_Internal_Note *); +extern bfd_boolean +_bfd_aarch64_elf_grok_psinfo (bfd *, Elf_Internal_Note *); + +extern char * +_bfd_aarch64_elf_write_core_note (bfd *abfd, char *buf, int *bufsiz, + int note_type, ...); -#define elf_backend_add_symbol_hook _bfd_aarch64_elf_add_symbol_hook -#define elf_backend_grok_prstatus _bfd_aarch64_elf_grok_prstatus +#define elf_backend_add_symbol_hook _bfd_aarch64_elf_add_symbol_hook +#define elf_backend_grok_prstatus _bfd_aarch64_elf_grok_prstatus +#define elf_backend_grok_psinfo _bfd_aarch64_elf_grok_psinfo +#define elf_backend_write_core_note _bfd_aarch64_elf_write_core_note -- 1.9.1