public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: binutils@sourceware.org
Subject: [PATCH 1/2] aarch64: Fix dwarf2 regnum for Dn
Date: Thu, 07 Aug 2014 00:09:00 -0000	[thread overview]
Message-ID: <1407370273-3580-1-git-send-email-rth@twiddle.net> (raw)

My argument for not accepting [bhsv]N is that unwind info
is specifically 64-bits, i.e. the dN values.

Not handled here is "esr" == 33.

---
 gas/config/tc-aarch64.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index 0a65b9d..09ea8a6 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -5962,16 +5962,20 @@ tc_aarch64_regname_to_dw2regnum (char *regname)
 
   switch (reg->type)
     {
-    case REG_TYPE_SP_32:
     case REG_TYPE_SP_64:
-    case REG_TYPE_R_32:
     case REG_TYPE_R_64:
+      return reg->number;
+
+    case REG_TYPE_FP_D:
+      return reg->number + 64;
+
+    case REG_TYPE_SP_32:
+    case REG_TYPE_R_32:
     case REG_TYPE_FP_B:
     case REG_TYPE_FP_H:
     case REG_TYPE_FP_S:
-    case REG_TYPE_FP_D:
     case REG_TYPE_FP_Q:
-      return reg->number;
+      /* Do not allow register names of width other than 64-bit.  */
     default:
       break;
     }
-- 
1.8.3.1

             reply	other threads:[~2014-08-07  0:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-07  0:09 Richard Henderson [this message]
2014-08-07  0:09 ` [PATCH 2/2] aarch64: Decode dwarf2 register numbers Richard Henderson
2014-09-03 10:25   ` Marcus Shawcroft
2014-09-03 10:27     ` Marcus Shawcroft
2014-09-02 17:38 ` [PATCH 1/2] aarch64: Fix dwarf2 regnum for Dn Marcus Shawcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407370273-3580-1-git-send-email-rth@twiddle.net \
    --to=rth@twiddle.net \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).