public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: David Malcolm <dmalcolm@redhat.com>
To: gcc-patches@gcc.gnu.org, binutils@sourceware.org
Cc: David Malcolm <dmalcolm@redhat.com>
Subject: [PATCH 06/16] gcc: driver: add timevars for as, collect2, ld
Date: Mon, 01 Jun 2015 20:55:00 -0000	[thread overview]
Message-ID: <1433192664-50156-7-git-send-email-dmalcolm@redhat.com> (raw)
In-Reply-To: <1433192664-50156-1-git-send-email-dmalcolm@redhat.com>

gcc/ChangeLog:
	* gcc.c (execute): Identify certain commands, and account their
	time to specific timevars.
	* gcc.h (driver::get_timer): New accessor.
	* timevar.def (TV_DRIVER_EXECUTE_AS): New.
	(TV_DRIVER_EXECUTE_COLLECT2): New.
	(TV_DRIVER_EXECUTE_LD): New.
	(TV_DRIVER_EXECUTE_OTHER): New.
---
 gcc/gcc.c       | 19 +++++++++++++++++++
 gcc/gcc.h       |  2 ++
 gcc/timevar.def |  4 ++++
 3 files changed, 25 insertions(+)

diff --git a/gcc/gcc.c b/gcc/gcc.c
index 46e750d..93f41ec 100644
--- a/gcc/gcc.c
+++ b/gcc/gcc.c
@@ -2845,6 +2845,25 @@ execute (void)
     if (strcmp (arg, "|") == 0)
       n_commands++;
 
+  /* If we're timing things, and we have a single command in the
+     pipeline, bill the time to that command.  Given that we
+     need a timevar for each one, we only split out a few important
+     commands. */
+  timevar_id_t tv_id;
+  tv_id = TV_DRIVER_EXECUTE_OTHER;
+  gcc_assert (g_driver);
+  timer *driver_timer = g_driver->get_timer ();
+  if (driver_timer && n_commands == 1)
+    {
+      if (0 == strcmp (argbuf[0], "as"))
+	tv_id = TV_DRIVER_EXECUTE_AS;
+      else if (0 == strcmp (argbuf[0], "collect2"))
+	tv_id = TV_DRIVER_EXECUTE_COLLECT2;
+      else if (0 == strcmp (argbuf[0], "ld"))
+	tv_id = TV_DRIVER_EXECUTE_LD;
+    }
+  auto_timevar tv (driver_timer, tv_id);
+
   /* Get storage for each command.  */
   commands = (struct command *) alloca (n_commands * sizeof (struct command));
 
diff --git a/gcc/gcc.h b/gcc/gcc.h
index cfff8ef..15bc11d 100644
--- a/gcc/gcc.h
+++ b/gcc/gcc.h
@@ -37,6 +37,8 @@ class driver
   int main (int argc, char **argv);
   void finalize ();
 
+  timer *get_timer () const { return m_timer; }
+
  private:
   void set_progname (const char *argv0) const;
   void expand_at_files (int *argc, char ***argv) const;
diff --git a/gcc/timevar.def b/gcc/timevar.def
index d04a729..ce9236d 100644
--- a/gcc/timevar.def
+++ b/gcc/timevar.def
@@ -291,6 +291,10 @@ DEFTIMEVAR (TV_ASSEMBLE	     , "assemble JIT code")
 DEFTIMEVAR (TV_DRIVER_SETUP          , "driver: setup")
 DEFTIMEVAR (TV_DRIVER_SPEC	     , "driver: do spec on infiles")
 DEFTIMEVAR (TV_DRIVER_LINK	     , "driver: run linker")
+DEFTIMEVAR (TV_DRIVER_EXECUTE_AS     , "driver: executing \"as\"")
+DEFTIMEVAR (TV_DRIVER_EXECUTE_COLLECT2, "driver: executing \"collect2\"")
+DEFTIMEVAR (TV_DRIVER_EXECUTE_LD     , "driver: executing \"ld\"")
+DEFTIMEVAR (TV_DRIVER_EXECUTE_OTHER  , "driver: executing subprocess")
 DEFTIMEVAR (TV_LINK		     , "link JIT code")
 DEFTIMEVAR (TV_LOAD		     , "load JIT result")
 DEFTIMEVAR (TV_JIT_ACQUIRING_MUTEX   , "acquiring JIT mutex")
-- 
1.8.5.3

  parent reply	other threads:[~2015-06-01 20:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01 20:50 [PATCH 00/16] RFC: Embedding as and ld inside gcc driver and into libgccjit David Malcolm
2015-06-01 20:50 ` [PATCH 05/16] gcc: driver: add g_driver singleton David Malcolm
2015-06-01 20:50 ` [PATCH 01/16] gcc: Generalization of timevar API; add gcc_jit_timer interface David Malcolm
2015-06-01 20:51 ` [PATCH 10/16] binutils: Introduce "gas_main", and state-purging with "gas" subdir David Malcolm
2015-06-01 20:51 ` [PATCH 15/16] gcc: Use libgas and libld within the driver David Malcolm
2015-06-02  8:32   ` Richard Biener
2015-06-02 11:07     ` Trevor Saunders
2015-06-02 12:12       ` Richard Biener
2015-06-01 20:55 ` [PATCH 07/16] binutils: bfd: Implement bfd_uninit David Malcolm
2015-06-01 20:55 ` [PATCH 08/16] libiberty.h: Provide a CLEAR_VAR macro David Malcolm
2015-06-01 21:47   ` DJ Delorie
2015-06-02  1:23     ` David Malcolm
2015-06-02  1:39       ` DJ Delorie
2015-06-01 20:55 ` David Malcolm [this message]
2015-06-01 20:55 ` [PATCH 09/16] libiberty.h: Provide CTIMER_PUSH/POP David Malcolm
2015-06-01 21:30   ` DJ Delorie
2015-06-02 21:52     ` Jeff Law
2015-06-01 20:56 ` [PATCH 04/16] gcc: Don't keep reinitializing RTL David Malcolm
2015-06-01 20:58 ` [PATCH 02/16] gcc: Embed the driver in-process within libgccjit David Malcolm
2015-06-03  6:00   ` Bert Wesarg
2015-06-01 20:58 ` [PATCH 11/16] binutils: gas/Makefile.am: Add libgas.la David Malcolm
2015-06-01 20:58 ` [PATCH 14/16] gcc: Add CTIMER_PUSH/POP to gcc's copy of libiberty David Malcolm
2015-06-01 21:33   ` DJ Delorie
2015-06-01 20:59 ` [PATCH 03/16] gcc: Use timevars within driver David Malcolm
2015-06-01 20:59 ` [PATCH 12/16] binutils: Introduce "ld_main" and state-purging within "ld" subdir David Malcolm
2015-06-01 21:00 ` [PATCH 16/16] gcc: Hack up the arguments to the linker David Malcolm
2015-06-01 21:00 ` [PATCH 13/16] ld/Makefile.am: Introduce a libld.la David Malcolm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433192664-50156-7-git-send-email-dmalcolm@redhat.com \
    --to=dmalcolm@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).