public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: tbsaunde+binutils@tbsaunde.org
To: binutils@sourceware.org
Cc: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
Subject: [PATCH 0/7] enable -Wwrite-strings for gas
Date: Wed, 30 Mar 2016 01:08:00 -0000	[thread overview]
Message-ID: <1459300381-19313-1-git-send-email-tbsaunde+binutils@tbsaunde.org> (raw)

From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>

Hi,

At this point I think we've fixed basically all the -Wwrite-strings issues in
gas that can be fixed reasonably without just adding casts.  So this series
adds a handful of casts in several patches that try to explain why those casts
are necessary, and then enables the warning for gas.

I built one target per tc-*.c and regtested x86_64-linux-gnu, ok?

Trev


Trevor Saunders (7):
  cast literal to char * when assigning to input_line_ptr
  work around get_symbol_name () in sparc and ia64
  cast to char * when assigning to optarg
  cast the arg to md_assemble () to char *
  tc-i960.c: add some casts when assigning literals to args[i]
  make xtensa_section_rename () take const char *
  enable -Wwrite-strings for gas

 bfd/configure          | 20 ++++++++++++++++++--
 bfd/warning.m4         |  4 ++++
 binutils/configure     | 20 ++++++++++++++++++--
 gas/Makefile.am        |  2 +-
 gas/Makefile.in        |  2 +-
 gas/as.c               |  2 +-
 gas/config/tc-i960.c   | 26 +++++++++++++-------------
 gas/config/tc-ia64.c   |  6 ++++--
 gas/config/tc-m32c.c   |  8 ++++----
 gas/config/tc-m32r.c   |  2 +-
 gas/config/tc-msp430.c |  2 +-
 gas/config/tc-nds32.c  | 10 +++++-----
 gas/config/tc-sparc.c  |  2 +-
 gas/config/tc-xtensa.c |  6 +++---
 gas/config/tc-xtensa.h |  2 +-
 gas/config/tc-z80.c    |  2 +-
 gas/configure          | 20 ++++++++++++++++++--
 gas/stabs.c            |  2 +-
 gold/configure         | 16 ++++++++++++++++
 gprof/configure        | 20 ++++++++++++++++++--
 ld/configure           | 20 ++++++++++++++++++--
 opcodes/configure      | 20 ++++++++++++++++++--
 22 files changed, 166 insertions(+), 48 deletions(-)

-- 
2.1.4

             reply	other threads:[~2016-03-30  1:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-30  1:08 tbsaunde+binutils [this message]
2016-03-30  1:08 ` [PATCH 1/7] cast literal to char * when assigning to input_line_ptr tbsaunde+binutils
2016-03-30  1:08 ` [PATCH 3/7] cast to char * when assigning to optarg tbsaunde+binutils
2016-03-30  1:08 ` [PATCH 2/7] work around get_symbol_name () in sparc and ia64 tbsaunde+binutils
2016-03-30  1:08 ` [PATCH 5/7] tc-i960.c: add some casts when assigning literals to args[i] tbsaunde+binutils
2016-03-30  1:08 ` [PATCH 7/7] enable -Wwrite-strings for gas tbsaunde+binutils
2016-04-01 11:22   ` Jiong Wang
2016-04-01 12:17     ` Trevor Saunders
2016-04-01 12:40     ` Alan Modra
2016-04-01 13:10       ` Trevor Saunders
2016-03-30  1:14 ` [PATCH 6/7] make xtensa_section_rename () take const char * tbsaunde+binutils
2016-03-30  1:14 ` [PATCH 4/7] cast the arg to md_assemble () to " tbsaunde+binutils
2016-03-31 10:34 ` [PATCH 0/7] enable -Wwrite-strings for gas Alan Modra
2016-05-01 16:44 ` Andrew Pinski
2016-05-02 18:25   ` Trevor Saunders
2016-05-02 19:38     ` Andrew Pinski
2016-05-03  8:12       ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459300381-19313-1-git-send-email-tbsaunde+binutils@tbsaunde.org \
    --to=tbsaunde+binutils@tbsaunde.org \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).