From: tbsaunde+binutils@tbsaunde.org
To: binutils@sourceware.org
Cc: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
Subject: [PATCH 6/7] make xtensa_section_rename () take const char *
Date: Wed, 30 Mar 2016 01:14:00 -0000 [thread overview]
Message-ID: <1459300381-19313-7-git-send-email-tbsaunde+binutils@tbsaunde.org> (raw)
In-Reply-To: <1459300381-19313-1-git-send-email-tbsaunde+binutils@tbsaunde.org>
From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
Xtensa uses it in several macros passing it a literal string, so its convenient
for the argument type to be const char *. However some of the code in
symbols.c seems to assume tc_canonicalize_symbol_name () will return a non
const pointer, and some other target's implementations even modify the
argument, so it seems best to return a char * which means casting away const on
the argument when we return it instead of another string.
gas/ChangeLog:
2016-03-29 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
* config/tc-xtensa.c (struct rename_section_struct): Make old_name
const.
(xtensa_section_rename): Make argument type const char *.
* config/tc-xtensa.h (xtensa_section_rename): Adjust.
---
gas/config/tc-xtensa.c | 6 +++---
gas/config/tc-xtensa.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gas/config/tc-xtensa.c b/gas/config/tc-xtensa.c
index 3025d29..a74f689 100644
--- a/gas/config/tc-xtensa.c
+++ b/gas/config/tc-xtensa.c
@@ -13117,7 +13117,7 @@ copy_expr (expressionS *dst, const expressionS *src)
struct rename_section_struct
{
- char *old_name;
+ const char *old_name;
char *new_name;
struct rename_section_struct *next;
};
@@ -13190,7 +13190,7 @@ build_section_rename (const char *arg)
char *
-xtensa_section_rename (char *name)
+xtensa_section_rename (const char *name)
{
struct rename_section_struct *r = section_rename;
@@ -13200,5 +13200,5 @@ xtensa_section_rename (char *name)
return r->new_name;
}
- return name;
+ return (char *) name;
}
diff --git a/gas/config/tc-xtensa.h b/gas/config/tc-xtensa.h
index c8a5029..2c7b16e 100644
--- a/gas/config/tc-xtensa.h
+++ b/gas/config/tc-xtensa.h
@@ -333,7 +333,7 @@ extern void xtensa_elf_section_change_hook (void);
extern int xtensa_unrecognized_line (int);
extern bfd_boolean xtensa_check_inside_bundle (void);
extern void xtensa_handle_align (fragS *);
-extern char *xtensa_section_rename (char *);
+extern char *xtensa_section_rename (const char *);
#define TARGET_FORMAT xtensa_target_format ()
#define TARGET_ARCH bfd_arch_xtensa
--
2.1.4
next prev parent reply other threads:[~2016-03-30 1:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 1:08 [PATCH 0/7] enable -Wwrite-strings for gas tbsaunde+binutils
2016-03-30 1:08 ` [PATCH 5/7] tc-i960.c: add some casts when assigning literals to args[i] tbsaunde+binutils
2016-03-30 1:08 ` [PATCH 7/7] enable -Wwrite-strings for gas tbsaunde+binutils
2016-04-01 11:22 ` Jiong Wang
2016-04-01 12:17 ` Trevor Saunders
2016-04-01 12:40 ` Alan Modra
2016-04-01 13:10 ` Trevor Saunders
2016-03-30 1:08 ` [PATCH 1/7] cast literal to char * when assigning to input_line_ptr tbsaunde+binutils
2016-03-30 1:08 ` [PATCH 3/7] cast to char * when assigning to optarg tbsaunde+binutils
2016-03-30 1:08 ` [PATCH 2/7] work around get_symbol_name () in sparc and ia64 tbsaunde+binutils
2016-03-30 1:14 ` [PATCH 4/7] cast the arg to md_assemble () to char * tbsaunde+binutils
2016-03-30 1:14 ` tbsaunde+binutils [this message]
2016-03-31 10:34 ` [PATCH 0/7] enable -Wwrite-strings for gas Alan Modra
2016-05-01 16:44 ` Andrew Pinski
2016-05-02 18:25 ` Trevor Saunders
2016-05-02 19:38 ` Andrew Pinski
2016-05-03 8:12 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459300381-19313-7-git-send-email-tbsaunde+binutils@tbsaunde.org \
--to=tbsaunde+binutils@tbsaunde.org \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).