From: Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>
To: <binutils@sourceware.org>
Cc: <Claudiu.Zissulescu@synopsys.com>, <Francois.Bedard@synopsys.com>
Subject: [PATCH] Don't allow pc-rel relocations for J* instructions.
Date: Mon, 04 Apr 2016 15:24:00 -0000 [thread overview]
Message-ID: <1459783367-1084-1-git-send-email-claziss@synopsys.com> (raw)
This is a small patch that throws an error if one tries to use a branch instruction with a pc-relative relocation.
Ok to apply?
Claudiu
gas/
2016-03-31 Claudiu Zissulescu <claziss@synopsys.com>
* config/tc-arc.c (assemble_insn): Prohibit pc-rel relocations for
JUMP instructions type.
* testsuite/gas/arc/relocs-errors.d: New file.
* testsuite/gas/arc/relocs-errors.err: Likewise.
* testsuite/gas/arc/relocs-errors.s: Likewise.
Signed-off-by: Claudiu Zissulescu <claziss@synopsys.com>
---
gas/config/tc-arc.c | 6 +++++-
gas/testsuite/gas/arc/relocs-errors.d | 1 +
gas/testsuite/gas/arc/relocs-errors.err | 7 +++++++
gas/testsuite/gas/arc/relocs-errors.s | 7 +++++++
4 files changed, 20 insertions(+), 1 deletion(-)
create mode 100644 gas/testsuite/gas/arc/relocs-errors.d
create mode 100644 gas/testsuite/gas/arc/relocs-errors.err
create mode 100644 gas/testsuite/gas/arc/relocs-errors.s
diff --git a/gas/config/tc-arc.c b/gas/config/tc-arc.c
index 4f9c336..40643ad 100644
--- a/gas/config/tc-arc.c
+++ b/gas/config/tc-arc.c
@@ -3363,6 +3363,10 @@ assemble_insn (const struct arc_opcode *opcode,
switch (t->X_md)
{
case O_plt:
+ if (opcode->class == JUMP)
+ as_bad_where (frag_now->fr_file, frag_now->fr_line,
+ _("Unable to use @plt relocatio for insn %s"),
+ opcode->name);
needGOTSymbol = TRUE;
reloc = find_reloc ("plt", opcode->name,
pflags, nflg,
@@ -3376,7 +3380,7 @@ assemble_insn (const struct arc_opcode *opcode,
break;
case O_pcl:
reloc = ARC_RELOC_TABLE (t->X_md)->reloc;
- if (ARC_SHORT (opcode->mask))
+ if (ARC_SHORT (opcode->mask) || opcode->class == JUMP)
as_bad_where (frag_now->fr_file, frag_now->fr_line,
_("Unable to use @pcl relocation for insn %s"),
opcode->name);
diff --git a/gas/testsuite/gas/arc/relocs-errors.d b/gas/testsuite/gas/arc/relocs-errors.d
new file mode 100644
index 0000000..29373a7
--- /dev/null
+++ b/gas/testsuite/gas/arc/relocs-errors.d
@@ -0,0 +1 @@
+#error-output: relocs-errors.err
diff --git a/gas/testsuite/gas/arc/relocs-errors.err b/gas/testsuite/gas/arc/relocs-errors.err
new file mode 100644
index 0000000..3bafa15
--- /dev/null
+++ b/gas/testsuite/gas/arc/relocs-errors.err
@@ -0,0 +1,7 @@
+[^:]*: Assembler messages:
+[^:]*:1: Error: Unable to use @plt relocatio for insn j
+[^:]*:2: Error: Unable to use @plt relocatio for insn jl
+[^:]*:3: Error: Unable to use @plt relocatio for insn j
+[^:]*:5: Error: Unable to use @pcl relocation for insn j
+[^:]*:6: Error: Unable to use @pcl relocation for insn jl
+[^:]*:7: Error: Unable to use @pcl relocation for insn j
diff --git a/gas/testsuite/gas/arc/relocs-errors.s b/gas/testsuite/gas/arc/relocs-errors.s
new file mode 100644
index 0000000..8e963a0
--- /dev/null
+++ b/gas/testsuite/gas/arc/relocs-errors.s
@@ -0,0 +1,7 @@
+ j sym@plt
+ jl sym@plt
+ jeq sym@plt
+
+ j sym@pcl
+ jl sym@pcl
+ jeq sym@pcl
--
1.9.1
next reply other threads:[~2016-04-04 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 15:24 Claudiu Zissulescu [this message]
2016-04-05 14:09 ` Nick Clifton
2016-04-05 14:27 ` Claudiu Zissulescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459783367-1084-1-git-send-email-claziss@synopsys.com \
--to=claudiu.zissulescu@synopsys.com \
--cc=Francois.Bedard@synopsys.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).