* [PATCH] gas/arc: Unify tests run on big/little endian arc assembler
@ 2016-04-07 22:00 Andrew Burgess
2016-04-08 7:29 ` Claudiu Zissulescu
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Burgess @ 2016-04-07 22:00 UTC (permalink / raw)
To: binutils; +Cc: Claudiu.Zissulescu, Cupertino.Miranda, Andrew Burgess
We were running a slightly different set of assembler tests on big and
little endian arc targets. This commit unifies the set of tests run.
gas/ChangeLog:
* testsuite/gas/arc/add_s-err.s: Update target pattern.
* testsuite/gas/arc/warn.s: Likewise.
* testsuite/gas/elf/elf.exp: Run test for arc.
---
gas/ChangeLog | 6 ++++++
gas/testsuite/gas/arc/add_s-err.s | 2 +-
gas/testsuite/gas/arc/warn.s | 2 +-
gas/testsuite/gas/elf/elf.exp | 1 -
4 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/gas/testsuite/gas/arc/add_s-err.s b/gas/testsuite/gas/arc/add_s-err.s
index 3312061..298f4ef 100644
--- a/gas/testsuite/gas/arc/add_s-err.s
+++ b/gas/testsuite/gas/arc/add_s-err.s
@@ -1,7 +1,7 @@
;; Test ARC EM Code denisty ADD_S extensions. They are only valid for
;; ARCv2 architecture.
;;
-; { dg-do assemble { target arc-*-* } }
+; { dg-do assemble { target arc*-*-* } }
; { dg-options "--mcpu=arc700" }
;; The following insns are accepted by ARCv2 only
add_s r4,r4,-1 ; { dg-error "Error: inappropriate arguments for opcode 'add_s'" }
diff --git a/gas/testsuite/gas/arc/warn.s b/gas/testsuite/gas/arc/warn.s
index e89aa99..deec175 100644
--- a/gas/testsuite/gas/arc/warn.s
+++ b/gas/testsuite/gas/arc/warn.s
@@ -1,6 +1,6 @@
; Test ARC specific assembler warnings
;
-; { dg-do assemble { target arc-*-* } }
+; { dg-do assemble { target arc*-*-* } }
b.d foo
mov r0,256
diff --git a/gas/testsuite/gas/elf/elf.exp b/gas/testsuite/gas/elf/elf.exp
index e4ca205..b5f8fec 100644
--- a/gas/testsuite/gas/elf/elf.exp
+++ b/gas/testsuite/gas/elf/elf.exp
@@ -90,7 +90,6 @@ if { [is_elf_format] } then {
# optimization because it interfers with link-time relaxation of
# function prologues.
if {![istarget "mn10300-*-*"]
- && ![istarget "arc-*-*"]
&& ![istarget "xtensa*-*-*"]
&& ![istarget "msp430*-*-*"]
&& ![istarget "nds32*-*-*"]
--
2.5.1
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] gas/arc: Unify tests run on big/little endian arc assembler
2016-04-07 22:00 [PATCH] gas/arc: Unify tests run on big/little endian arc assembler Andrew Burgess
@ 2016-04-08 7:29 ` Claudiu Zissulescu
2016-04-14 12:45 ` [PUSHED] " Andrew Burgess
0 siblings, 1 reply; 3+ messages in thread
From: Claudiu Zissulescu @ 2016-04-08 7:29 UTC (permalink / raw)
To: Andrew Burgess, binutils; +Cc: Cupertino.Miranda
Hi Andrew,
It looks nice. Thank you for your contribution,
Claudiu
> -----Original Message-----
> From: Andrew Burgess [mailto:andrew.burgess@embecosm.com]
> Sent: Friday, April 08, 2016 12:00 AM
> To: binutils@sourceware.org
> Cc: Claudiu.Zissulescu@synopsys.com; Cupertino.Miranda@synopsys.com;
> Andrew Burgess
> Subject: [PATCH] gas/arc: Unify tests run on big/little endian arc assembler
>
> We were running a slightly different set of assembler tests on big and
> little endian arc targets. This commit unifies the set of tests run.
>
> gas/ChangeLog:
>
> * testsuite/gas/arc/add_s-err.s: Update target pattern.
> * testsuite/gas/arc/warn.s: Likewise.
> * testsuite/gas/elf/elf.exp: Run test for arc.
> ---
> gas/ChangeLog | 6 ++++++
> gas/testsuite/gas/arc/add_s-err.s | 2 +-
> gas/testsuite/gas/arc/warn.s | 2 +-
> gas/testsuite/gas/elf/elf.exp | 1 -
> 4 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/gas/testsuite/gas/arc/add_s-err.s b/gas/testsuite/gas/arc/add_s-
> err.s
> index 3312061..298f4ef 100644
> --- a/gas/testsuite/gas/arc/add_s-err.s
> +++ b/gas/testsuite/gas/arc/add_s-err.s
> @@ -1,7 +1,7 @@
> ;; Test ARC EM Code denisty ADD_S extensions. They are only valid for
> ;; ARCv2 architecture.
> ;;
> -; { dg-do assemble { target arc-*-* } }
> +; { dg-do assemble { target arc*-*-* } }
> ; { dg-options "--mcpu=arc700" }
> ;; The following insns are accepted by ARCv2 only
> add_s r4,r4,-1 ; { dg-error "Error: inappropriate arguments for
> opcode 'add_s'" }
> diff --git a/gas/testsuite/gas/arc/warn.s b/gas/testsuite/gas/arc/warn.s
> index e89aa99..deec175 100644
> --- a/gas/testsuite/gas/arc/warn.s
> +++ b/gas/testsuite/gas/arc/warn.s
> @@ -1,6 +1,6 @@
> ; Test ARC specific assembler warnings
> ;
> -; { dg-do assemble { target arc-*-* } }
> +; { dg-do assemble { target arc*-*-* } }
>
> b.d foo
> mov r0,256
> diff --git a/gas/testsuite/gas/elf/elf.exp b/gas/testsuite/gas/elf/elf.exp
> index e4ca205..b5f8fec 100644
> --- a/gas/testsuite/gas/elf/elf.exp
> +++ b/gas/testsuite/gas/elf/elf.exp
> @@ -90,7 +90,6 @@ if { [is_elf_format] } then {
> # optimization because it interfers with link-time relaxation of
> # function prologues.
> if {![istarget "mn10300-*-*"]
> - && ![istarget "arc-*-*"]
> && ![istarget "xtensa*-*-*"]
> && ![istarget "msp430*-*-*"]
> && ![istarget "nds32*-*-*"]
> --
> 2.5.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PUSHED] Re: [PATCH] gas/arc: Unify tests run on big/little endian arc assembler
2016-04-08 7:29 ` Claudiu Zissulescu
@ 2016-04-14 12:45 ` Andrew Burgess
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Burgess @ 2016-04-14 12:45 UTC (permalink / raw)
To: Claudiu Zissulescu; +Cc: binutils, Cupertino.Miranda
I've pushed this as an obvious fix.
Thanks,
Andrew
* Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com> [2016-04-08 07:29:05 +0000]:
> Hi Andrew,
>
> It looks nice. Thank you for your contribution,
> Claudiu
>
> > -----Original Message-----
> > From: Andrew Burgess [mailto:andrew.burgess@embecosm.com]
> > Sent: Friday, April 08, 2016 12:00 AM
> > To: binutils@sourceware.org
> > Cc: Claudiu.Zissulescu@synopsys.com; Cupertino.Miranda@synopsys.com;
> > Andrew Burgess
> > Subject: [PATCH] gas/arc: Unify tests run on big/little endian arc assembler
> >
> > We were running a slightly different set of assembler tests on big and
> > little endian arc targets. This commit unifies the set of tests run.
> >
> > gas/ChangeLog:
> >
> > * testsuite/gas/arc/add_s-err.s: Update target pattern.
> > * testsuite/gas/arc/warn.s: Likewise.
> > * testsuite/gas/elf/elf.exp: Run test for arc.
> > ---
> > gas/ChangeLog | 6 ++++++
> > gas/testsuite/gas/arc/add_s-err.s | 2 +-
> > gas/testsuite/gas/arc/warn.s | 2 +-
> > gas/testsuite/gas/elf/elf.exp | 1 -
> > 4 files changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/gas/testsuite/gas/arc/add_s-err.s b/gas/testsuite/gas/arc/add_s-
> > err.s
> > index 3312061..298f4ef 100644
> > --- a/gas/testsuite/gas/arc/add_s-err.s
> > +++ b/gas/testsuite/gas/arc/add_s-err.s
> > @@ -1,7 +1,7 @@
> > ;; Test ARC EM Code denisty ADD_S extensions. They are only valid for
> > ;; ARCv2 architecture.
> > ;;
> > -; { dg-do assemble { target arc-*-* } }
> > +; { dg-do assemble { target arc*-*-* } }
> > ; { dg-options "--mcpu=arc700" }
> > ;; The following insns are accepted by ARCv2 only
> > add_s r4,r4,-1 ; { dg-error "Error: inappropriate arguments for
> > opcode 'add_s'" }
> > diff --git a/gas/testsuite/gas/arc/warn.s b/gas/testsuite/gas/arc/warn.s
> > index e89aa99..deec175 100644
> > --- a/gas/testsuite/gas/arc/warn.s
> > +++ b/gas/testsuite/gas/arc/warn.s
> > @@ -1,6 +1,6 @@
> > ; Test ARC specific assembler warnings
> > ;
> > -; { dg-do assemble { target arc-*-* } }
> > +; { dg-do assemble { target arc*-*-* } }
> >
> > b.d foo
> > mov r0,256
> > diff --git a/gas/testsuite/gas/elf/elf.exp b/gas/testsuite/gas/elf/elf.exp
> > index e4ca205..b5f8fec 100644
> > --- a/gas/testsuite/gas/elf/elf.exp
> > +++ b/gas/testsuite/gas/elf/elf.exp
> > @@ -90,7 +90,6 @@ if { [is_elf_format] } then {
> > # optimization because it interfers with link-time relaxation of
> > # function prologues.
> > if {![istarget "mn10300-*-*"]
> > - && ![istarget "arc-*-*"]
> > && ![istarget "xtensa*-*-*"]
> > && ![istarget "msp430*-*-*"]
> > && ![istarget "nds32*-*-*"]
> > --
> > 2.5.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-14 12:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-07 22:00 [PATCH] gas/arc: Unify tests run on big/little endian arc assembler Andrew Burgess
2016-04-08 7:29 ` Claudiu Zissulescu
2016-04-14 12:45 ` [PUSHED] " Andrew Burgess
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).