public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "H.J. Lu" <hjl.tools@gmail.com>
To: binutils@sourceware.org
Subject: [PATCH] Check R_386_NONE/R_X86_64_NONE in eh6.d
Date: Wed, 20 Apr 2016 18:15:00 -0000	[thread overview]
Message-ID: <1461176144-2346-1-git-send-email-hjl.tools@gmail.com> (raw)

There is no need for run-time relocation when converting pointers
in .eh_frame section to DW_EH_PE_pcrel encoding.  R_386_NONE and
R_X86_64_NONE are expected since the space for run-time relocation
has been allocated.  This is an optimization.

	PR ld/19972
	* testsuite/ld-elf/eh6.d: Pass -rW to readelf and check for
	R_386_NONE or R_X86_64_NONE.
---
 ld/ChangeLog              | 6 ++++++
 ld/testsuite/ld-elf/eh6.d | 5 ++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 74be8d4..1963c17 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,5 +1,11 @@
 2016-04-20  H.J. Lu  <hongjiu.lu@intel.com>
 
+	PR ld/19972
+	* testsuite/ld-elf/eh6.d: Pass -rW to readelf and check for
+	R_386_NONE or R_X86_64_NONE.
+
+2016-04-20  H.J. Lu  <hongjiu.lu@intel.com>
+
 	* testsuite/ld-x86-64/pic1.d: New file.
 	* testsuite/ld-x86-64/pic1.s: Likewise.
 	* testsuite/ld-x86-64/x86-64.exp: Run pic1.
diff --git a/ld/testsuite/ld-elf/eh6.d b/ld/testsuite/ld-elf/eh6.d
index 7812af2..475b2a7 100644
--- a/ld/testsuite/ld-elf/eh6.d
+++ b/ld/testsuite/ld-elf/eh6.d
@@ -1,8 +1,11 @@
 #source: eh6.s
 #ld: --gc-sections -shared
-#readelf: -wf
+#readelf: -wf -rW
 #target: x86_64-*-linux-gnu* i?86-*-linux-gnu i?86-*-gnu*
 
+#...
+[0-9a-f]+ +[0-9a-f]+ +R_.*_NONE *0?
+#...
 Contents of the .eh_frame section:
 
 0+0000 0+001[4c] 0+0000 CIE
-- 
2.5.5

                 reply	other threads:[~2016-04-20 18:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461176144-2346-1-git-send-email-hjl.tools@gmail.com \
    --to=hjl.tools@gmail.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).