[PATCH] tilegx: move TILEGX_NUM_PIPELINE_ENCODINGS to tilegx_pipeline

[PATCH] tilegx: move TILEGX_NUM_PIPELINE_ENCODINGS to tilegx_pipeline

[tbsaunde+binutils]

From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>

Hi,

Its closely related to what the encodings are, more than a set of random
constants, so it seems to make sense to put it here.

built and regtested tilegx-elf, ok?

Trev

include/ChangeLog:

2016-06-05  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>

	* opcode/tilegx.h: Move TILEGX_NUM_PIPELINE_ENCODINGS into
	tilegx_pipeline.
---
 include/opcode/tilegx.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/opcode/tilegx.h b/include/opcode/tilegx.h
index 3490583..5985410 100644
--- a/include/opcode/tilegx.h
+++ b/include/opcode/tilegx.h
@@ -1130,6 +1130,7 @@ typedef enum
   TILEGX_PIPELINE_Y0,
   TILEGX_PIPELINE_Y1,
   TILEGX_PIPELINE_Y2,
+  TILEGX_NUM_PIPELINE_ENCODINGS = 5,
 } tilegx_pipeline;
 
 #define tilegx_is_x_pipeline(p) ((int)(p) <= (int)TILEGX_PIPELINE_X1)
@@ -1150,9 +1151,6 @@ enum
   /* Maximum number of instructions in a bundle (2 for X, 3 for Y). */
   TILEGX_MAX_INSTRUCTIONS_PER_BUNDLE = 3,
 
-  /* How many different pipeline encodings are there? X0, X1, Y0, Y1, Y2. */
-  TILEGX_NUM_PIPELINE_ENCODINGS = 5,
-
   /* Log base 2 of TILEGX_BUNDLE_SIZE_IN_BYTES. */
   TILEGX_LOG2_BUNDLE_SIZE_IN_BYTES = 3,
 
-- 
2.7.4

Re: [PATCH] tilegx: move TILEGX_NUM_PIPELINE_ENCODINGS to tilegx_pipeline

[Trevor Saunders]

Hi,

ping

Thanks!

Trev

On Sun, Jun 05, 2016 at 04:39:14PM -0400, tbsaunde+binutils@tbsaunde.org wrote:
> From: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
> 
> Hi,
> 
> Its closely related to what the encodings are, more than a set of random
> constants, so it seems to make sense to put it here.
> 
> built and regtested tilegx-elf, ok?
> 
> Trev
> 
> include/ChangeLog:
> 
> 2016-06-05  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
> 
> 	* opcode/tilegx.h: Move TILEGX_NUM_PIPELINE_ENCODINGS into
> 	tilegx_pipeline.
> ---
>  include/opcode/tilegx.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/opcode/tilegx.h b/include/opcode/tilegx.h
> index 3490583..5985410 100644
> --- a/include/opcode/tilegx.h
> +++ b/include/opcode/tilegx.h
> @@ -1130,6 +1130,7 @@ typedef enum
>    TILEGX_PIPELINE_Y0,
>    TILEGX_PIPELINE_Y1,
>    TILEGX_PIPELINE_Y2,
> +  TILEGX_NUM_PIPELINE_ENCODINGS = 5,
>  } tilegx_pipeline;
>  
>  #define tilegx_is_x_pipeline(p) ((int)(p) <= (int)TILEGX_PIPELINE_X1)
> @@ -1150,9 +1151,6 @@ enum
>    /* Maximum number of instructions in a bundle (2 for X, 3 for Y). */
>    TILEGX_MAX_INSTRUCTIONS_PER_BUNDLE = 3,
>  
> -  /* How many different pipeline encodings are there? X0, X1, Y0, Y1, Y2. */
> -  TILEGX_NUM_PIPELINE_ENCODINGS = 5,
> -
>    /* Log base 2 of TILEGX_BUNDLE_SIZE_IN_BYTES. */
>    TILEGX_LOG2_BUNDLE_SIZE_IN_BYTES = 3,
>  
> -- 
> 2.7.4
> 

Re: [PATCH] tilegx: move TILEGX_NUM_PIPELINE_ENCODINGS to tilegx_pipeline

[Nick Clifton]

Hi Trev,

> ping

oops - sorry.


>> include/ChangeLog:
>>
>> 2016-06-05  Trevor Saunders  <tbsaunde+binutils@tbsaunde.org>
>>
>> 	* opcode/tilegx.h: Move TILEGX_NUM_PIPELINE_ENCODINGS into
>> 	tilegx_pipeline.
 
Approved - please apply.

Cheers
  Nick