From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id C4A0C3858D20 for ; Mon, 22 May 2023 05:43:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C4A0C3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1684734212; bh=njKnEFF+SWTw/UW38Yx2m5HVQ84dI5Gnfd1zY61r1b4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=c8sa/bZAE5mHPS07LKQELagexPG8wwELHZ/7kS6wO33xHok0BBD3Ah298cA2c12WG Am8i4cOf0GXnF+XmNWI6Izx36Az++aG4Iv0pv9tUj0VkblJPthLF26A2REJUHhPRcw ZRqPxW/0E3Wy9KMAxMyrxEbaXAUaraqP+kw+3KnM= Received: from [IPv6:240e:358:114f:a600:dc73:854d:832e:5] (unknown [IPv6:240e:358:114f:a600:dc73:854d:832e:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384)) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 67A8A65A04; Mon, 22 May 2023 01:43:25 -0400 (EDT) Message-ID: <14eb3f714191e0abacd0b65bf6b67ddc4dc24a93.camel@xry111.site> Subject: Re: [PATCH v4 3/6] LoongArch: opcodes: Add support for linker relaxation. From: Xi Ruoyao To: mengqinggang , binutils@sourceware.org Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn, liuzhensong@loongson.cn, i.swmail@xen0n.name, maskray@google.com Date: Mon, 22 May 2023 13:43:16 +0800 In-Reply-To: <20230522013441.3074776-4-mengqinggang@loongson.cn> References: <20230522013441.3074776-1-mengqinggang@loongson.cn> <20230522013441.3074776-4-mengqinggang@loongson.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.1 MIME-Version: 1.0 X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,LIKELY_SPAM_FROM,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 2023-05-22 at 09:34 +0800, mengqinggang wrote: > Set gas default to enable relax. >=20 > opcodes/ChangeLog: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0* loongarch-opc.c (struct= loongarch_ASEs_option): New member > relax > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0with the default value 1. > --- > =C2=A0opcodes/loongarch-opc.c | 5 ++++- > =C2=A01 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/opcodes/loongarch-opc.c b/opcodes/loongarch-opc.c > index 39d724a3398..573b691c1fd 100644 > --- a/opcodes/loongarch-opc.c > +++ b/opcodes/loongarch-opc.c > @@ -22,7 +22,10 @@ > =C2=A0#include "opcode/loongarch.h" > =C2=A0#include "libiberty.h" > =C2=A0 > -struct loongarch_ASEs_option LARCH_opts; > +struct loongarch_ASEs_option LARCH_opts =3D > +{ If I remember correctly there shouldn't be a newline for this '{'. i.e. "LARCH_opts =3D {". > +=C2=A0 .relax =3D 1 > +}; > > =C2=A0size_t > =C2=A0loongarch_insn_length (insn_t insn ATTRIBUTE_UNUSED) --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University