From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2075.outbound.protection.outlook.com [40.107.7.75]) by sourceware.org (Postfix) with ESMTPS id 111C538393A9 for ; Mon, 20 Nov 2023 08:19:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 111C538393A9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 111C538393A9 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.75 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700468360; cv=pass; b=v+s6XXzmfb40XqU/vP2Jz68vS/3+EsIYUUrdzuCKkgVhHXVRbuVZKn+tDmWqeGcykJ+hFmOC2zYhzeJj2dAt24yTZKo0c3mivHebRP4Ux/phtqrg4YwIX+2J6xiT4syPlhjrLdzgpmtQWbEkBJEsj9jSSHkQZ1VpkcZ84AWMnMc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700468360; c=relaxed/simple; bh=L0cSdNkfxnnketoGaEoLoeQplEJfvEn1EoXBC/ADKvU=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=OjBUUyulCyiRl0HpxGWvVbpP/v0zn9KU4dVrhhpYoJ2bN19O2W4lUR5/0tW/KQrBzkuBSSnfRoMnohb/ZJvPL2V7gbmfL8WD1Mxike7lOHUH4v4Cb57+C3s/ZXEcmxuRHxXmreaCywVhwMzUHeDXbNkFRp0DdU7QUhqy9uLj15A= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R8rF+kYw4vRUpkV8OULe0PLEnMSWj1O6Of8Wh1/NKxapzpPl4EDkEtukvPtbjIE3R/Egi4Q35PvqiUsojMUiubFhcbmYbUAkudPuo9wINZGU9zwQJo9M/lVRHvQgF3Rm3b8t1/c47sKUnL8z3fMrYDY6Qwden+MFS2mOZ101XE13c4Zrrmff/bvwQDXzSsFXW6Xqdpcf7jnvAVFEBbLO063fhIEavrdvXOlaepUG7VnaHPWVuB77n/nTFPYRN5ITAw0cOQX/ACSm7Uyprf9l4YFDHjkqkRwGNJGpM0P+w1HdXs/CWQLC8oSMru3hlV+7+Avsgb7ulH/kpCdqtFttNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ZKbk6BPFWC6K/ZSYKO0jaTYZL1GjlBg/l0wSPOX8U4=; b=I1gEhLI21sHjOChDJS5IAnFWr7M+awdgDIYJxYzYhtntJiqmlScgca2SX1sEWcqcUSV4cuWoXP6e6fdB64W/X4XOXIDQadS7AsUW+hJ4ULGCpma78lKUTGhcpBPEF78qXL8rbtLnoumZX5oNIEZNB4TRgDYF1OyChgfibNdBICz52MGsxjEUMiHUn8GD6ECXASI8bd+qm1oxRFec5x6R8/bQYzzfkUh0heDeuWsalfCny24lbZ+JvB5q+EwckNfCixKZUDgN4Ojb+cTO2BVmqx2iNsxN8sLtGIhiDJ3kWKbCyiR4kXHCN7pVqDGxKi4SPn5WagytpgBLewr4anZcCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9ZKbk6BPFWC6K/ZSYKO0jaTYZL1GjlBg/l0wSPOX8U4=; b=M+iv1qztztAHmDK0ooJoXlvrivKMFvdXBYne86L7Uw2/r4GultFKONxNTeokAWISytnMvVOZo8d/1hB9VXWdKmLvw3Sxxv7VLJzUc5rzFvsPnFuurz9xw+4m33GHbN9/nhYVCWUgu6kO+nW5sQxcMniXTaCawelVM2/Iyd0Cc9hba7TIyi8qlm0cE+DehggJZVdgujH49cuMFbwUpjZvRWnzpqGEbrwxfAkgMicxfGGYioFmcJQd5djXr46CUWfFN//SePvGULNRZEAUVHWV+if/ko4ODB1b/4opX25vlBMVBy9RwNGMCEvX0yperjATPGujusvtDFTRubgK4EGDpg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by PAWPR04MB9888.eurprd04.prod.outlook.com (2603:10a6:102:385::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.11; Mon, 20 Nov 2023 08:19:14 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7025.015; Mon, 20 Nov 2023 08:19:14 +0000 Message-ID: <14f7f847-8e71-4951-b644-999ca5e940b3@suse.com> Date: Mon, 20 Nov 2023 09:19:15 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] Support APX NDD Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "ccoutant@gmail.com" , "binutils@sourceware.org" , "Kong, Lingling" References: <20231102112911.2372810-1-lili.cui@intel.com> <20231102112911.2372810-6-lili.cui@intel.com> <5760c85c-6917-b3c6-0bab-3b5639fcfae5@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0088.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|PAWPR04MB9888:EE_ X-MS-Office365-Filtering-Correlation-Id: fcd9337f-1b01-40a7-f6ae-08dbe9a161e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mOnCAsXV7bnAZmOleZTl53ObAwqgkCdgyyMumKrCYqtvgPUDlUhjQ0S1Tl5sMTPS1EgDmdGuu+lQnC6Q13w2U2/LNKNGBgYRXs00+hssvGjTs7siI6c31KhglBEKxP5AKuJOoeJLZ9ZwPGRUwvCYiJUXQhY9bhXoChJ82e6YSAf/GmsolEySQmLdRX9WsHCWP9n2g4BRF1IRJyxc0k35YJdGtlErIJv3RHy9dpjcekas0v7Og49W1dJK11Ly7kGMVh4ED/1p2wig9oS/h3LxdAyKfkE+PuWjGxxZQJ0FxA3XhwB3A/ZVAnJpAxcZzXjDlvdeNTI1y85FFtedb/X+iR2hAmsAXhJ6i6mOpm0vZrDie4IoQtKv4jNudSCw7VBPzVGPRgY22l0ExRuFp8Cd5cItTWMzKGlvXPJijFCJwGCIGvp9F4+ZViAwvNR8LjxYh1bOCq/Y72lJeaPi9cTrBA0Lbthw9K/h5yAaAzrUXWNVyIh+N9h68aGmKiu3Wflp9cDyzA+3eYywpmbefVZqApAAy52iYeS2bsJQHJkBoFbv1fZn4jKY/PKpXuzJ8ftKE5unsD/stw9NJ2c5XFz/aSH7KSC8cS6sBPFufA5tbrsq5vullX0jzMWK15Kyg1YrCcQBgCIS6eIwrsr8ZgL1qw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(39860400002)(136003)(366004)(396003)(376002)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(5660300002)(2906002)(86362001)(4326008)(8936002)(31696002)(8676002)(2616005)(36756003)(83380400001)(41300700001)(26005)(31686004)(54906003)(66556008)(66476007)(66946007)(6916009)(316002)(6506007)(478600001)(53546011)(6512007)(38100700002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2FSdm92VjhxUXpncHNoK1RvSG9mTEMrQ0hHRnJtVEI5Wkh0bE5UeWlwang5?= =?utf-8?B?V0M3Q3lKUkkxK3FibW9kVTluWTBWZkp3M3BRK2VKSld5cGdtSHNoV3N3bDNk?= =?utf-8?B?b0VaUXRwSTJ6SFBoWHpib2lhU1oxbjQvOHVJTzJ6RGNjQVFYR3U0UWFlSzg5?= =?utf-8?B?N1hBZHBwb00rZXl6MGxwclUvU3RLcmpySEZ3Tno3bE9vVzRnQ3JwZjMvR3NV?= =?utf-8?B?NUlHZVl0NGZicm5CaUZTVExDOTBpZTdoUWN4Z1VLcFgrUHVRUTZVSkF1anU0?= =?utf-8?B?YVZtYklvc2NJaEVsTUpKalROOEZiNE5uUGlXYzJaNlNZc2NobUs5QVBNNXZw?= =?utf-8?B?Z1h4UDUrcmZ4d2Z1Y3ZTdFpqVUdwQ1BtR1oya2xMeFRkV3VLVTNRN0tWL05N?= =?utf-8?B?ZjBxZ0ZGb1k5S1Bla3UwQktKMDN3Z0s3OXRGc0NzSmN1UWNHbzZrYTdpVUVy?= =?utf-8?B?V0JtcHFSUk1TMysrblo4QmdYYVNka0RueGZ6ZU56YllKck9aa0ZOWkpiSUxp?= =?utf-8?B?VjF2Y1RtUjFQdHVUOXRIeFAwWitXRWMwb2NoM1p2Y3IrVm8xMTM4c3RvWUtu?= =?utf-8?B?b2hFSFVTaUlzSm9aSzdocUtPZlpnM2FmaGxMaDEzeXF4ci9Wc2dTNVhLd3Ji?= =?utf-8?B?VHlyRVNsaTdsRm5PRW1uOTF3T1FQcmhDcDlyRm1xdnRmUHR0Q1pIWnFCaUJm?= =?utf-8?B?ZnpoVmNOak1OaDhLcVh1RjlNZDg1VFNIYUI2ekg5THN1eG9ybUZwMkFUUGRZ?= =?utf-8?B?blJhTWRWRlNuaFFlS3RKMWFTMXFaaGRuS1k1dG93WGNRN1huZldrOGdLZldT?= =?utf-8?B?RzgyL3FVT1YyWnNiT0dFQ3FJakxnckRYOWNUWU5jdzVjaWpFWk4xUjA3RlNo?= =?utf-8?B?enduUzlERmF5QU9XdVRYWCtrZlBFUVZmK0xiQzBOS2JUcFZaZFgyL1JlbVNw?= =?utf-8?B?Mi85a3RJT2JjRXd2ZDNFbUdLdnhYM3dwcDYyNDFmbmZKUUxyWlhzMk5zZnBx?= =?utf-8?B?ZGQySCtsdC9wY3NiU3NYVjNnWUc1OWlPbVhmTVprUU9oWVJzKzROZytvK2VK?= =?utf-8?B?WWVaMk5TRUovS252UHdITUVVQ0FIUGtVQmxqbVJhT1lIdWJVMUw3VE9PU1Vq?= =?utf-8?B?bE5EQkp5VVFubGdIQnJnNFlRV2d5aDZqeGpjMDNCcXR5QkpLTUp5dVpwUXZO?= =?utf-8?B?dUFWcm9wblpSYklhdHRLQUY3YThlVEZxeEJIZVJJeGc1MUk4RXV1azBPZlgx?= =?utf-8?B?TGkwYkNNTGZCWERyZG9haDgxZHkzMzhrYkN0ajN1eUs0N3RyNTVrL3dtR003?= =?utf-8?B?bXpRZlo2VWV6MkJkM05PSUd6eHhkaUVwSlFTN2ZZY2hobHRzQWJHWjErQVNB?= =?utf-8?B?RytOTU5LVzczWUhDaXB6MWZ1VUNJcS9pK3NqeUFjaWdHTDk4SHBBaFhsVG92?= =?utf-8?B?ZmIxMlEyK1hYZmVsUUxacWZ5S2JFRk54ZDk3NS9keDc4bDN2MndSM3NlejAz?= =?utf-8?B?NjN1UnZ5U01JY05QVEZEOHpBbFZKQ2V4UkZsVmlGSVkzQWhveERYSDZXREI3?= =?utf-8?B?MFU5R1dEa0hBNWo2WHVEai81YVNFSDlQUDlUWldUcnkxd1JEZFNiMThmMmsy?= =?utf-8?B?aElPMGFHWkVsMVhEdGcvaG1sYUlmblRxaVZrWDN5cDVmTkYvaXJWV2FsR1dJ?= =?utf-8?B?czErUzBaSVEwc2FUQ3JZaTBkWWdkbnVGQ3RPOFFiNThDZGxwbVdmYkdUcXBK?= =?utf-8?B?ZExpRS8rdnR6M0ZJc1BMeHZNWHdHazNmSnlzUXpMS0ZMVm4wd2pQMkV3SVlp?= =?utf-8?B?UURPVHI0Wmk0QmM0RWZFeVlKbExiZnduMXl4R2xFMWJwTTRtaXRXTFBVTkc1?= =?utf-8?B?U3lId3lXemVpOUc3WGlocWRKYXI1MG1hQWdLSkQ3NlVWK0tYcWhhejFBeHZH?= =?utf-8?B?MDZvMC95WGJjTjJXMnF5Y3B5Yi9PVTdyYm5nOVAwREcrSi9tYTJ6c2g5Q2VY?= =?utf-8?B?Nk5FdlFEc2pNcjhINzMyNlA5WWRVTWNqNFFZa2FxZklkUFFIOGQrQTVDUndB?= =?utf-8?B?djB5OEdUays5WVVmK0pZRkp1MENFaU50L2tqSC9kSzJmV00yVXgrTkFJVitl?= =?utf-8?Q?l4xWilVD2MR6MkZkbvcVlmXUU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fcd9337f-1b01-40a7-f6ae-08dbe9a161e6 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 08:19:14.7100 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S24ixFyGjzH9fOLJKJGzAg6GxOEKDJmChdKc41kF5OZdiVOrdlvQQ1cjknKaYsFgk9uKf1sKyZIKQtarv6NAyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9888 X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.11.2023 02:33, Cui, Lili wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Thursday, November 9, 2023 5:37 PM >> >> On 02.11.2023 12:29, Cui, Lili wrote: >>> @@ -190,6 +193,8 @@ mov, 0xf21, i386|No64, >>> D|RegMem|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_qSuf, { De mov, >> 0xf21, >>> x64, D|RegMem|No_bSuf|No_wSuf|No_lSuf|No_sSuf|NoRex64, { Debug, >> Reg64 >>> } mov, 0xf24, i386|No64, >>> D|RegMem|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|No_qSuf, { Test, >> Reg32 } >>> >>> +// Move after swapping the bytes >>> +movbe, 0x0f38f0, Movbe, >> D|Modrm|CheckOperandSize|No_bSuf|No_sSuf, { >>> +Word|Dword|Qword|Unspecified|BaseIndex, Reg16|Reg32|Reg64 } >>> // Move after swapping the bytes >>> movbe, 0x0f38f0, Movbe, D|Modrm|CheckOperandSize|No_bSuf|No_sSuf, >> { >>> Word|Dword|Qword|Unspecified|BaseIndex, Reg16|Reg32|Reg64 } >> movbe, >>> 0x60, Movbe|APX_F, >>> D|Modrm|CheckOperandSize|No_bSuf|No_sSuf|EVex128|EVexMap4, { >>> Reg16|Reg32|Reg64|Unspecified|BaseIndex, Reg16|Reg32|Reg64 } @@ >>> -290,22 +295,36 @@ add, 0x0, 0, >>> D|W|CheckOperandSize|Modrm|No_sSuf|HLEPrefixLock, >> { Reg8|Reg16|Reg3 >>> add, 0x83/0, 0, Modrm|No_bSuf|No_sSuf|HLEPrefixLock, { Imm8S, >>> Reg16|Reg32|Reg64|Word|Dword|Qword|Unspecified|BaseIndex } add, >> 0x4, >>> 0, W|No_sSuf, { Imm8|Imm16|Imm32|Imm32S, >> Acc|Byte|Word|Dword|Qword } >>> add, 0x80/0, 0, W|Modrm|No_sSuf|HLEPrefixLock, { >>> Imm8|Imm16|Imm32|Imm32S, >>> >> Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseInde >> x } >>> +add, 0x0, APX_F, >>> >> +D|W|CheckOperandSize|Modrm|No_sSuf|VexVVVVDest|EVex128|EVexMa >> p4|NF, { >>> +Reg8|Reg16|Reg32|Reg64, >>> >> +Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseInd >> ex, >>> +Reg8|Reg16|Reg32|Reg64 } add, 0x83/0, APX_F, >>> >> +Modrm|CheckOperandSize|No_bSuf|No_sSuf|VexVVVVDest|EVex128|EVex >> Map4|N >>> +F, { Imm8S, >> Reg16|Reg32|Reg64|Word|Dword|Qword|Unspecified|BaseIndex, >>> +Reg16|Reg32|Reg64 } add, 0x80/0, APX_F, >>> >> +W|Modrm|CheckOperandSize|No_sSuf|VexVVVVDest|EVex128|EVexMap4 >> |NF, { >>> +Imm8|Imm16|Imm32|Imm32S, >>> >> +Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseInd >> ex, >>> +Reg8|Reg16|Reg32|Reg64} >> >> Why are there (just as an example) only 3 new forms of ADD, but ... >> >>> @@ -338,10 +366,19 @@ adc, 0x10, 0, >>> D|W|CheckOperandSize|Modrm|No_sSuf|HLEPrefixLock, >> { Reg8|Reg16|Reg >>> adc, 0x83/2, 0, Modrm|No_bSuf|No_sSuf|HLEPrefixLock, { Imm8S, >>> Reg16|Reg32|Reg64|Word|Dword|Qword|Unspecified|BaseIndex } adc, >> 0x14, >>> 0, W|No_sSuf, { Imm8|Imm16|Imm32|Imm32S, >> Acc|Byte|Word|Dword|Qword } >>> adc, 0x80/2, 0, W|Modrm|No_sSuf|HLEPrefixLock, { >>> Imm8|Imm16|Imm32|Imm32S, >>> >> Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseInde >> x } >>> +adc, 0x10, APX_F, >>> +D|W|CheckOperandSize|Modrm|EVex128|EVexMap4|No_sSuf, { >>> +Reg8|Reg16|Reg32|Reg64, >>> >> +Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseInd >> ex } >>> +adc, 0x83/2, APX_F, Modrm|EVex128|EVexMap4|No_bSuf|No_sSuf, >> { Imm8S, >>> +Reg16|Reg32|Reg64|Word|Dword|Qword|Unspecified|BaseIndex } adc, >>> +0x80/2, APX_F, W|Modrm|EVex128|EVexMap4|No_sSuf, { >>> +Imm8|Imm16|Imm32|Imm32S, >>> >> +Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseInd >> ex } >>> +adc, 0x10, APX_F, >>> >> +D|W|CheckOperandSize|Modrm|No_sSuf|VexVVVVDest|EVex128|EVexMa >> p4, { >>> +Reg8|Reg16|Reg32|Reg64, >>> >> +Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseInd >> ex, >>> +Reg8|Reg16|Reg32|Reg64 } adc, 0x83/2, APX_F, >>> >> +Modrm|CheckOperandSize|No_bSuf|No_sSuf|VexVVVVDest|EVex128|EVex >> Map4, >>> +{ Imm8S, >> Reg16|Reg32|Reg64|Word|Dword|Qword|Unspecified|BaseIndex, >>> +Reg16|Reg32|Reg64 } adc, 0x80/2, APX_F, >>> >> +W|Modrm|CheckOperandSize|No_sSuf|VexVVVVDest|EVex128|EVexMap4, >> { >>> +Imm8|Imm16|Imm32|Imm32S, >>> >> +Reg8|Reg16|Reg32|Reg64|Byte|Word|Dword|Qword|Unspecified|BaseInd >> ex, >>> +Reg8|Reg16|Reg32|Reg64 } >> >> .... 6 new forms of ADC? My guess is that's NF-related, but doesn't that mean >> that until NF support is added e.g. "{evex} add %eax, %eax" won't assemble >> as intended? IOW in line with NF as an attribute being added right here, those >> other templates also will want introducing right here. >> >> While looking at patch 7 I'm also wondering whether same-base-opcode >> forms wouldn't better be kept together. I haven't finished yet looking at >> what's needed there, but even if it doesn't turn out strictly necessary there it >> may still be a good idea anyway (unless of course that would get in the way of >> anything). >> > > For ADC, there are 3 templates that do not support NDD and NF, I moved them here from patch 3/8 which we discussed before since its decoding is supported together in the NDD patch. Feels like my question wasn't really answered: Why are there 6 new ADC templates here, but only 3 ADD ones? Or in other words: Why are the other 3 ADD ones only added later? Also I'm curious: Why do ADC and SBB not allow for NF? They always consume EFLAGS.CF, but subsequent insns may have no need for their EFLAGS output, just like for e.g. ADD and SUB. Yet NF is only about EFLAGS output aiui, not about any bit(s) consumed from EFLAGS. Jan