From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id 219B63856DCE for ; Fri, 6 May 2022 06:08:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 219B63856DCE Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2059.outbound.protection.outlook.com [104.47.2.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-40-ylFu54qlOKu8sxO7CYCHoQ-1; Fri, 06 May 2022 08:08:25 +0200 X-MC-Unique: ylFu54qlOKu8sxO7CYCHoQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZYF1NG9mlfVfK56V+hln5faaUZkBEdr2XEHSb3IvUByLKqtwT/D9zdZrVm+UPm/U+/5GoDmSzjjGFn3RfARyNzdxqoPDz5gp9ftmBGw98NTdUGtbA0O152wCl46WlMuFeak/9B2FYH5ot8bNWsYgSr63h5o7OONRTBOAYmUeDOdjXf92V18BL5KWYL7jyiYsnLGUJhBIafGOkd+rXX1mWjwjezD9vdsDWtRGT/kW3wnE/67vmC/4+W7xYhVEi678Hh28ujQqpe02ZR6a3PIQCm4nOOH36R7HqoUayFOuoM8vQOqLOBMqFpZCDLriMI7O6REHpw9pqAg56EBssoRz8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/4dF8JDSU1Y6FmIZAP2blNbXnDssqxy00/O0kl5mdbM=; b=KQNZ3DPPuTy3bpbBpmbC1Ftk3r5UXi2zShw04xOrOTAw4Dt2Q3mC7gD16ommOu3yrd8ViABuK0QlNptdJgT+ItTYZOUxPTTTeX8aj/vx1cww0LJZjaC2FZbwrgg5bPoe5YAm9OyexGMQafiObBwzSH1T50dc5K0uUIksuUvNhGbH3PgQEhee+gadg9Vo5H4UK60wwVD/6TH3z3xOMGe6SEs4PVMzscyF8k2U4kfSZCSlxKVdUjyOOpykS1PYtsehjMvCGQlfaMYHQw0w4DzRhilzzmA4rl9OpUhD8/dNlR4zpnzdwkNuMK7rWaVLSkKXGqP47M8Wu44QTJuiQZIrew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by PA4PR04MB7871.eurprd04.prod.outlook.com (2603:10a6:102:c2::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.18; Fri, 6 May 2022 06:08:24 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::84b:e9d3:8906:8b9c%6]) with mapi id 15.20.5227.018; Fri, 6 May 2022 06:08:24 +0000 Message-ID: <152c0e4f-4fef-1f10-e2de-dfdee829255e@suse.com> Date: Fri, 6 May 2022 08:08:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: [PATCH 6/6] gas: avoid octal numbers being accepted when processing .linefile Content-Language: en-US To: Binutils References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0777.eurprd06.prod.outlook.com (2603:10a6:20b:484::31) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9642fa61-d94f-4f20-70b6-08da2f26d42b X-MS-TrafficTypeDiagnostic: PA4PR04MB7871:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ovcoSNcSoej3wC5zC3W6hAzR6dwwkJsjqgko6jKCC8b90TbiQUQOGT99gnAfWiCU+53oOA0pH+jmPwpElz0v/zMY6Lo2qH31/nGduAtnKoU1a+vsx2Si545+oT9DOVqO3NWvTdW63TQibDwbchhQhdJHaNT+BBX5wcZgx86OFx2Ws3wa6fFSANGIZkOt5TlGHUNKutlz3HSEX/pNv3jK2szz8dY9AvnFr/tz+ql4kRNvBQyFcVdlkn0gJRuXvEvR2/69cB169Q99eBGxqefrybCuE/Z1bp/LTgK2HPk/dNhdTc6bDFqfg95qtk6YUrRpqluyg9BWupvbRZh7/DqcOHb2jGRweofr+7NOT+vY3De0LwrX151OZcgvPlSRkjhWfkHphJ1Ouau5ouo9aY8Tt0oHOSsFUPqJf73VWH/3NMnIoIc4EDkbnm8HXtFP++JjRfjxESfDiMaYGuzmoSjNMfpfxCZzqJwnoxsUQfpTMZm7AeY185bvMzDxifgFBXk5Xzr0W5ZUsnMvxibLvTq/Rr9pNZosr9KL/Q1J4too5oRoNPY4q1hvPA/Y0nQ2FopiOwAkxs6oY5V/1zIjt46taj/hY4mGBG3Tf0FMZDZH6YpmOIzTAQAU40UQsl0FKE8glQ5P9AA8KZBsnx44OUvyank+bD3lm0bJTDbx04CKvvMJ1BHRzMnbPfMfvSSjWdP5Mznd6RBPB7E31rwsmdHhXZK45o0vWPvIjVuAiT9rUsldXrF8g+Dva1mu3WrLLi0mubPvq4EupXDsDtu+m6ex6A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8616.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(508600001)(31686004)(6506007)(8936002)(2906002)(38100700002)(316002)(6486002)(186003)(83380400001)(2616005)(86362001)(6512007)(36756003)(5660300002)(66946007)(66556008)(8676002)(26005)(31696002)(66476007)(6916009)(142923001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGtWMFZTaFJzYkIrczRpOGcvUUx5enBxWVQzamttMlc2aWhZd3RoTHB3aHRH?= =?utf-8?B?NnVsWDB1ZDlxVVprUktEZ0ZaWk5laWhNY2Z3b2ZZK1FCUmlTMWNCN0RRQkJN?= =?utf-8?B?Q1plY2RwaHV3N0lQUTJMSzlWVmcrbmVrWlEzWFd1N0J3U0tSMitzL2VraEVM?= =?utf-8?B?L0V2dGRiMUo4WXZ1VTVUTnl6eE1CblAyWlhIRDNhWTRhdzRneFBaWjV3eFVr?= =?utf-8?B?TmFwQzdNZzYvVHZKSUZ2NVNIN3gwRXRyVHZWQ1lYLzR1aThLcUdURFJrNjR4?= =?utf-8?B?TCt6NERscGNpbTZ2ZlNtbzNFbnRzbEhWTHFuZkxoc3RTWElIK0FZQmxCa0JR?= =?utf-8?B?alY0TkNNVk8vejZYdHkwQ3VyYm1ZdGJDYlMreGx4aHpCVVhHb2lCZFM4bTh6?= =?utf-8?B?T3FIUlZDa3NMTlNvWXZKTkVLNzlGdkdvU2xlUkFoZVJGd1lRV2ZpR3JJZXdu?= =?utf-8?B?OGU2NXhnUDlxSXJKb3d0aWJHQmoxSWFIZUxoWTdWNnlWSXdXblZ0WWRra08v?= =?utf-8?B?THhhQTNlRFRBMk0wMkVMR0dVY2FSakt5anR3Q2lodFlOQ1dKdEY4Uk52bTFV?= =?utf-8?B?dUd3dFJYR2pwTzUyTktrQkJuOHpCWDdjemFpUElMK2MzTXhtNHVHckVCNzcv?= =?utf-8?B?QldUVjVVN25sSHplM0N2VEZmTzBjeWNSKzZRK3lxS3JNd1R5eDlvOG5UcGRn?= =?utf-8?B?TzhzemhNSk9jdXZ0S2Ivc3ZvOFduNGVucFl5WmNmcXhnK1FhSVk1M3hkV3pw?= =?utf-8?B?amlRbHhCUm0vRk11QUkvRTUzUkFTWEw4RHBrTk9manVtdVZRcjRpMWh3L0lq?= =?utf-8?B?MTlHZ3JQem5kUEdsL1pBUER5REMvdCt1dHNodWFEdjNQSGxuZUR4SmRmMk9U?= =?utf-8?B?UkhtQjQwY1p2VjVkUE9kTkV0WWQ5V0ZReHZ0RmVkbU1EclpRc1c1Qk5XRWQ5?= =?utf-8?B?TDU1NkdobVBRUUpDNlhKaEt5M3I2YWswRlBkTTJrRmtaK29UbHRPMlg3Rito?= =?utf-8?B?Q3R6WnB5MVdQa0dTSFExRW1RZTdQdXNyeGs5N2pwakFFdEpKeGJ5RTJCQXFM?= =?utf-8?B?SE0vSUJ2a0dRbWNQMVFuSGdFR0ZqbmgvYUNpckxuZUQvVXIvNTlQbjdyeWM2?= =?utf-8?B?QmtWRDNjaUppbTYycElSb1NoOXBHbzArN3hvZUNUS3FqUDBPekwySmIwNkQw?= =?utf-8?B?NmhsTHNxeHdxMjFVdGxXM082SUw0Q2llYnB4eU9FL3BJcUt1bStCWHN1SnQv?= =?utf-8?B?TzhwcmtHVlZpVTJLWWQ5UUk0NW9aSTJzWWU1RlpFcmM4cVppc3MxcUxWcWNh?= =?utf-8?B?WHlQWkYyV1I2Y0pGaTRLMWFkM2pCWThwd01xZUQ2dS9hWlFuMXdFUWY5RWcx?= =?utf-8?B?eHBuUkRUMXJsdFYra29jdkxHRjdza2M0UGdmSnVDS0w0VWhjTTJWZGIyaWVl?= =?utf-8?B?emo0aWVxM1YweFVJcGR2K0NCSjFCU0EySGdCT3BXTmJtZWFTVUtKSlpBMmIv?= =?utf-8?B?c1djRDZEZWFqaGhYT1pOcU1oUFhmbjNWUFVGcUZvWFp0UFpFQS9mVzZsc2tR?= =?utf-8?B?VGpXa01oMnJzNldiNTVTTjY1YnFJVE1JTGhvUDhabEZ6UWQ5WEpiUnVHaElo?= =?utf-8?B?aWRYM09jc2FrdUdnNmNKT1p1UzF6aU4zMm1rd2htOURQZGFEVUh2MHBpM0Ri?= =?utf-8?B?cElDNkJTcjZ1bTU3dEs4NUI4SlhSZzhXSm1Vc3VIS09nYUI4T1JCa3hnaWp1?= =?utf-8?B?WlNmNUhxTytqaytHbnRwQkpUank1Vk5lbDVYbC8reGFrN3h5emJ0TEV4SWdr?= =?utf-8?B?TVczU0VuUnFyN0daMnVCVzdlMFZ5RjNXek54RldsbDNLK1F2YU1RNzlHdW1k?= =?utf-8?B?Z3MyUFE0bjlLZGxKZC80UXVPaTBvTlM2V1E4OHdhTUNhcWMvMjI0TEN1Zlhr?= =?utf-8?B?cXZZTXZqVHZiMi9BVlNQdXhrWUhjZjRMWjVnZjBnMFd4dG5yMVdnZXNxTkt4?= =?utf-8?B?NmdGT0FuZUlsUW8vOHJZemMvSVAzSktPU2kxY1R4blczSVVSem1rc0RuYXF1?= =?utf-8?B?TW96ak9xOVFLMEc0MHdhZ2xZSDVuNWxxV05WeG9SMHVRWThBZTB0UmszUEI3?= =?utf-8?B?TFVxNXZlU3Fpb0JWdXk5NG9mWktpQWJIbjBkcmRFdHI0My9uZGhYMnV2anls?= =?utf-8?B?a0JKc2RoaHppc2duV1JwTjNlTlo3cHhDSXlpb0lIaVhqbk4wbWM0ZkVsZmdY?= =?utf-8?B?Vmp0aTR4Syt1ajhwQStmTUJXU1pybGFQM0NXdUJKWEd3Zzk5SUFDSVVhUU4r?= =?utf-8?B?SFVxQUswVU1mV3M2TjdSRHZvV01uVEJZYUxSMDQrdVhxTkFVemRhdz09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9642fa61-d94f-4f20-70b6-08da2f26d42b X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 06:08:24.2319 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zrs8MvY/ryDKFwahrDxK/mAxw/r9U4JhKVlVgzc6HDeR7h39ae+fknJSWY7DA/YEx6D6K/4JLWaBHcVwm80poA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7871 X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2022 06:08:28 -0000 Compilers would put decimal numbers there, so I think we should treat finding octal numbers the same as finding bignums - ignore them as actually being comments of some very specific form. --- With the bignum and this change in place, I'm still worried about the secondary use of get_linefile_number() - afaict we might still mistakenly try to process special form comments as line/file "directives", and under the right conditions this might also still result in unde diagnostics. --- a/gas/read.c +++ b/gas/read.c @@ -2047,6 +2047,14 @@ get_linefile_number (int *flag) if (*input_line_pointer < '0' || *input_line_pointer > '9') return false; + /* Don't mistakenly interpret octal numbers as line numbers. */ + if (*input_line_pointer == '0') + { + *flag = 0; + ++input_line_pointer; + return true; + } + expression_and_evaluate (&exp); if (exp.X_op != O_constant) return false; --- a/gas/testsuite/gas/all/linefile.l +++ b/gas/testsuite/gas/all/linefile.l @@ -2,4 +2,5 @@ .*linefile\.s: Assembler messages: .*linefile\.s:2: Warning: line 2 .*linefile\.s:5: Warning: line 5 +.*linefile\.s:8: Warning: line 8 #pass --- a/gas/testsuite/gas/all/linefile.s +++ b/gas/testsuite/gas/all/linefile.s @@ -3,3 +3,6 @@ # 123456789123456789123456789 "LINEfile.s" .warning "line 5" + +# 0123456789 "lineFILE.s" + .warning "line 8"