From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2073.outbound.protection.outlook.com [40.107.104.73]) by sourceware.org (Postfix) with ESMTPS id 685193858D37 for ; Thu, 20 Apr 2023 09:01:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 685193858D37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PIv7hZj6cZ82RqbvpjuWjA0sBNVCIWMuG+ww0h4sMUuLS2lPc8QVPa5e/0swK1HmqIDtv4IFlRnIGpjlCDhmjoM7bQDHVtsiZECsogmbErSZ8M698GRYZ4RZnyjZMTcvEpxghUVpqqpCtLALJRrIvK4e2q6/2YhLAnDMJzKMxVrNK5DbpdpPF36KB+rMgz0LHvZsOEVM6loEEb/MvozjNzdPtMTrhrowmZHS9FGS+frDYvJoVRxU+REPYdZczWbh2UBLdt7/dQUAZGtPpyBDPNMezXq8GiQpkAchTNW+dTy8LTK6+/0PdX4xz8axtOKuxMpmyMMdxpAhn/w1vo9S/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C2zfPEzBNdDEXMBgazdd6rIBMalvbR5P27TMBtQJYAQ=; b=BgbkPDmLlF7SGoK04en3EiImuMqrqZDILdFNX2cyxLdajoo9aenEuwW5rgLTwYfb0XFPHUTIP3kSXIfrYNNIOafoq2HW74sMQdTG7Au1J2ifR85nSfwR1ALMgTRZ8EvYj5b2TdYZoFz8vtqACcAdnWIprRGKhmMOwhJZpTm4LjDBgIvvvkmxJ1Jj9PrSoZHKNbg7Ub6Fv6zQC1bl5eOsqjPtz85/zWjv7XyMmZQn6BlWBE5kvKw7HKMgm6l/57PLnA8pdjHY0MRitxW3+4uCcCMM0Hfmt58PQcpxOyb716tOjSYJpEhC1sIPMx5ChRas3/z7VkQ/SB7LgEMJTLOfBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C2zfPEzBNdDEXMBgazdd6rIBMalvbR5P27TMBtQJYAQ=; b=0mfmy900e2Bb4+HJEIrsmZb8CP6dnZoBy3013DT/2CeUC5XpHT5Qc5/OtCiojlQ+x7DfqTfyCZtnC9X6wUSxpDuyBMRbAEUoKxGmIv9RmhhIAmKokDGSbMECPhVuRHS5wwDtDnPfooknKBnPMW8m519n8gh7u1w3nsLa0K78B0tN7qxXPZgoEpDCH9zBV5jgfvCJDhtCOHaFUao/Q6J8t/x+uuv3aYAopUGtuuP6eiCEOIjLPrXo5OKkAEtSsp7ePVPMkunjA7n3LcmWol7OBNwWCCzxj8YVpjy2Kjj3waUWrj+ohwnTxjpLk+Lol2NzszRoJIrIEX1gNYSP6Bspkg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7405.eurprd04.prod.outlook.com (2603:10a6:800:1a4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.22; Thu, 20 Apr 2023 09:01:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::52b2:f58:e19:56ae%2]) with mapi id 15.20.6319.022; Thu, 20 Apr 2023 09:01:53 +0000 Message-ID: <15454510-ffe4-7afa-6151-f918983769a5@suse.com> Date: Thu, 20 Apr 2023 11:01:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 13/14] x86: convert testcases to use .insn Content-Language: en-US To: =?UTF-8?Q?Cl=c3=a9ment_Chigot?= Cc: Binutils , "H.J. Lu" , "Jiang, Haochen" References: <2b0ca132-9d85-86a8-8b91-828fa66881b8@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0113.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7405:EE_ X-MS-Office365-Filtering-Correlation-Id: 45040743-88b3-4bae-c065-08db417de2d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6NEg3elJpHGRT5XzV/JLKr7d4FViuF2mFwyapSu1RoVJbacRQCcvl/XnOut3OqPcdJdt5T2t4Hua5zRaf1/ghf1iPV5gf7Y47BRVg1UcXUwxgJDcN+FMURKNHL/9GG5jWjfQAptV6QjjIipx/OXm57LR+ikoYrL+WP2n7LA765FWU1hrvwYBtNF1DIZNoheHZPBfOs3mnrtVSxcfv/TW8h7nB/Mx6/RIzvaWuFfMG16B7Jr5ZX8Bdu7CS1HN06aKnOh22mZ7pFOL1LRMLr47jwhn6KoG4Z2TFqTY/TetHIfiCY/jn3E9Q86KCgN4TPfSJLwcKhdmcO1ApcFIjPNsCJUyqZrAvnPB3amQL8HU8xX80W8uUal2O8uvRjlxLaaX67jpvB664ZtCgIm4fHTY0sj0DoZmsgZH1+J3pSK5hpu+G/LV9KDQE3lNzMK5PLQjLOROfcf9y1TQ3Bcn8+D6by22Ns234PfpoKOwuuYZ+w8rqpIrds1Uhv4iWGywQFMEO9WtuyxJczvyW37me5yL+P1RtHUgCYsF61gQiJQrUx3OiXKViwfXh8ZveHBHKiKWAH1yTZUVCAChdRqEr0g3Aj1rL5uSXOeERcjLILtMjxTBMoqpjAehmRPQsTepmwaUyP2glE8vEAn1F/6rBiJKEBGyL2waKt4kCflSZaBiHrw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(39860400002)(376002)(346002)(396003)(451199021)(6486002)(86362001)(83380400001)(36756003)(53546011)(2616005)(66574015)(38100700002)(31696002)(8936002)(8676002)(186003)(26005)(6512007)(31686004)(6506007)(41300700001)(6916009)(4326008)(316002)(66476007)(66556008)(2906002)(66946007)(54906003)(5660300002)(478600001)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3BsalRsbllvWlplK3U0RFovcGRhR1lJeE1LM2dKV21FQkhESHFUYUtMcnpz?= =?utf-8?B?Sk5uT3B1SXdhQzd0eUN1dERETkN3ZTFlKzFmN3dGTHJqNjJnTXEyWWc0ZTdB?= =?utf-8?B?dXFpcHVDc3J2RGNkelN6UDFnditKQmpIK3hvRUZrc25zZ29RbnYxVWsxbVNq?= =?utf-8?B?S0dreWZiejh6Y09hNFREYlBBSUlkVWZNb3B6MXpCL0JvQ3VwMi9wUUN3RUFR?= =?utf-8?B?TEh2SFcraG9ham12Z3BvZ2hyUmFtYTBGWWUzeFdhZVUyNUZKREVDNm03YlZz?= =?utf-8?B?dTZUbUZPczljN3dtWmVVQ0liUDVjV21VRjREZkQzdzhoeS9mMmFKeU90Q3NF?= =?utf-8?B?eTlvRnVIcEhERTFwNlpldmRXMk5WdWwrOGU3NFp3T1hadVo2TkxUYkJXQWhN?= =?utf-8?B?ZWplbWxSMmdDNTIveTJXMGRMRW85VzZoR0ViNHdjbnJwUmN4ekE0cWRsUFFB?= =?utf-8?B?L0VubllnV2RDU3dDVkZRdGNta2dTdXRWeEtZRk00YlBpb01WRGxuaE0rRThL?= =?utf-8?B?YTJweGswMUpqcFFhdXNNY3NHdXoxR1NwNHdLcFdWWSsySWtLSFMvZUNEcUp0?= =?utf-8?B?SUhhcVJ1V3QyMGs2WFYxai92Wm5MZGRPdDRSOVNuVlUzazZzcE9sUmZwYjRl?= =?utf-8?B?WXdxZm9pekFmUXozSVJzaWVRai9zcWl2NWxBT0FhYUdTT1A0U21XVGFuZisw?= =?utf-8?B?RjZkMTJzTDg4dlVsWWh2cHV6WklCdmlDc0RiZnQ2dS9HMklvblBvbnhMTzB3?= =?utf-8?B?bnRNaExBa3ZlRmFZOUMxb2hGY3h1NkJwTkhmOHgxZERaUmVpendzVVI2VTRG?= =?utf-8?B?dFB0QXBHNGJhamdzUFkzaVlCSUxEQkhYZUNBS2ZBMUV2U0V3ckRxZGJXL0hM?= =?utf-8?B?ajhhQWZLVzY0TlhLWlpTcjFWUEJhNVpxS2k5cTFpMlprcXZWRnorT0VTT0tu?= =?utf-8?B?MXB1RkNzbS90ZS8weTlwKzM0M3hVeW5PSlovaW9tcWFJZDFjSjhCNC93czA0?= =?utf-8?B?WHVwOHU3UWlOWDUyZFhDdnJPcFlMUWFVTk10cmhZOHRRemF5UnJZR3lJQmRH?= =?utf-8?B?Q2dKbHlRMldTNDRBd1hRYVpTeFVsbStZQUxZZE40STA3WFdyRFhaY09OdUJw?= =?utf-8?B?YURSckh2UUhxalV3SGN3RjByblFlakxYckw3ZlBGZ2xCYURuQXlJQmtJcWRh?= =?utf-8?B?SVdmWUxWUnVOdmltT1VwdnFWWkVtY05xSzVqR0JPRHdnc254WjlOdGpzNTRF?= =?utf-8?B?MFB4TzhuRXhxRTk2S1RoNXQ3TTdIWDJZdTNOOStaUU0rLytjdkhPTHlIZmhH?= =?utf-8?B?Tnd5b2tyNHNJdmpXSDhXWmVIWkpRd1NTT2ExcFpGbjdsME4wWFY1NHJuTzA4?= =?utf-8?B?anE5bTBRRTlZWmZuWmhUNmVPN3FqUnJuUFl2dDkrL3gyYWdKcDlVR2tDMW9u?= =?utf-8?B?U1cwb1E2L1pSNSs0T0hzUGpBVzdoOStKZ0x1YjVjMW8rbHBEOUFhN2k1dVRI?= =?utf-8?B?V3ZKU0RhMjVLbVgvY3ZwV2hxeGM2QUx0OWp3OEc0VEN0bHRzcEVtd2wzVXd2?= =?utf-8?B?RHVDT2ZmN2dQT3dzUzdVTm91OWRYNmZySVExak8ycFY3L0pneEtlL3RxYlhs?= =?utf-8?B?T3ZXTnd3cGRNZHAxZzBSUXJOZGc5ZWtaejhKSTI0ZjlZak5MOFJWZVNBZ3NL?= =?utf-8?B?cjEzRE5pZ0p6NElQNkdWeTc1N1E5TVBQNThpYjU2T3gxcTlETGZ2WlZ6Y1l3?= =?utf-8?B?TVFjc1NUWEpCUkxXQTI1akF6YkxkMXRXbml2RS81WlQzdkczVEFiZjg0RkpH?= =?utf-8?B?aXpUYmZLWHg1eVNFN2kzSDlvMWlxRTVNYWh3ZWN1UERmTlcwMzdwODlldnl0?= =?utf-8?B?WkYrMTlIMHlkZnpQSFUzdFBHRVJaS3JBS0x4Wmxhdi9WRGdNQjE0TXZwMHRJ?= =?utf-8?B?SFRFL1NxcmNMVk8yanJLUUJGTjNqMHo1VGQ3L0U4bGxOaHBybTZXd3RJendz?= =?utf-8?B?Q3JYdFRQMVZQNExBb3lkcmpTZTBDaXhMYXBQYXBPdWRJR1JLN25tVy9ydXdm?= =?utf-8?B?RDFkSWV5YWl1UkdsNkZsdkdiZjdod2wrYVpCRFNhR3Vnb3JjS3EwbHNrM0Z6?= =?utf-8?Q?LRwZ09EAqxMPadRRQJPP4yJiV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45040743-88b3-4bae-c065-08db417de2d8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2023 09:01:53.7460 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rdMab33pM/4NQSvRAfPEVToS7+CS1YzxisI4OXpSOdLdHbnRzT3HReIHEOww7xl400zX6e84dm0ZVVT77rEelQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7405 X-Spam-Status: No, score=-3028.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.04.2023 10:56, Clément Chigot wrote: >> --- a/gas/testsuite/gas/i386/x86-64-opcode.s >> +++ b/gas/testsuite/gas/i386/x86-64-opcode.s >> @@ -458,16 +458,16 @@ >> int3 >> int $0x90 >> >> - .byte 0xf6, 0xc9, 0x01 >> - .byte 0x66, 0xf7, 0xc9, 0x02, 0x00 >> - .byte 0xf7, 0xc9, 0x04, 0x00, 0x00, 0x00 >> - .byte 0x48, 0xf7, 0xc9, 0x08, 0x00, 0x00, 0x00 >> - .byte 0xc0, 0xf0, 0x02 >> - .byte 0xc1, 0xf0, 0x01 >> - .byte 0x48, 0xc1, 0xf0, 0x01 >> - .byte 0xd0, 0xf0 >> - .byte 0xd1, 0xf0 >> - .byte 0x48, 0xd1, 0xf0 >> - .byte 0xd2, 0xf0 >> - .byte 0xd3, 0xf0 >> - .byte 0x48, 0xd3, 0xf0 >> + .insn 0xf6/1, $1, %cl >> + .insn 0xf7/1, $2{:u16}, %cx >> + .insn 0xf7/1, $4{:u32}, %ecx >> + .insn 0xf7/1, $8{:s32}, %rcx >> + .insn 0xc0/6, $2, %al >> + .insn 0xc1/6, $1, %eax >> + .insn 0xc1/6, $1, %rax >> + .insn 0xd0/6, %al >> + .insn 0xd1/6, %eax >> + .insn 0xd1/6, %rax >> + .insn 0xd2/6, %al >> + .insn 0xd3/6, %eax >> + .insn 0xd3/6, %rax > > The test is failing on my side when building with --target=x86_64-elf. > I'm not sure what's wrong yet but gas seems to ignore everything after "/": > | $ ../../binutils/objdump -drw tmpdir/x86-64-opcode.o > | ... > | 4ea: f6 f7 div %bh > | 4ec: f7 f7 div %edi > | 4ee: c0 c1 c1 rol $0xc1,%cl > | 4f1: d0 d1 rcl %cl > | 4f3: d1 d2 rcl %edx > | 4f5: d3 d3 rcl %cl,%ebx Right, and I think I did address all of these issues (there were more than just here) in what was committed (and in fact already in v2), by passing --divide to as. Can you confirm --divide does not take the intended effect in that case? Jan