From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 99210386EC08 for ; Thu, 15 Feb 2024 22:22:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99210386EC08 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 99210386EC08 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708035736; cv=pass; b=pA2sGPug55PjB49QpxztFC6+ueWy9RZ8AU2r8MVD+3VBQqMBwWPpu+FI+ZrpBJWFBD3yHnZ+y5YvL0R+hAojn+ud6SepYN3dM8ggNUvTDFbnrOpDp+GcJFiZ/wE1TjzSZc8Q5gARWGhu3ShOs7mDuT5GHWuS4bIIo0IVwxSMG1A= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708035736; c=relaxed/simple; bh=Wy3wI+e4hkoAvlNHe7DsxPtNgsgbM9D+7y3u0qxFrgY=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=duGnAE9FiAy6zdMaIvMcqpjKFWoqn4QFZiIrW1auxcceBGMfXvD3O9/sxRHFIrouxh9XdLTxthJsVDyWE+nv1LgShmWt70LMDYN/HiZhT1LFirw2oObnhDHWoQpaI1PLJXSr71P0tO39qwBmxwVeaVrnMAGlD9fyG3MQCyeHAXw= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41FLSGHb029250; Thu, 15 Feb 2024 22:22:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=GE19Lq8BVFn8sBAB1Qt5E51OoP4W6olqrIoPW34gU+M=; b=IjeX3lRmL/74vv4usXQeZ2RRHXQeACalZtNMaqA+m1UlXJ/cdaz3IpWJtkrbkYreNiuJ fu+LAYLhOB/yO/7BHwYEeG2B3PrNBi+x19yQyXEOiLqClPj6Eice5o4xUD7zTEJOf3zy +CIA0Urrmamani7b2AMlCa0zPViMdoKzkmXlCqC1qRpfBSBqD2Rs0GEt/v5T72B7F1r7 pWtWa0J6kyn43fq6sarEbNy1bJWCNWGIKx0vSfMZDHce9wTemH/pIYA4/jr0ix9vFpKi CncsKHvEdYCEIMmgDTvfD3rASwtxTF0TrYFEpnAmDTWduXqJjGuSn6zXB6HaK7apZFeD yA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3w92ppkfnd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 22:22:12 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41FL7UpX024545; Thu, 15 Feb 2024 22:22:11 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3w5ykhh4cq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 Feb 2024 22:22:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=btQWuiAuL/Y8sFZkar10N9C/zunZw7ZYWmYjJg3rw7POixN7uLJ1bM2md5y5bKIiZkpIxG6PKiKfeVfcK7c0QuRdXFI6JEqmf+R/b2UPuhyWdikc2nmXRS1AV6AldNta4uZCjnlWXml80AasSaVMJIGX8yTOL1QCEuCaMlZM+0SS9C15uWyXp/fGTh9geZyp9IfJhN4Vmk8c7l+XTIOw/cCwzi1r9vdKZgftpAx2xDaycyzcQlfg+Q7ARcLGPHiyKEu1QM1Y+VtKi/TyyYh/Osq7qYEj7RlA+eFlwnpd6jwSkydprVz2wQni7yNyTGs+/TbkTCkFw4qiojqdm3NNrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GE19Lq8BVFn8sBAB1Qt5E51OoP4W6olqrIoPW34gU+M=; b=d4+AKaG14QM67Wu0f0Jfu67b3hMfdenr+3oeCFdAfHDXPnmUvGG5g3gyme+1d7rI4R3+Bt/xYWPzxIIq1c7b7pPL4LX2GgWGjZHXrLSNCbZ8CBdDClZrwID0H24ePVgBIUVuhG0mDiOidSIKCZcm5wjAQPsXnbMRM1WsXU2a5AYWtlfyDhQ8dDFQMC0Rtx8mi5hxR4js2vHr3JKdr7WLzDFDe+b4I0a65My+iYtv05nVrNGJw7+XsUSbkW0FKnMvm3kWYXy/H72QppOHRxMRWGSDfAE2BvBJ/DYFzwGigfBBpCPrFQtJXtKLxM8E8oAA/n9PULvZKcdOCd6YssI/wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GE19Lq8BVFn8sBAB1Qt5E51OoP4W6olqrIoPW34gU+M=; b=hLcDclbB8DE1pRX0428zeejlIgGRVp+2MscA8cGygGg4ch1++CXjIl2I+Pk8bTfpZUhsVJoQ3kLN3mNo1KYNG9JAhuWknNt7WDNlsJvFw262QajSVfgBbDZkGrPHIHl2rPAgWwVsyNgSplbRybqMewrDNCsIOzIJCY1N00j/F6M= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by SJ0PR10MB5583.namprd10.prod.outlook.com (2603:10b6:a03:3df::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.31; Thu, 15 Feb 2024 22:22:08 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac%4]) with mapi id 15.20.7270.036; Thu, 15 Feb 2024 22:22:07 +0000 Message-ID: <15c6acc7-21f8-44bb-bf0d-97392f2fcd37@oracle.com> Date: Thu, 15 Feb 2024 14:22:05 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86: adjust which Dwarf2 register numbers to use Content-Language: en-US To: Jan Beulich , Binutils Cc: "H.J. Lu" References: <262f296e-673b-47f0-a764-276939161d64@suse.com> From: Indu Bhagat In-Reply-To: <262f296e-673b-47f0-a764-276939161d64@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4P222CA0019.NAMP222.PROD.OUTLOOK.COM (2603:10b6:303:114::24) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|SJ0PR10MB5583:EE_ X-MS-Office365-Filtering-Correlation-Id: 5bddba76-1e64-4413-4432-08dc2e748b6a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E5Yw/sAiNjY5q8syHy3ArTnnc0JGN/eSV2sRZJ4ptloyTqyEL2j/0/JC4eSS94ZTkbOPDw2xszzgZ/oZ73aBiTjKCZKy6ovcVk6idH/eEpNxmYE9thQc3w9hvbyU5fpsLQ2+WLQc7lNQKnvIDQHd2yH5FTymJW2jnXJX1+GBlDhgzWdtUzEdNsXgohnBfVVGvEVYzp1MCGyuEAnkoQGR7lqi5faKjDKUwMI3FIApY7tug0vCSKYPI+9xZsWImwyK7m0ys3ZqmjvFDuvk0/doiRQZLVugX2mgei834dacMda6PFhIA4D3Rofdvvd0kLAEN/E9x9o2l2tZaREcbRJfaCOPmXefYJyWTb1E+WimZIbv1ylTUWlWFs8W/PBaXlW2olaU01tAuWUEw1+fCEUP7qiia+/KLo5TkatTnQB89MAwCzVMcs3IyPPEZ/ZKoilAtcHN4+p+LFvv2zhl0Nwomahi+D9DH7Qlf+ZPYhI6EC37LOvRcjSdMXliQnb9RQdvCwALDj1TjuzzUZYUaBeQP/yPPZvat4gfHVlhCCHvgHANQD/m9XIgtSz2PhnJHr5g X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(39860400002)(366004)(396003)(376002)(346002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(31686004)(44832011)(5660300002)(2906002)(4326008)(8676002)(8936002)(41300700001)(66476007)(316002)(478600001)(66556008)(66946007)(2616005)(110136005)(6486002)(6512007)(53546011)(6506007)(31696002)(86362001)(38100700002)(36756003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDlXcXF5QTdhenVjT0dRSVV0THdRNXpIY3RNeThydmMrVWk1aGFyaHlOTnlE?= =?utf-8?B?eHkrdWVpaGVUdnhTMmRKbzM2WU13V1RIWndFNjBGTmVYUVRCU0lsdnVDV3pI?= =?utf-8?B?NVQralpac0lTbnlJRXJIQ0xWSlZ5M3YwQzZzQkRSQkRZdmFKbTlkYTlHd0FI?= =?utf-8?B?N2NnZTZHK2lneVJzcTZ1RzREcWVhZkJOK212SEhwMU1Xc2ZzaGRONzNicEhs?= =?utf-8?B?TkJpUHhCRmp2RTRDYVI2TU5lbUhRWWNJWUx4eU5GUEswT2xZLzVVM1NYN2Ri?= =?utf-8?B?TGtNZVpTdWF6dEk2MGdGRm5vNDFORDc2TU02cUFtWTlrZzVhOEo0TE0vb2hN?= =?utf-8?B?anRsK0o0d2E2VFFheWo5Yys4dUl4WmpKaUplWlF2cDhGR1Q4cmU1azJBZHBz?= =?utf-8?B?eTZjTktKMzFmSjBTeFJGSmMwREhhcEE5YkgxTmRsb0Z5ODk2RUVpcUZaYllh?= =?utf-8?B?dGJoU0pIeWl1K0p1VnBEUzlaZEVXV0xIU253TnpuVDFIeTBpUGRuK254bUxE?= =?utf-8?B?NlNnd2RMOC9RK01leUc1TmN1VGQzMjZ6S1VweFVpUTJ1S3AzcG8way81Wmp1?= =?utf-8?B?NXE5YXc0SkJISDhvTUt5cHVRTkx3azJSVzNMQTVOcHFQVHJic1MyUEFCVUN5?= =?utf-8?B?c0RaMEJkMVA4OTFGMmZRYWJzQndrV0dtSlg4WlZIbjRVNWk1YWc0SDBtUVJn?= =?utf-8?B?T2pUNlp2a0RybS9kTnB1N0Y2R1lRNXI3bzZnSWI3VC9xd2F5NUpiTzZFMnJH?= =?utf-8?B?M2NnckMzTmJ1RHBZUElmVmxrYkczamxEdlhFQThRLzRobDg5U0hhU2JwZlRo?= =?utf-8?B?ZEJVSFU0bldsZHlzaG1RYm56UVFsYVlNTU5CWFhWTU9tY1U5ZHRNanZXSWww?= =?utf-8?B?K25aWFdBYnU3WExJSEFpcjFTSDE1ZnI4em41Qy90TkxOZkh6MXA4ZkNQOXFV?= =?utf-8?B?Vi9zUk5CdldoM00wS2IvR2l2bWdzT1h0R09sM2ZXbUZKMGI2RXdQZHEyTncz?= =?utf-8?B?UzJKMjVCVU81eGE5eGF1R0JBemZSQjg5VFk1Qkd4em1XUkdKdjd2bVk0Nmp6?= =?utf-8?B?ZU5jWnNOWHhnZ1oybGZkeEtmQTNaVTU4bGlYUTh0a3k0YU9MT3JHOEl3eThF?= =?utf-8?B?aitOTDRLTytUSXRPYUUrQWptZVM3N09ZbVVNQlVDb3orMHJuM2hZd1BDYVU1?= =?utf-8?B?Z2Npdy9iUUFhWjUybG04THlhSDgrWUNlVVpLYjRrNmtpblZoMGVOZHFoQ2tu?= =?utf-8?B?ZDBmK3p2emxxUWNGRFJoYzRldUlLYUlGOEQvRmFZQVppUi9yRmY0MDI0Umcy?= =?utf-8?B?QVJOcngvWVhLTm1MMExPWEJRNGxjWWkya29BenR0SmdyUmNMMDE2QWdhclhW?= =?utf-8?B?UGl4U0NrYVZqdFYzT2xnK1ZLd3NvTlhnWkVrODhXRXRBVVljTjBjTXZ3Vlhx?= =?utf-8?B?VlFQUmlsMzFwb3N0dTFmd1JFc3BsZ3lmVjRkZ0RYcS9yRnhzUWxFWmsybE5N?= =?utf-8?B?ZjhNWnFPNTRGV1huVUxHcG9rYS9rTXJyaE5rWkdwVmJpYXpPME5rRzZPQ2o3?= =?utf-8?B?dU4wdFlBVXVpMFdDeW0vUGhJWXJMU3VuamhJQ01GY0FxWnUwK0Z4cUYxQjdO?= =?utf-8?B?NjRrU0FQeTJlelBac1psblFyY1NBK2lCdW4rakQrK3FGSlZvTWQwZXRXbUlR?= =?utf-8?B?Z0VmdHFLZUJjUVZEdURpWTFVYzBGMENaSm1BWmJ5VStJR0J4SVNRK0VEMk50?= =?utf-8?B?UGMwSGNnNmN6OExKVGt4b29xNkNtVmFqZ2piMDVPK3V0ZUVyR0Y4bGdQVm8z?= =?utf-8?B?TkZoR0cxMmplcUlISURTRzM1cXRsc1l1TldBSHdYS3pqby9ueDMyaHFWYVRX?= =?utf-8?B?alNDQ0ZWelZTQzhPbXdlbGZ2VVV4OVBYUi90empoSXAvWk40YS9qazdPTEIy?= =?utf-8?B?ekhaeTN5Wjk4ODJ1Vk00YzNXcThmdkE4OWtxNStxQ3RBUTdXNUt1ek1NbFcr?= =?utf-8?B?cDlLbTJWNjgwdUxvbU1JWEJBTERaYWtEVElWazVmMkVFMEwyRVpRSUhaRjdn?= =?utf-8?B?aXRaTXJEb1ZjazM4UlVuWVUzeTRMRUNrUjh2VHZVVkcxZzJVMlQ4azBHRkdO?= =?utf-8?B?RU5wYzhJbXY4T1l4b3VJYk1QdGZOS29ZSHhtVm4xR3NJbjltY3NBRGVBUFZ5?= =?utf-8?Q?I6fPBsIDfYxuoqVMAgz7kuk=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: AhklddGIR+VOP3Nv+FRRGHzg2ah7u6QAKCLE9fdyZvfFYVivpHKgDfUrdVNFcP0dOnkvxnEvK52iUxkrlPkMK3CeI2JM/JtVBcCXeTWgX8kwyrcEZgJn8NsgUdDAicyrkrBPnNxy3cR8rjArSxBBumZ6VUUT2NXnsk/JTy3SP07EP9ctlB/tYHQftKMA3CyEEJom0SCadQIlja8q40GeVU1eTdMHrujnuFPTZdc0FycEwYGcPsAH8LHGl2DmYM9LyLsm1lv20FbV74RBk/nJ8HZknzDs47SnJc7UuUPWOFJlMTA0EScNnMZ3oTe7Na8sXp7bnSKzmpBc3gp/UAZppzSbOAj31FKafl9W43mocB/Z0f1ycf5YHOOjdu6LUPy2haWwBGvwIQV3lKjq1IfxHtiCvQY/ObWhsmzmnXPwYoz6wnBF9exZIYtxFqSc5gB2WN4XQA+HYJk00Gekn0cEne9DqFLhdwBd1Iv5vo0JFt50WK0D5lHKtRGSS9e+j1m7V9OM/ra0UMtaFgwIf3sRYLc8fzxG93n65yF7rWv9rUTyzrieD6j0Rp9Bw2UcPFhpzcYuwtLEQ/APyh8wyS3LYnnhyCoIA7woG1yGxqAZfAI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bddba76-1e64-4413-4432-08dc2e748b6a X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2024 22:22:07.1532 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: stu7NhL6vd3HLoTMZVGwV3LaW+mxpyBJCP3os5HbhSEfTVV08KItQLxERZ8Dr+brUWV6JMzHoq7Xz/fnZMmcKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5583 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-15_21,2024-02-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 spamscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402150174 X-Proofpoint-ORIG-GUID: lcD7mqUHC7rFW_-bqDvqiq6UTeQoMjvh X-Proofpoint-GUID: lcD7mqUHC7rFW_-bqDvqiq6UTeQoMjvh X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/9/24 00:11, Jan Beulich wrote: > Consumers can't know which execution mode is in effect for a certain > piece of code; they can only go from object file properties. Hence which > register numbers to encode ought to depend solely on object file type. > > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -5409,7 +5409,7 @@ ginsn_dw2_regnum (const reg_entry *ireg) > if (ireg->reg_num == RegIP || ireg->reg_num == RegIZ) > return GINSN_DW2_REGNUM_RSI_DUMMY; > > - dwarf_reg = ireg->dw2_regnum[flag_code >> 1]; > + dwarf_reg = ireg->dw2_regnum[object_64bit]; > > if (dwarf_reg == Dw2Inval) > { > @@ -17461,7 +17461,7 @@ tc_x86_parse_to_dw2regnum (expressionS * > if ((addressT) exp->X_add_number < i386_regtab_size) > { > exp->X_add_number = i386_regtab[exp->X_add_number] > - .dw2_regnum[flag_code >> 1]; > + .dw2_regnum[object_64bit]; > if (exp->X_add_number != Dw2Inval) > exp->X_op = O_constant; > } On one hand, I see that the suggested code changes are making things semantically clearer, I would like to understand: 1. If there is a scenario where flag_code is CODE16_BIT / CODE32_BIT and object_64bit equal to 1 is supported. gcc passes --32 when using -m16 or -m32. 2. Irrespective of #1, shouldn't we then also use "if (object_64bit == 1)" instead of "if (flag_code == CODE_64BIT)" in md_begin where we set the value of x86_dwarf2_return_column etc ? Thanks