From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2078.outbound.protection.outlook.com [40.107.6.78]) by sourceware.org (Postfix) with ESMTPS id 7D26E3858D1E for ; Tue, 29 Nov 2022 09:03:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D26E3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=StUXHMM/3iefYaoIXgYZJuXwXHUuVMIvE4uCpuyGVtz4sz4M64UXLGNoGQM36cfgr1K0lqK87hONwF67Dar6u9m9h9ZNvzopJPt/K2xYcQXxiGNHmjxdMXu+FGFPTUhcywiB2+pR9fN/0zR9tM2s2ydGcT/knuO7AiOTua3qJ6XWKprmd0cYF1mJxT7u2+tL3RBPPSNgdm+TKGX/biKSM2Gb9eCYWlIE/mO76H7SS425f3g95UH1Zhc5zxZjQi9Oak3nl9BJH9GdPCMeSGh06x+7aQ9t/U9SMOf+Ly0nmDMfpOVPIQIMkjXsEfUACQtG483hoqmu2M1/unEgdxZ2Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nMHYoNrweWkVzR1G1ffc255B4oFQnqaDohHfzF2aWjM=; b=geWDGPoBM+9Lj37yS5swVg+BnzuFz3vGs4wEoZ2cCryQTsIjFGOzDGSNubOkzkl4brQSJ3yU/LvBowYzjfdilKhVbpbwc27aATbXuU5EW1ix+QeFLjifB+X+LyT/H7Y4NQGeCkEBAIH8O33PzVLk6VMVgy9n/NqZqwQ3dxtj97DC6LafF+uUpYQf5uJPUfyfWmyCsA1kp6go6nl5wMZ8bT1wgg5fLbklGF5SXlUDV2tFNd3W7FevRKnGmHlpIQx5PlLE0evhgEMKte3wDC53BH+WebDHxgzUo4AYKqdShSNDLwnLlXEA2Pt9iJIZa0GFOWxErM3yfMbkhyVtVz3emg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nMHYoNrweWkVzR1G1ffc255B4oFQnqaDohHfzF2aWjM=; b=0qzqaI2cmIcHMXdFJENbiEFo7T3NvyCCLR+uUo8dDH/+70JRFb93R01x95tRBcYBCuwszbB28QIKOzDXLSy0pnl0E/6/avYzLy4/fPzvzFEXSLlpRn3hiJODjF5b7mBkQaYNdfyr+02CN140Sjlelo0Bi5V+QhF9+aQigq05WnCr7sbnu9ic3yF5Sj9GzcGDE0WQvtCPmzNI1n0fCTt5K3OD1Dyjc2Ko4upkDzqz/l7WW95aeMlGe3N1iVSDkhwJ/IJaXWEGUqPNmbINRMTuNnamvKQAUsFlYAAElyuMTG+CIVBYZ+gg/DZGxZL1W9TM8IMTsgsJurCp3tc9qp1QIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8772.eurprd04.prod.outlook.com (2603:10a6:20b:42f::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Tue, 29 Nov 2022 09:03:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 09:03:01 +0000 Message-ID: <1636c945-c4ad-9960-abda-b5ff9c240290@suse.com> Date: Tue, 29 Nov 2022 10:02:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 3/3] x86: clean up after removal of support for gcc <= 2.8.1 Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <5dd8b2df-62f2-a551-4b35-f3df66d57e04@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0180.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8772:EE_ X-MS-Office365-Filtering-Correlation-Id: 23a9a042-06a2-444a-b016-08dad1e88462 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nmrHpBE87UzSesiVVe+awF8tCQQzOsn0Tjfhl+6jo7FOzMiLyRmYzJHRF9vGJbU9e+/6k/Hhx08bvl6PkCH4Nmxx+jBO1/Hkbjcy/qdnD+fih9Y6R6XiUFdT19xac+UTxgxDR4Pvmm1/xeK4UPehoJ3EcGkhPdgm2VEhXltWMQc6LjhOLth5AFpbHPwuj8lH9twOcExxIKprDBn9PQ3S5JLOKg6n1WlCCFkuY3YNZjPdE1thlf1onJ+oHKgsPmP6Oi55ycoipKmbbK8aMUjUfFtOfBQd+14PbvLNhOmmoohmtVV3YwuJdSMNycRbZsI1o2zXq3XE2aVgrSsNT3P6chEnSKXxB2htVqvEXglCb3bS0Se3hK+9SxdxqpkBglfRK3GcRWQyqDeQJajvLt+3klDi87XfSxMVQ919Zf0Ktyi2z8Jtwyh9S381FpCsIBf5xlDy6x9CXqIR7kMzJy98SaFK4b3TR7a9yB+dWj7vsZbvDbIYIE/SEp7YxU3D4n6rO9yZv5123BJ8VD7G/kQTk5nzEXE6lWwNZHARIOe1PfNZ7obOTWnVSKwZBrXWbqCeIAkR3semzZAmCi0MC0LnhL5TAi7IOaH+XMjHZ9YXqpZWXdH9/uOozim32nOSJ/3WQTwRdLDv8JS1NEpeQ9jCynAv9waIVLKRKPezsgAuovf20UpdqUWxK2oYFYZqVpoo8vlew7m/Xx3wDoFlPghA1j0Hoz7lb/vjSNI6D34fvsw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(136003)(396003)(366004)(346002)(451199015)(66899015)(31686004)(8936002)(6506007)(5660300002)(36756003)(2906002)(4326008)(31696002)(41300700001)(86362001)(8676002)(66946007)(6916009)(66476007)(316002)(66556008)(478600001)(38100700002)(6486002)(83380400001)(2616005)(186003)(53546011)(26005)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjhBTnM1Z0ZGR0RmKzNCL041NlRPbHpna0ljY2w0NVZaQVJUMWdmb1piY3NG?= =?utf-8?B?SW10Wm5CZjd5SFVhV1ZxMGxvK25qTVNqL1BLd0tXcVpHQUpKMnBUblU3TVU1?= =?utf-8?B?enNFUFZES3pKWFhBcUxoZHhaN2dQazdpQmU5MXBDSU4wZkczQXExRXlsajNy?= =?utf-8?B?aTJCTnBURTRuU0NqU0tScy90OXdwaVBUNFFvZnlRZWVURFRZQXFCdTEwSkpB?= =?utf-8?B?Rzk2YTYrTFE5TXNuQmZ3cEpia3V3SEhnaWttUWE0Y25BbTdMQjZ5RlYzRkhZ?= =?utf-8?B?R3g2b242MGkwU2p5aHd1V1ZPS3lNaGYzS0ZSUENBcDZkTVB2eURQOElzVFZC?= =?utf-8?B?a2o5RWQvbGdpN1FsVGhGcEdEcndoeDJmaGovcnhqdlNKZVR4RWp5S09YOHVP?= =?utf-8?B?V3MrQndsT0EvUG94U3BYb0JnenJCV2Zwa0RmU0wxOGtQZTFFNE9pM2FPNkRF?= =?utf-8?B?SXlaWGhxRHE0cDVYbGNCczBxMjMwKzVMRXE0NDF4NXN5M21wWWN2K2UxNHRv?= =?utf-8?B?NXVraDgxTTdrSHhUcTQxRjE3SFUrdTlqRk10UEhRT1lmaTIzaWc2Vy9TekQ4?= =?utf-8?B?c0hoMjhvUHdLWFp0V2FrM1dPUmVNbHRPN3dCT0cvTS8ybVdKaStoeEhjRW0y?= =?utf-8?B?VWxMY0wxeTVlTTZUNHdOU3JGSVU1Y2NUVVdZbWZoN1k4dlRlRFdQN1VHUmhC?= =?utf-8?B?Ym1RVHM5QUlHSFVDL2lpOXBuWkdUWVExMWJoYS9SOTIwUjF4dmRZKzBlQko1?= =?utf-8?B?bS9xUFRvdzVNQ0dzTmhMYmtCVlg3c2FnR21uTkU2bDRtZ3c5elNxaGIrMDEy?= =?utf-8?B?VGo1WmlJelE0SDJ3U3FobzEzdFhoNnpZSVd6RFNWRVo5V1JiMklUaWhUd25P?= =?utf-8?B?cFQvYmZ4eUZ1akNaMVFCY25ES0ttUHAyZE4wV1BjekFmWVd3UENhN2NPV0o1?= =?utf-8?B?M3pzTEJUZW5Sd0pBTHdBMHFrQUs5eG1QbVdPdjRXdzJtWFpXUmdMSStlMElV?= =?utf-8?B?clpLZmdwTGNCSUxjK0ZrYVAxcVZ5aGRmZTVBWWV1LzRFNGE5d01FZHFhZ3ht?= =?utf-8?B?cFNyMHNDT3JxWTZRZnFHUFZEVGZ1bHpUOFJTTGwrWmNtQXhaaHV4Y2dra2RD?= =?utf-8?B?WTRRVHNRL1JLRXpoOWcyRTlHT1BRRTd2WW03QzJYNWMwTWgwVEZPQkRuK3hy?= =?utf-8?B?Y1IwcCswK0FTd2l3eTlBYmFRVFVPVEU2dVo2UlNPYVF4OEVDcnlnU251NU1Y?= =?utf-8?B?bHkxN016dXljQkxoYkZmRE54aVBqa1d0M2krc2ZRVTIzZklacCtDRjlqUTgx?= =?utf-8?B?dzg4VzZhVlBxMldWcExjelN2RjRHOHAwRmx6SDdPQzB2bDdZTzY3Mm1OVlVK?= =?utf-8?B?Z1ZQM1E2dmozSDNyc1NlRWF6ZklrQzc2eWtQSjAyc1FENVJOenhwRGs3T01m?= =?utf-8?B?emkxODJYQy9LYjVodXhkTDN1bmY5TFZVUFJlQXdNQ1NscnlDandsZlpHVlVq?= =?utf-8?B?VERpbVVlaVBjVy9rVW9vUjlGOVZPbkdOc01YS1E3RHBTYU5zODhmV1lnMVJ4?= =?utf-8?B?R3BZbXloQ090azM1WndNaEwwdWdPOHZRN3dkQVdFNzRNbUlCUHUzNUx6K2pt?= =?utf-8?B?ZTZyL2NpUWlSbzZ1OTFtalRhY0lxMWJ3eVhIdFFQd0pVbmVwYXQwd1B2Vlc4?= =?utf-8?B?dW5WUGZWc2dMaHQ2bU4xR0lycEF6YUROU3ZRTlNOeTRJeEhyMU1XRitEN1Vq?= =?utf-8?B?dXJmd2l2blptODFIdUo5dlJ3MWQyZ2o4YkxXc3M4a3Y1aGczRmV3THdJUC9v?= =?utf-8?B?aVl2UzRTdkg4WVQ1aElQcW1WaTBvRnRqMlhlYW9VaVljV0FoVkE4TlhERmFW?= =?utf-8?B?ZlExVVFpbG5OMnNpT3dxbGwveE9pL1dEWTRTSUJIL3JnQ3ZTZlM0TUxjeTFQ?= =?utf-8?B?UnM2VDdWU0RXVE1kSzRlMGFkNlgrbHdyckIrN2Z2K2FKNU5NUXBxQmdOUjJP?= =?utf-8?B?cndTMmxJa0JvRjNMblh6a2Y5SEtrVU9icGExNE0wM1lQNy9za1hMMFEwNWNN?= =?utf-8?B?R1g2ZmRqcEVNbFNtQVc0ajMxUkYwRXJnOVVucnVKcnZ6RmYvNjhoeFNlb29U?= =?utf-8?Q?quHaWRwHv9AweduX3Vea31YZ/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23a9a042-06a2-444a-b016-08dad1e88462 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 09:03:01.1118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XXD2ctMh2PNRTmdYg8qe3U91B0FVdrEBAjbg+RnZE0FFxC6hqSqneJAIMqzYIECvLYkrS+Z3V7rnTwqrnSZDLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8772 X-Spam-Status: No, score=-3029.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29.11.2022 00:21, H.J. Lu wrote: > On Thu, Nov 24, 2022 at 12:58 AM Jan Beulich wrote: >> >> At the very least a comment in process_operands() is stale. Beyond that >> there are effectively two options: >> 1) It is possible that FADDP and FMULP were mistakenly not marked as >> being in need of dealing with the compiler anomaly, and hence the >> respective templates weren't removed at the time when they should >> have been. >> 2) It is also possible that there are indeed uses known beyond compiler >> generated output for these two commutative opcodes, and hence the >> templates need to stay. >> To be on the safe side assume 2: Update the comment and fold the >> templates into their "normal" ones (utilizing D), adjusting consuming >> code accordingly. >> >> For FMULP also add a comment paralleling a similar one FADDP has. > > Please mention dropping GCC 2.8.1 support in gas/NEWS. For the old release, many, many years ago, when that support was dropped? I'm not dropping any support here, I'm merely cleaning up after that sort of incomplete dropping. And the title also clearly says exactly that. Jan