From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20619 invoked by alias); 29 Dec 2004 18:51:10 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 20561 invoked from network); 29 Dec 2004 18:50:59 -0000 Received: from unknown (HELO palrel10.hp.com) (156.153.255.245) by sourceware.org with SMTP; 29 Dec 2004 18:50:59 -0000 Received: from hplms2.hpl.hp.com (hplms2.hpl.hp.com [15.0.152.33]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by palrel10.hp.com (Postfix) with ESMTP id A0BF4E0CC; Wed, 29 Dec 2004 10:50:58 -0800 (PST) Received: from napali.hpl.hp.com (napali.hpl.hp.com [15.4.89.123]) by hplms2.hpl.hp.com (8.13.1/8.13.1/HPL-PA Hub) with ESMTP id iBTIou0N015883; Wed, 29 Dec 2004 10:50:57 -0800 (PST) Received: from napali.hpl.hp.com (napali [127.0.0.1]) by napali.hpl.hp.com (8.13.1/8.13.1/Debian-18) with ESMTP id iBTIotej027537; Wed, 29 Dec 2004 10:50:55 -0800 Received: (from davidm@localhost) by napali.hpl.hp.com (8.13.1/8.13.1/Submit) id iBTIotUY027534; Wed, 29 Dec 2004 10:50:55 -0800 From: David Mosberger MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <16850.64655.452719.151758@napali.hpl.hp.com> Date: Wed, 29 Dec 2004 18:51:00 -0000 To: Geoff Keating Cc: davidm@hpl.hp.com, binutils@sources.redhat.com, davidm@napali.hpl.hp.com Subject: Re: curious check in dwarf2_gen_line_info() In-Reply-To: <2478F3AA-59C8-11D9-937B-000A95B1F520@geoffk.org> References: <16850.33143.199264.751617@napali.hpl.hp.com> <2478F3AA-59C8-11D9-937B-000A95B1F520@geoffk.org> Reply-To: davidm@hpl.hp.com X-URL: http://www.hpl.hp.com/personal/David_Mosberger/ X-SW-Source: 2004-12/txt/msg00336.txt.bz2 >>>>> On Wed, 29 Dec 2004 10:33:32 -0800, Geoff Keating said: Geoff> The overhead of the duplicates should not be very significant Geoff> (compared to the information that is required), because the Geoff> compiler should already be suppressing duplicate line Geoff> information except where it is needed. Ah, there are multiple issues here: you're assuming that dwarf2_gen_line_info() is only called once per loc-directive, but this isn't true for tc-ia64.c, which calls dwarf2_gen_line_info() for each instruction, no matter what. I'll check gdb to see if it gets any new failures on ia64 with the duplicate line info removed. --david