[PATCH][binutils][AArch64] Fix debug trace build for AArch64.

[PATCH][binutils][AArch64] Fix debug trace build for AArch64.

[Tamar Christina]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi All,

The build with debug tracing enabled (`-DDEBUG_AARCH64`)
is currently broken. A variable that no longer exists is being
referenced from the debug statement.

Regtested on aarch64-none-linux-gnu and no regressions,

Ok for master?

PS. I do not have commit rights so if OK can someone commit for me?

opcodes/
2017-04-24  Tamar Christina  <tamar.christina@arm.com>

	* aarch64-opc.c (aarch64_logical_immediate_p): Update DEBUG_TRACE arguments.

Thanks,
Tamar

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: opcodes-debug.patch --]
[-- Type: text/x-patch; name="opcodes-debug.patch", Size: 578 bytes --]

diff --git a/opcodes/aarch64-opc.c b/opcodes/aarch64-opc.c
index cc99c101236c542ff94bb9c0abc09df521ced330..a52ea70c0093f7daaecfd58e3f0e81a3953abf5f 100644
--- a/opcodes/aarch64-opc.c
+++ b/opcodes/aarch64-opc.c
@@ -1204,8 +1204,8 @@ aarch64_logical_immediate_p (uint64_t value, int esize, aarch64_insn *encoding)
   uint64_t upper;
   int i;
 
-  DEBUG_TRACE ("enter with 0x%" PRIx64 "(%" PRIi64 "), is32: %d", value,
-	       value, is32);
+  DEBUG_TRACE ("enter with 0x%" PRIx64 "(%" PRIi64 "), esize: %d", value,
+	       value, esize);
 
   if (initialized == FALSE)
     {

Re: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.

[Nick Clifton]

Hi Tamar,

> opcodes/
> 2017-04-24  Tamar Christina  <tamar.christina@arm.com>
> 
> 	* aarch64-opc.c (aarch64_logical_immediate_p): Update DEBUG_TRACE arguments.

Approved and applied.

Cheers
  Nick

RE: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.

[Tamar Christina]

Hi All,

This patch was committed as 957f6b39cab6cac0e4c54e650c7f75109544ac1d ,

I'd like to also backport this to binutils 2.28 to fix the debugging build there.

Ok for binutils 2.28 branch?

Thanks,
Tamar

> -----Original Message-----
> From: binutils-owner@sourceware.org [mailto:binutils-
> owner@sourceware.org] On Behalf Of Tamar Christina
> Sent: Monday, April 24, 2017 10:42
> To: binutils@sourceware.org
> Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>;
> Marcus Shawcroft <Marcus.Shawcroft@arm.com>
> Subject: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.
> 
> Hi All,
> 
> The build with debug tracing enabled (`-DDEBUG_AARCH64`) is currently
> broken. A variable that no longer exists is being referenced from the debug
> statement.
> 
> Regtested on aarch64-none-linux-gnu and no regressions,
> 
> Ok for master?
> 
> PS. I do not have commit rights so if OK can someone commit for me?
> 
> opcodes/
> 2017-04-24  Tamar Christina  <tamar.christina@arm.com>
> 
> 	* aarch64-opc.c (aarch64_logical_immediate_p): Update
> DEBUG_TRACE arguments.
> 
> Thanks,
> Tamar

RE: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.

[Tamar Christina]

Ping

> -----Original Message-----
> From: Tamar Christina
> Sent: Monday, March 12, 2018 11:15
> To: 'Tamar Christina' <Tamar.Christina@arm.com>; binutils@sourceware.org
> Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>;
> Marcus Shawcroft <Marcus.Shawcroft@arm.com>; nickc@redhat.com
> Subject: RE: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.
> 
> Hi All,
> 
> This patch was committed as 957f6b39cab6cac0e4c54e650c7f75109544ac1d ,
> 
> I'd like to also backport this to binutils 2.28 to fix the debugging build there.
> 
> Ok for binutils 2.28 branch?
> 
> Thanks,
> Tamar
> 
> > -----Original Message-----
> > From: binutils-owner@sourceware.org [mailto:binutils-
> > owner@sourceware.org] On Behalf Of Tamar Christina
> > Sent: Monday, April 24, 2017 10:42
> > To: binutils@sourceware.org
> > Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>;
> > Marcus Shawcroft <Marcus.Shawcroft@arm.com>
> > Subject: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.
> >
> > Hi All,
> >
> > The build with debug tracing enabled (`-DDEBUG_AARCH64`) is currently
> > broken. A variable that no longer exists is being referenced from the
> > debug statement.
> >
> > Regtested on aarch64-none-linux-gnu and no regressions,
> >
> > Ok for master?
> >
> > PS. I do not have commit rights so if OK can someone commit for me?
> >
> > opcodes/
> > 2017-04-24  Tamar Christina  <tamar.christina@arm.com>
> >
> > 	* aarch64-opc.c (aarch64_logical_immediate_p): Update
> DEBUG_TRACE
> > arguments.
> >
> > Thanks,
> > Tamar

Re: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.

[Nick Clifton]

Hi Tamar,

> Ping

Sorry - I missed this one.

>> I'd like to also backport this to binutils 2.28 to fix the debugging build there.
>>
>> Ok for binutils 2.28 branch?

Yes.

Cheers
  Nick

RE: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.

[Tamar Christina]

Hi Nick,

Thanks!

Cheers,
Tamar

> -----Original Message-----
> From: Nick Clifton <nickc@redhat.com>
> Sent: Thursday, April 5, 2018 14:19
> To: Tamar Christina <Tamar.Christina@arm.com>; binutils@sourceware.org
> Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>;
> Marcus Shawcroft <Marcus.Shawcroft@arm.com>
> Subject: Re: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.
> 
> Hi Tamar,
> 
> > Ping
> 
> Sorry - I missed this one.
> 
> >> I'd like to also backport this to binutils 2.28 to fix the debugging build there.
> >>
> >> Ok for binutils 2.28 branch?
> 
> Yes.
> 
> Cheers
>   Nick

RE: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.

[Tamar Christina]

Hi Nick,

I hadn't noticed that the binutils 2.28 branch and the gdb branch are different.

Permission to backport this to the gdb-8.0-branch as well?

The patch is https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=957f6b39cab6cac0e4c54e650c7f75109544ac1d

Thanks,
Tamar

> -----Original Message-----
> From: binutils-owner@sourceware.org <binutils-owner@sourceware.org>
> On Behalf Of Tamar Christina
> Sent: Thursday, April 5, 2018 15:28
> To: nickc@redhat.com; binutils@sourceware.org
> Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>;
> Marcus Shawcroft <Marcus.Shawcroft@arm.com>
> Subject: RE: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.
> 
> Hi Nick,
> 
> Thanks!
> 
> Cheers,
> Tamar
> 
> > -----Original Message-----
> > From: Nick Clifton <nickc@redhat.com>
> > Sent: Thursday, April 5, 2018 14:19
> > To: Tamar Christina <Tamar.Christina@arm.com>; binutils@sourceware.org
> > Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>;
> > Marcus Shawcroft <Marcus.Shawcroft@arm.com>
> > Subject: Re: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.
> >
> > Hi Tamar,
> >
> > > Ping
> >
> > Sorry - I missed this one.
> >
> > >> I'd like to also backport this to binutils 2.28 to fix the debugging build
> there.
> > >>
> > >> Ok for binutils 2.28 branch?
> >
> > Yes.
> >
> > Cheers
> >   Nick

Re: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.

[Nick Clifton]

Hi Tamar,

> I hadn't noticed that the binutils 2.28 branch and the gdb branch are different.
> 
> Permission to backport this to the gdb-8.0-branch as well?
> 
> The patch is https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=957f6b39cab6cac0e4c54e650c7f75109544ac1d
> 

Umm - best to check with the GDB folks, since it is their branch...

Cheers
  Nick

RE: [PATCH][binutils][AArch64] Fix debug trace build for AArch64.

[Tamar Christina]

Hi Nick,

> >
> > The patch is https://sourceware.org/git/gitweb.cgi?p=binutils-
> gdb.git;a=commit;h=957f6b39cab6cac0e4c54e650c7f75109544ac1d
> >
> 
> Umm - best to check with the GDB folks, since it is their branch...

Ah, I forgot that gdb has its own mailing list..

Thanks,
Tamar

> 
> Cheers
>   Nick
>