From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 893713858431 for ; Mon, 22 Jan 2024 09:46:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 893713858431 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 893713858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=114.242.206.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705916801; cv=none; b=lFPT98mveFDeXrrMd+x3Zh3KCe8IPHOLiU1/FoYfnD5Y3uoS+uWZwonnpE86ZeRbZiwVhdyvOE0MZybHB6h+qGykLHAGLO/rCtAAr86tWMBsXjhuVtiOac1FSGa87v21iNA+2lX6+m6katpNo6OSHV64TfkgyFxshnGA0iY3ZkE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705916801; c=relaxed/simple; bh=DMaKWGc2mBrbot3JSjScp1LfR2MDAeiSMMc2r5S1vcI=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=ReOBKZpEL7/T4n1Na97o3l/ulKKJAh1VH/Y2kbOI4ahtcpK5HA0ugGowmBg1+nIxMpxnmiD/JjriQoW5CDjpqzMjSwLfJG+Z3fKRw/7zev/7qqyT8WYiwWEHTzwPZM9BNE3i/kkAF1CwSKNIW3RcGoy+RHs75E68PnYcnsD7qH4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from loongson.cn (unknown [10.20.4.171]) by gateway (Coremail) with SMTP id _____8Cxrut7Oa5lYIIDAA--.14026S3; Mon, 22 Jan 2024 17:46:35 +0800 (CST) Received: from [10.20.4.171] (unknown [10.20.4.171]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxTs16Oa5l3WARAA--.12773S3; Mon, 22 Jan 2024 17:46:35 +0800 (CST) Subject: Re: [PATCH] LoongArch: Do not add DF_STATIC_TLS for TLS LE To: Tatsuyuki Ishi , binutils@sourceware.org Cc: cailulu@loongson.cn, chenglulu@loongson.cn, hejinyang@loongson.cn, i.swmail@xen0n.name, liuzhensong@loongson.cn, luweining@loongson.cn, maskray@google.com, nickc@redhat.com, wanglei@loongson.cn, xry111@xry111.site, xuchenghua@loongson.cn References: <20231228145802.74719-1-ishitatsuyuki@gmail.com> From: mengqinggang Message-ID: <1757950d-8a6e-d85c-e6c9-28900735af49@loongson.cn> Date: Mon, 22 Jan 2024 17:46:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20231228145802.74719-1-ishitatsuyuki@gmail.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8AxTs16Oa5l3WARAA--.12773S3 X-CM-SenderInfo: 5phqw15lqjwttqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj9xXoWrKr1DAFyDZw13WF4kuw48GrX_yoW3CrcEga y7A34vyry8twsYvwn0qry5A34j9F4xAFnava4DXw4xG3W2qwn5ArW5Ww45Cr1Uta17W3Z5 ur4vgr15Cw4SyosvyTuYvTs0mTUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUbIxYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_Jrv_JF1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV W8JVWxJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_JF0_Jw1lYx0Ex4A2jsIE 14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1c AE67vIY487MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8C rVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8Zw CIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1I6r4UMIIF0xvE2Ix0cI8IcVCY1x02 67AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr 0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU8P5 r7UUUUU== X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,MIME_CHARSET_FARAWAY,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Thank you very much, it has been applied. ÔÚ 2023/12/28 ÏÂÎç10:58, Tatsuyuki Ishi дµÀ: > TLS LE is exclusively for executables, while DF_STATIC_TLS is for DLLs. > DF_STATIC_TLS should only be set for TLS IE (and when it's DLL), not LE. > --- > bfd/elfnn-loongarch.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c > index bd448cda453..64c34e99261 100644 > --- a/bfd/elfnn-loongarch.c > +++ b/bfd/elfnn-loongarch.c > @@ -862,8 +862,6 @@ loongarch_elf_check_relocs (bfd *abfd, struct bfd_link_info *info, > if (!bfd_link_executable (info)) > return false; > > - info->flags |= DF_STATIC_TLS; > - > if (!loongarch_elf_record_tls_and_got_reference (abfd, info, h, > r_symndx, > GOT_TLS_LE))