From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2046.outbound.protection.outlook.com [40.107.6.46]) by sourceware.org (Postfix) with ESMTPS id 70D4E3858416 for ; Wed, 18 Oct 2023 06:47:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70D4E3858416 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 70D4E3858416 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.6.46 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697611634; cv=pass; b=giEyHliZfDea3Pu4AJsljUu5jE6G9YzGW5S108T/PnzeI8iiVk+wUyBc9/tYBRnmbSSli2ms1zj7r5rwR0hrkH/FvAcK4ifRiC8rl8lutI6DCbgW5aX/IBkyRFLI1anGTmfYUtYNU9IWcYZHsUUsRpPAbG/ZuUygHgt3q24Eohs= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697611634; c=relaxed/simple; bh=Rk+XvSBMXKqx4hrPrRzuxNKJK7qQACnYWKo2gxTyobs=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=xeiaWt542MFtuh0HwJl1OGm66MCrMb6Adpc7mPd3nz0FgP5SK0t/hxTDwwRN7xre9J4VS2l0ZFoa13JYIPovFdy9VsZUyuJAgjxVKnHftoDllT4geI4J4nker+MiDxtIKYklm9Nt4GZtK/0WSokYBP9uvCmrVCPKVhEyDelUDTw= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ly2Ss80DZ0ssJM+afEwZe+2F1a/1JoeQVvJNtx+/GaJQL9bXn7PFalTkj36oXM744Mj1oRJ2w96S3IrB+SP2QDcPc8IhtbOPvwAxLihZ3nTanrNdK9/hcghxYsoZjgw5LrPKz4XlxuQAfelw9kICRXj8rfMe1R9jXbdJeCVzygvdDH7J7toIA+EGP34gFjsJ+WnI+yrgJWjl4zgi7tscZKhogWVehdhQq22uFCHNolEFJmlCWU4qEbBf+hdUcDpzubK5gcgNiKBkkHw+oZDi6Kj3eGpXsGi0CSWT22dUM3CNNd0JwUyko2yCRFE96NpjJSh0wijwP66IkyDz8m6rzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GydEQ3wAQ3qAtOGCgh5waPwKJwPGPLMzQqmfEnHanqc=; b=b4QTcE2ZBufcYV1uywqLsnXFQzquJKwlcNcEOBAKcFCRM9aHYrRY00ut7KUcxWwgEMfuM1O+2u8VotzDIlaolkFxywnMbYUjmedPjKZbrT7lvztZ/k6kYn1joD98BVZElUT7kGCXD2vDL39U6M1o+cNe+XM4z/+qbHbWqyMJBjhPndlrpNFTSqfxm+vWpUMmu+nrOB6c5fAfkvwhoGeOVp2RGe6wU0doSxu0CaD1NLBLsaNSrA3EgvYF4YaT5GZcaVoVy/BQ02Be+naNgsVppoZE1SMf++GXUbLcdBYVBxl5CNSdehKuTf2+J/qN5+ygnKQk+67BvAuR4PWJnesPeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GydEQ3wAQ3qAtOGCgh5waPwKJwPGPLMzQqmfEnHanqc=; b=1dTjeNlNaS9Nnm7Q/R4wK9rA2MVMVkZOh1j1RSo01To6e3EdOvP8ORekLXPkX0JPIqr0KZ6Kp+aDcz8SjyWhVRt6Pw4EZ5QW0KKeUgO8hH6uFw36L1kLHLZtMiH/hDDMHO9PAP1niedFPcmuAMVHiuoyaeDXm52nU4E6s/pp2vjjO2OZfNsUn3mUtmg/VxAOzfsWHaRedl5YiCOq3ibd05P5qTjwhoeOqPLi5IEybL76Sb4rFcIxUQy80dePZiNdrFJCpl1vkHZiw1DuP5VDqWZLyMMg2PaQu90M5U+9eEOHvKRUJkEJoLh3+ifczoAFfL3hmN/zog/lEMwGyT+uLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB9764.eurprd04.prod.outlook.com (2603:10a6:800:1d2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Wed, 18 Oct 2023 06:47:11 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d9c0:d907:4d2d:15b3]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d9c0:d907:4d2d:15b3%7]) with mapi id 15.20.6907.022; Wed, 18 Oct 2023 06:47:11 +0000 Message-ID: <176bf162-764b-e103-2985-f1d5ffe3d869@suse.com> Date: Wed, 18 Oct 2023 08:47:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/8] Support APX GPR32 with extend evex prefix Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20230919152527.497773-1-lili.cui@intel.com> <20230919152527.497773-3-lili.cui@intel.com> <9c3a051e-d7f2-26a7-8013-9b0081a54023@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0142.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::16) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB9764:EE_ X-MS-Office365-Filtering-Correlation-Id: e56ea89c-7b94-4150-b1e6-08dbcfa60dfd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nCYMLQJCZhuZNBykE+mL4sLLC0UPkg4Eil/efggTkd2B4jWGCOk+coIvDrmYXVxcTgZCe76mtQFXLKnURFGZCzo6jPMthJq5tJy9ibqx1knRWjmVWceKxZOjd+4Tc+FaDWeA3MDh2ec2ILiL1M/oSp+DpAQ2iBS8U5jGzhG7gyvbvRlrawAmOaHaX+c0ddNu96A7NwU3/Zsy4n1sigxuinEDvUcJCbaEv1aGlgpSmGprmwixRCBrPSxu88uBbHk+ksLGKJFDxSwp52I6RAnx7bQurCQO2lkkZZn/Crgs1nbrCqv/rWuUY0VM0cLjWO4PL7hxCUVw5AuYHdBIBLHuepWthHkslJhqZCHY6yEWRoUdHSOFhPI9eJKW/xTax0SkwHHKtEy5U0rHfiAGqc1JDuRofZiX+IbMkPMENXHRwWWFzHVeB0LcGsrzzSVOwCXGNgOkAxF5iXSAeuSG+AQaHqcFHuOiZPjOJNx0Ir5vEstMTH8pipq55HkhxmmLTH/dMIwvmoXTj93FXDHIDlPfyHprtZRMrl5LvZfa6BMGUJJVhysmW219g9djOvkKeaz3GbC7zLFcpn58XKJZ1vhx/GjTHjZn+uzwk6lwg0G9yX4K2ied5VSk57aQGVT48jI9+xRHT3E/DDeNsSBdXZFn68acdh9RtrQjLjtq1KrNApk/WSLDjIYnC1xLG+neK5NJliYBMwtL5E1yB/AVN0NWRg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(39860400002)(136003)(346002)(376002)(396003)(230922051799003)(186009)(451199024)(1800799009)(64100799003)(86362001)(41300700001)(53546011)(5660300002)(8936002)(8676002)(38100700002)(31686004)(31696002)(36756003)(2906002)(54906003)(66946007)(66476007)(6916009)(66556008)(26005)(316002)(2616005)(4326008)(6512007)(6506007)(6486002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGg2NXRYSFQ2Nkx0cStRVWlROW00NnVIQ3hNYldHS2k3dUZpb2FtdTBjRWRK?= =?utf-8?B?RmRLQ0hlNG5WSTZoZlIvMTRqUUpONWg3aTF5ZzlJSHBIU0pYU0FvMTdYUWRV?= =?utf-8?B?ZWpVWE51bTlOaHlVUzlhK3JVT0o1THJOeWd4VW41WkRCSVUwRzVQV3pFYUJ2?= =?utf-8?B?R2FLdUNpODNFM0hTR1BzQ3A2ejBzZVZrK3RPaitOR2ljNlpjVjNYRC9BTEhr?= =?utf-8?B?anJGbWxuUEliYllTV0ViaDVaT3poYi91a3RwcU8wdTYyejB6RFBtc0dQaXdL?= =?utf-8?B?UkZWb3d6ejNGNjdWMmpQVjB4NDhzVEpUOFZBNnRKUDJKVWtQRGc1emxWWDZ1?= =?utf-8?B?R2JIc1RyVWMwRGVUcHoycm5BbW9KMFMwdzE2NDVrS1RENVFhZFptSWc2RThB?= =?utf-8?B?ZldXREp1dmVEMGdSdUlMQ0paTFVJKzlEVmRvU3A0VWdqOWgyWWFhSzJXaXl5?= =?utf-8?B?WXBNODVNMmRIYXVXOXlHK0hJQS9tVEkwYm1oNW1IOWpNVHdLODhzR1pIOG5j?= =?utf-8?B?RytjdVVpV1ZvdFUvUGk1TWVxcHNTd0hCZk5qS1pRRVQzUG9aQTRiK1RySlVj?= =?utf-8?B?WVpFRE53RDgxVWNTbnN1cHRMZWJuSWhpdHErYm01ZnJERHZsWmlma3FFU0Rp?= =?utf-8?B?WkQxUk1tZDZUdVlXSXN3L1RYMGJVdUpyWVNGcG8vd3ZYZFlZMFNwSlRUcVBV?= =?utf-8?B?SEk3d3g1SzVtSmZRWklKOGUyT2I1SDNwS09HVTUwWU9SRldjcm55L3ZPaThm?= =?utf-8?B?S2RuV2VWY0hFWGNHamFRSHhBV1JMU1RjRzRkcWVVaHREZUFkcDI1RVcwU2Jj?= =?utf-8?B?dzJZUFV4WjVUeWN6dFh5SzVLcXRlbmc0L2U5RUZTd2F2UFJjNDBGNmNNZzAv?= =?utf-8?B?d3JhdGNyN0t4NHFKQXNiUlFUdHhrbnEvTXVYMGpSSk5Od3VVQ1FBUkRpMnJh?= =?utf-8?B?cnUzZHJGUmN4YWIxQUoxVDh2dWt4dlBsOHo2UGRSVVJaWklWZS8xVEtmb2VI?= =?utf-8?B?WFByZlRtVzZLUVFoSjJDMUlZdFU1QWt4ZFlINVB0Vm5lbG9BTEh5U0QyaFZC?= =?utf-8?B?MHkyaE9LcWZ6UHkvQ2ZSK2lNRWlDazkrKzZBdEZhcWN2Y1gvWlczNWpJb0lK?= =?utf-8?B?djJLdWZSS2ZaVzZzMGNjTmlxVDdPMDNUcUo5UUQ2SGZlRmNiYVEzc0o1TCts?= =?utf-8?B?MjRhbDQxdTFMSjV5cEIxQ0didzYzUlF4RXZUeHNUM0FmRFMzQ0pkSTRVc0Z6?= =?utf-8?B?L0J4Zjg0WHZLKzlPbmZvditsNUpmZktQdno0RDdGYnE5Tk9UeUFIT01DNGw1?= =?utf-8?B?Qk13RWM0VWZWL1dJVGlwOU0vdkpFVCtGQzFzbjlTbUs0MW9vRHR0QnRhTUZL?= =?utf-8?B?YWdOMzZvcjBOS2JxNk9jR1kvQ3gwaVZHWmllUjF4MitJeTl4YjYwVWg4cUFS?= =?utf-8?B?VzNCM2htUjFWVndBNVZPVGJka0dYb1ZZWVpqczRoU2RUNm9SVnl4NFFKSjN0?= =?utf-8?B?aG1CcXJNbUttRklRdEZyRTFTM29sUERBUTdRNDdpdGFCQU5qQTlySm1RUlMx?= =?utf-8?B?V2hFRHdOUWlWeWo3WS9QRkw5SzkvVTdEM0lsdk56VDUwU1ZIdXZQaDV4TE1B?= =?utf-8?B?OFEyaVQrV21FZFRhZy9Eekk5c2t1RzVqaDRzUk84Q2p2N0tjeitMMVNzckNH?= =?utf-8?B?cms3bEtKZlcvT3hGajVNZmRaalhPOTBlUFQxekhkYzY2bmRBcXI2KzdzZU1W?= =?utf-8?B?eXpmZm5SQWsyS0NpTXZSY3VIT1lBZktvYmFZVUNVZHNnbEsxdzFvS1o0Y09M?= =?utf-8?B?a1FSNlNPWUQ0UWo2WWNtVmJYM21VU00ybzZNSDFLaUNmS3dGR25DVGwyVzls?= =?utf-8?B?UzUxOG81SVNBdDFIRm9qNGQyZmRBRkZPK1k5TFRNRnV1U2xnYVdndXJ0YzBy?= =?utf-8?B?S2Jrd1d1V0piZVhwdnZ5cDhsbVFZS2piUkdBcU90YTVGSFVCZFZ2eFlVZCtQ?= =?utf-8?B?MFJQUUdMNiszTlVucmx3YWJZSTFFSDgrSU5tZ1cyMFdIT3hVL1JlS21YUTg5?= =?utf-8?B?QkRyQXpuaWUwenI5bEpOWnlrUXUvc3lSNkcxTXM2czB0eU80NVhRek1DSWcy?= =?utf-8?Q?tASmzH3UWkLLjk3VWX0Ycc7wu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e56ea89c-7b94-4150-b1e6-08dbcfa60dfd X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 06:47:11.3118 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bpaw1cGnTATGrP4nJ7Oo6N49zugocfkYEQVVo1pEqXxDBl3bXO1e5Li+VWrp7wd8o0RUi2z3giIyWPMW4ERu7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB9764 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18.10.2023 08:31, Cui, Lili wrote: >>>> Similary I don't think I can spot anywhere that you would check the >>>> other bits which need to be zero in extended EVEX. Nor Improper use >>>> of EVEX.x4 in certain pre-existing encodings (S/G insns at least; perhaps all >> others are okay). >>> >>> Sorry, I can't get you here, what are S/G insns, could you provide more >> details here, thanks. >> >> S/G is scatter/gather (i.e. AVX2 and AVX512). >> > I think you mean EVEX.V4, scatter/gather has VSIB which needs to reuse this bit (EVEX.x4 is EVEX.p[10] which is fixed value 1), > For our current code we will reassign that bit and now I changed it to check the upper 16 registers of GPR32 , do you think it is ok? > > @@ -4252,7 +4252,7 @@ build_apx_evex_prefix (void) > if (i.rex2 & REX_R) > i.vex.bytes[1] &= 0xef; > if (i.vex.register_specifier > - && register_number (i.vex.register_specifier) > 0xf) > + && (i.vex.register_specifier->reg_flags & RegRex2)) > i.vex.bytes[3] &= 0xf7; > if (i.rex2 & REX_B) > i.vex.bytes[1] |= 0x08; First of all my comment was disassembly related; you stripped a little too much context for this to remain visible here. And then I think I did mean EVEX.x4 - as you say it needs to be fixed-1 in e.g. S/G insns, and the checking thereof is what I'm missing. Jan