From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from va-2-38.ptr.blmpb.com (va-2-38.ptr.blmpb.com [209.127.231.38]) by sourceware.org (Postfix) with UTF8SMTPS id BE6CA3858D20 for ; Mon, 13 Nov 2023 03:22:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE6CA3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=oss.cipunited.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BE6CA3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.127.231.38 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699845733; cv=none; b=aVlpEJnLB/jboQOiTLZ68QZPc6pZPewh5vxTo2FWpDyr1JIrB/tG0NZFvvNvSK5Drih0eebSiA1yNflZEgExd4/gp5debUsql6KN7WjSt20IXbAfIkPp7HL5bKKqw1ayZnAYp8P124GxTwX1wFw2ZSXcYKOPVTm11Jgf3nHIaD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699845733; c=relaxed/simple; bh=hjbDPH/l6VGEH5Ld82Sx7mwmUIS74hkUL/dRPJ6WWSA=; h=DKIM-Signature:Mime-Version:Date:Subject:To:From:Message-Id; b=jbpk3VIzlhrlOfinc2/0/p+zF/9ZOgt0SNpdohc812ZgxgeP8/okfRxuWq7faCLu+5BHkb4D0Udm5/umir8tNXwEHoXpXtk4AGU265rHcM8dhROgvXLPlbaH2qi/G+UqG4O54Uuf40b9vhfC8LShWAz6nnYCW8oQI+Nc1LM1vtE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2303200042; d=oss.cipunited.com; t=1699845720; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=hjbDPH/l6VGEH5Ld82Sx7mwmUIS74hkUL/dRPJ6WWSA=; b=4hIKDvtQBN8APPkUNz41Fs8kyxa+2gxOyA8axjnZ5Qhj+rU2DF6UkqaMQe9eNkKLk50yso LcjxzH4VrE/Q2e5vvseiz1BVTCcJH34AKmL2F9pGj+LpPaF2R/DRvvulohvWHlmddSAhMQ sqyyAvosx69VnKI88ZjYju+TpprLYXW2wT0ogv9wXruq+ZOQd1x3csvwCyviQsUuFenXbd Oxkkkx/MYRe9aijTRFPKdVp2C3JgO+nTevfl6CsMVeuWxKZTUCQdqswlqc8ECMPNWTb8q+ bonPdXfLqYZKjuHnIyGczmjgcy7/l5OMl1lBwYbtmrTzZP+DI9GxlMX5zMT8OA== Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Content-Language: en-US Received: from [192.168.8.150] ([1.192.16.206]) by smtp.feishu.cn with ESMTPS; Mon, 13 Nov 2023 11:21:58 +0800 Date: Mon, 13 Nov 2023 11:21:58 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] MIPS: Change all E_MIPS_* to EF_MIPS_* X-Lms-Return-Path: To: "Nick Clifton" , Cc: X-Original-From: Ying Huang References: <20231010063635.2800937-1-ying.huang@oss.cipunited.com> Content-Type: text/plain; charset=UTF-8 In-Reply-To: From: "Ying Huang" Message-Id: <17db8e54-1651-4ad0-b7de-7846211935d4@oss.cipunited.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Nick, =E5=9C=A8 2023/11/10 22:12, Nick Clifton =E5=86=99=E9=81=93: > Hi Ying Huang, > >> Ping, > > Sorry for the delay in reviewing your patch. > > >>> Now MIPS has two macro definitions for ELF file header flags, >>> respectively E_ and EF_. It is difficult to decide which style macro >>> we should use when we want to add new ELF file header flags. >>> >>> We can refer to this message coming from the lost world: >>> . >>> Clearly IRIX and the Linux kernel used to use EF_* macros. >>> So we should use EF_* to keep same style with the beginning. > > I agree that having inconsistent naming schemes for the macros > is annoying.=C2=A0 But I dislike the idea of a backwards incompatible > change.=C2=A0 It is not only the binutils, gdb and glibc that use these > macros but other programs as well. > > To that end I have amended your patch so that the changes to > include/elf/mips.h and elfcpp/mips.h also keep the old definitions > of the constants.=C2=A0 This means that other users of these files > will not have to change their code unless they want to. > Yes, your consideration is very comprehensive. > > >> And we also have submitted this change to glibc. > > You will also need to submit the changes to gdb/mips-tdep.c > and sim/mips/interp.c to the gdb mailing list as these files > are not maintained by the Binutils project. > > OK. I would send to gdb later. >>> bfd/elf32-mips.c | 4 +- >>> bfd/elfxx-mips.c | 224 +++++++++++++++++++++---------------------- >>> binutils/readelf.c | 76 +++++++-------- >>> elfcpp/mips.h | 74 +++++++------- >>> gas/config.in | 6 +- >>> gas/config/tc-mips.c | 10 +- >>> gas/configure | 8 +- >>> gas/configure.ac | 10 +- >>> gold/mips.cc | 168 ++++++++++++++++---------------- >>> include/elf/mips.h | 74 +++++++------- > > Approved and applied - with the change mentioned above. > > One other thing - your email program appears to have mangled > the patch, removing lots of whitespace.=C2=A0 This made the patch > impossible to apply automatically and instead I had to apply > it by hand.=C2=A0 In the future, please could you supply the patch > as an attachment, rather than inline ? > > Cheers > =C2=A0 Nick > > I checked the email sourcecode of "[PATCH v2] MIPS: Change all E_MIPS_* to = EF_MIPS_*" , and found that there have two types of contents, including tex= t diff and html diff. And I try to submit it again using 'git send-email', this problem did not o= ccur again. Next time I would checked again. Thanks! Ying