From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2082.outbound.protection.outlook.com [40.107.20.82]) by sourceware.org (Postfix) with ESMTPS id 14C54384D14F for ; Thu, 6 Oct 2022 08:22:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 14C54384D14F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GlXZZYSQ0b6A6f+zbLchv7/3KuFINk/ebLF7YucfV5AovRoSxBgqZJFUNaXH9ne8adCE+Qi5psDmmHdpv1hL4eirx1TUlRZ0rsmcZvy+htqQjatcOuZveHmEyyYf+IgsuAgyaEEAr125BHpv9Gcv08VCQmw0npRQZFB/Uufu2+ShEykJP8cOKiExm4r0pBwQt82nqtTC7/T0LPBAeUh99C58VIbUaJual5u/Y+AS6v34pt0vZNu2xl88tZJlDSIXddRyw96TZOqkkqgQoLyGov+luCMfs/MoQsw2XyKcuC5P2rIujun5hSxbujwXMmaqwMRdypVri3q3uQJZhv0KbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z/+T+HbkIbN2zCBZZNtVOMH7rjq/7YEIG6LSfHkTo0M=; b=DYVeoPjVdN2P6zGj6Nf2hcUD6gL7eFmhguApqf0vzjACtzCEop+ygwM2of41cXH6nNPfGJzbcvrSPhmFRfD8RjPaF03GPRDuCn9WYfx6PoOANw8Z0SZo2bZCQQAj7LGxWjvOSyhGLJWf2PNZvdjwP/LhgnLM4+DOkbtX6+wCOynqFCC8Vf7oHXaWQjGn3H+5zS1HpkUtwWAdvRAbAtRw02I7hpWt/qewAO2ckE1G8hUEzzF6L4Dtfzcz8rECNFxN4PIlmUPxyc/zF8yYjLC2w2ZtRC1rOdY6syP8ivZxO8nunPfPLRpfA0Hv0jJoG8JcByF5f+yF9FOFzsu2cAyVIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z/+T+HbkIbN2zCBZZNtVOMH7rjq/7YEIG6LSfHkTo0M=; b=Z/YW0yIMBD3wDCTbchMqJ24cgeihGL3n4dKDNrWe5LlYEpzhkNqtlawbLLcOolsvIJrHQOgunrbbUwHHk4GceL+sr1aejVjkNWikLbNd3cTnO46Pm1VnWbE/Ct4+4TVsFlsmpc0ssVViBNCGZh1GCDdrei/bau+vIDntrp5j2LxXaT4gdEhOGjh2pnHgARXans1mhIXgJOaINkFfO8eRXjY7Yvi/aV3FlLhVT7aejVv0OXeOjNtt9rYXISurXGNebgW5Yp8tUEEJDA5P+ftInQHxCpV2Q/8kHNTJ/j2D3adlkGA8jjz32Nk8WOn4RG/mE1id1j22dGo6yPJKT9QPPQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8105.eurprd04.prod.outlook.com (2603:10a6:10:24a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.34; Thu, 6 Oct 2022 08:22:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.034; Thu, 6 Oct 2022 08:22:10 +0000 Message-ID: <1834abf4-a48d-8712-f4dd-cf8434a009f7@suse.com> Date: Thu, 6 Oct 2022 10:22:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 1/2] RISC-V: Fallback for instructions longer than 64b Content-Language: en-US To: Tsukasa OI Cc: binutils@sourceware.org, Nelson Chu , Kito Cheng , Palmer Dabbelt References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB9PR04MB8105:EE_ X-MS-Office365-Filtering-Correlation-Id: b804410e-a5c1-4552-139e-08daa773dd6f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LiUwx78WSXgxmV+NrLucJquFBbGe7QHjnTENwyv72vwmH4Db92TNHvF7UpUCXzHcECNCXLC5yRk0fSJXatoQFWiDi7P7YLjNOr0AY6WCy8Ptsqocg4+IFyF9VTKhw6RZ+hFVmh+ddIvVw5jiywf2/dzn2YQQXXZ0d7Y5vqt8sYZLzSvBDL+1oG7Pf+4Pp4hpmK3b+UEJ/j0LMrX0djNgleDQuwpeh7nADh3eFLVG72rpPPocDvJcdFIKIR81es4qOWcNmEsukZbvppgEsoyPtZtaoX/+F7WGeEpouG7qZhYbR8K4H0zodJ6/iWpvYrA4V1CnAuULuGUdvjiZnx6R/1xBmdtWQahXK/T89t0qxSKd7ra/0jlie1XzLX6VD2sHOqoREG4RMz+cNNYCbwZHc7RUbZhi2gbFEg+1bIui30kfhwVToUvmCB1WCZsnwtVCBSmhAjkpdXy3KmVT+lWEVql0YBqR9D7KwNzgEFvtZouAaBJTHgmIpsgA+eNbKvHqGviBjKuws2ahtcdPBF11DYiMQHhJ0PWDyNaS6DheGIP/G1wZ5EpLXdWz0WUj+lhcTWERSCIUo2wXI2otZmNMZj4SADzVDM2WYtHAmfkLeCf/W4sDMXzjlqszOQGnimMk0m/OkECJDp58GHHWDkfQ6OEZxxO52qqANpDKwCnQ1SSCe08nlCWq3AZqr/mKKYvkAXyPgKR61XZQG9jx/J0FvX+1bakz6wBY19p1lr1iY/u+cGX5tn8DI2Pc3WxTCSc9Cg1Ya1ASZLObEGkD9zrzuHYI2nUkfhS5KtAWd39X3XvdS4nvdqUv4sZ8goLGgZoRDWW/x8wlD1/U8V0Jdgv/2A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(396003)(366004)(346002)(39860400002)(376002)(451199015)(31686004)(478600001)(8676002)(4326008)(186003)(66556008)(316002)(2906002)(2616005)(36756003)(4744005)(38100700002)(5660300002)(31696002)(86362001)(66476007)(66946007)(83380400001)(8936002)(41300700001)(6486002)(26005)(6512007)(54906003)(6916009)(6506007)(53546011)(148743002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlhsY0tSeVVTaTFYMVgyRkZWSUpXOEpDQUhocDNCcjFndGo1SE1MQThndjFo?= =?utf-8?B?Yit3UHEzODBiK0YzSDdCcVFEcSswdjdhc0QrVFo0MFErZERtb0xsRVpORStG?= =?utf-8?B?UVdEczRzOUw1TXhvc0JTMzdVdWdFS254MzJJenMzZmRFMWhsdGE1WmYxMGtS?= =?utf-8?B?Qi9mQkdKb2w1cjltS0QzOVFuMW1LaHYwbVhJendKMjhZdVNUQ0hFcXNFN2Ni?= =?utf-8?B?VVZwSmRCTzQ3c3lPa2NsSnF4bWZEOEQybFZRNnBSY0d1M05NZTNSeFROZTNT?= =?utf-8?B?Mm04L0dod0pkazMxdGVTZ1lVaXIyaHNLN2xTR3FaQTdGRkZJQTdkL3lxK1Vu?= =?utf-8?B?RHRMNzlrWmwzS2pUbzBDMlNnNzBhenBTNy83S01CVzNkZTIwbmx5MXR0M2hp?= =?utf-8?B?VFIrTUFaLzhhVHJDN1VWR3BCaFNVMzBScWNjbWJaWVh6dmMyRWlaOCtwVSto?= =?utf-8?B?VHV6VmkrSVRraEdBUlJLUDVoZWtIWW00RlA3SUFJWUVEQUo5cnBwUmF4L3Y0?= =?utf-8?B?RFdrUmVkYmFtR052Mkk4YlA4K1UvOE9ZbC9CTGt4K1hxTy9ub0lFN1piMEs4?= =?utf-8?B?Yy9UL25taXBZaVh1eVQ2RndYblNjUGtKbis3QWZFTzVoU2k2TjBHVzlCdnlE?= =?utf-8?B?TXUyc21PbXZaK09ydHdXblR4VDEveE9KUHZoMWYvbmRFZ1N1TnNVaE5zTVV0?= =?utf-8?B?a2tOTWxjZ1hZemhRRkRVTjVRUnVYLzczZWtSbkM4ZEROZWMrNDkzaG9pakZz?= =?utf-8?B?SXlsQjVYSGRMZEpBcVJpbTRHQmdCemVnS3FOVk90cndrVW1iQTZQUFBRME15?= =?utf-8?B?RXdrZ2RnR1dZUXZYL25ibjNKMU1tbTU2cW1mN2NMUTJYZFdsa014eWd6TXFE?= =?utf-8?B?MkhBMWIzQnBIYU1USzRaSzRxczJqbHNSSVowd21DUjFjWGl5dlhObDRkVWtG?= =?utf-8?B?Vmg1bUNMQzd5QllIdDl6M3ltRDNDMmg2VG9FYUlMZFNyYU1ibzE1OVRPQ2wx?= =?utf-8?B?VGpRazV1RmVuMU9yR0FZVFJmTTV3TWVwSTlGd1Q4UWtXR0NkOWdyWFFjSWNX?= =?utf-8?B?cy91VG9XcGl1ZVZHZXVqemh0Ui90NUtKa0I2NjB5VGxZblcyQ1BNekZNR29V?= =?utf-8?B?cTNaTmYyb3R0bmd2UHhpWGFOeWhrREtLZ2xMM015Sy9Hd2FIMUVwNzNydHo4?= =?utf-8?B?bWF6aFY4YlorSmJReS95NDFzMHd5Y1BTVUJsOEpWSjFQZ1p4MHBTMks5ZjZj?= =?utf-8?B?MHI0ZXdOQjRvTlRHWDAxNFZNSlhEUGIxNys4MDVFY2w1QzdaaEw0RGJMTklM?= =?utf-8?B?WmNla0orZGFib1hjUnlZdlJ1Tk9Qbml0S2wzNUhNQXVtcXBmMTk3S2UvbW5N?= =?utf-8?B?Yy81dHJXdGN2MjRjZGw3MUhqbHg2M25ZTmx0dmVhaC8wZnExcXkyYi9nWGV2?= =?utf-8?B?NERaY1hEaFd5ejMrTGxPTmNOUkVCbjFXd1ZFdHlBc0RGblBoYm5SaXBTZjBs?= =?utf-8?B?ZVErUUloNlBxbnVpZXRSWDllMW5WY3Y1YzNsRG9jaFFBL2hBR0Rmd1dJRTkv?= =?utf-8?B?R01rNU16bjJKVStLZFRtVDRiTXkxc2JqN2xHQ0U2d2RheXNTRjlFVEVLVXg0?= =?utf-8?B?NGg3M1lzdWhBY0Nic0kwK3JVZVVJRWJHdGJ1ajM1eGRzb3pYNUhRZmwxSTlT?= =?utf-8?B?MGpqdlRWVWFoeHhXU3hIK3R1eENEQVFyN1hvak9WUnNHMUdxUEp0eUxFZmhx?= =?utf-8?B?QXVYY2VaOE1KZWtZL0NIamlxUHdudXUzSDdiRzhYNE9wWjRqR3BWUUhtUkxl?= =?utf-8?B?TGFVMVUvYng3aHRCUXVPMStDWmtHd0s0WnBGZDd3anE0RVZxM3F2VWFWSzRz?= =?utf-8?B?UFZIOWltMG8zOGRvNVFVQnNxNVk1UTNaRmFUZ3ovVHpNZUFsUytQSjlLN0lk?= =?utf-8?B?dmRVU1AzVHJ5ZXVjMnhDNXlTNXB1SklsaUdOYkFLRFVNT2hDdU9jMFpKdE1U?= =?utf-8?B?NmwrbEp6d2dMUThKTWF6MXM3YW5ZVWFsWVdlYXk4ZWNOT0FQY2FXQkxGN1FE?= =?utf-8?B?L0NVMk00b0cvdHlTekVxOHQwMFIzOHJyWTU1MURwOHg1S3JWdG95cmxoTzdy?= =?utf-8?Q?aWLoq26TPLbrcPRu+lzhAK0I0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b804410e-a5c1-4552-139e-08daa773dd6f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 08:22:10.5874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7AMJhvPs6r/4O/e08QBHmPmXf/r553xlwSzMEtmPyoORT6qcvWNH1H7jYCzpYHy9EsD0fhfpaHJnHy2iRkgHzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8105 X-Spam-Status: No, score=-3030.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06.10.2022 06:40, Tsukasa OI via Binutils wrote: > We don't support instructions longer than 64-bits yet. Still, we can > modify validate_riscv_insn function to prevent unexpected behavior by > limiting the "length" of an instruction to 64-bit (or less). > > gas/ChangeLog: > > * config/tc-riscv.c (validate_riscv_insn): Fix function > description comment based on current usage. Limit instruction > length up to 64-bit for now. Make sure that required_bits does > not corrupt even if unsigned long long is longer than 64-bit. While I agree with the code change, I don't agree with the adjustment to the comment - you're changing it to match the sole present caller, but imo such a comment ought to describe the behavior of the function irrespective of how it's used at any given point in time. Jan