From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2058.outbound.protection.outlook.com [40.107.8.58]) by sourceware.org (Postfix) with ESMTPS id 20A93389850A for ; Mon, 5 Dec 2022 11:16:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20A93389850A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ctiz//RAPAzibqJTOsRcUnQmG4wyQj9Ft63epiKpM1UbgSUwGx6X2sBrWOP9hCanfWkoWmQIm0l6m3KNQnMqclJ/sqEoXGO7gGAKxJSsUBtLAaGXjyWQa51PBaJtd5JI+c15aIR7HqqNEf+MTGLLLbDxDA43qVpE2eofQXPys7En3rJKGkBsx4CFCGIsolmFxNucXiA8qlxjALuSWIJm9887OhOhFqbWHWODOxQaQbf5nx4BWtCwGKF1nDM9i2FLDOuySYcf2hcDWqEH1CTdhnNC5BNanqOaJ3criW/y+HIJQ+UjlHf/uQWNHxmS4BKtB3hjpLyNrlCdxWfEdJFQ/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/iZgT45edtngtDkr1BGBJQmd6lFtQUsZUI+24b6jirw=; b=MxlkSrsnOZPEXwT2mxLnnhYUt/EtJe0/a5mmQleRndFdyGRADIHQiYfYYAOJEcByYfw+j+CXfNKYfHD8C2jHKlO5zFeceZ8k8pZwD4eaESfHLn4Dr6J/NhRFfPxZkhgUXvYwpmaZnzWhhqB+7QVBKF4YGYv4wxYtY/ze5OIbAqXuFMeR1ww3E8/+qf/BVrNsabxgQw1tZOhOr/0qD2S4RhTht3NcAv01gG9PR7bEabdJYfMQOKuDpQT9f5gKk7eq9AScUedyy0niFuxEpHb7w5s0XlXf7fJW4y2XVlE9Dra08M/y3c/JaZGxRMJgpaSUFxIc1nL5UPLyhFtoY47dvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/iZgT45edtngtDkr1BGBJQmd6lFtQUsZUI+24b6jirw=; b=1ezjG+Q1Pg85Gjzp8APt280+RwaNMJfD+BITcsDHfOwsOTsEwnKm7+CgfsJW5kPneHupEuKNj6ALnz9/pN5TR8sAdQVeTGJoxT2qob67LdjEZkBMojZXN/aQ9eOw6DtPCKR0stJOk+GqKZQdePzKnHsqvXIl79g+48GNDnjUPcfVbPjMNijIczhrP6otCjQU6yXkZOxbZLwNYYSFySAqkJur3jmCvpKD5WRcPIRBLzKk3LhWfa79ywF5sB6f9UFFtSa9NrH5ZMQX5eYrNKWlODV9qMkxx9u3s78nDGm/RnWhkAhBZJGdTWdx34QqsGBg8esLbEQUdkdYWsvAqJdozw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8926.eurprd04.prod.outlook.com (2603:10a6:102:20d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.11; Mon, 5 Dec 2022 11:16:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5880.014; Mon, 5 Dec 2022 11:16:04 +0000 Message-ID: <18459a42-b4a4-00b0-b00d-04ce01b1de34@suse.com> Date: Mon, 5 Dec 2022 12:16:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] x86: Remove unnecessary vex.w check for xh_mode in disassembler Content-Language: en-US To: Haochen Jiang Cc: hjl.tools@gmail.com, binutils@sourceware.org References: <20221205025311.73743-1-haochen.jiang@intel.com> From: Jan Beulich In-Reply-To: <20221205025311.73743-1-haochen.jiang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0030.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8926:EE_ X-MS-Office365-Filtering-Correlation-Id: 5cd0777a-dd60-4b7c-2ae4-08dad6b2190a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j9F4nFqgryUUEew/5jmeaY6AbDXg/CZ+3IExnxE1WGEzQ3cqAMYrcBKfHMPW9tjtAUhHSQImdPTNlecnCnh4KiR+cuN57CC5eLcjRGeNCHWjrOaZyIha697F0iNe9iG/5uj1FPDS9ppdTKHt+OtfayK5GMMj7xGSlJRSICz6xWm6307Z5U5lRjS4thRuqTZc1c0fpDwefkxpRs0j8QTA086aUUj+QruSjxxTj+FvPzq7oRPLSaSOTLJgKu7K7e7NI3EDAI4hOlj790rv9R7WfW6C9WzE7TLHSr7pU+nF1j51H9qIWcnTgeqv/Nzls1FxHDwYsJ/GHuBffG2KYviR24Av1yrvbWUGfPBMZ9+W/9FF4oXnH+e92L1UyCRLocxxELeTqkDxsmQeFirihJ6vixcvR52YYjBgn6BG+tkIjFaDkVEFU6bKu7Ra1HfEMbDnJZtOUycHErWks119z/fKoyGPCVKOtdIkbGatfeVl+jsXtSQypJYXGZgfupvCBvtLIeiTpLhAn39kZpmSrLW/KjiifOwf76AyXFgyZBU0xHrMfV1JZdJjdrR2qSnuhTIQEJIUrfJJfI3eBszoOHrplCeTAqrm36vPehTor1HuDXVua4apYE7Wh8DfgcSMW0YSqICQEZrxfNGCqDdxwIcCt2u7/AKfgeXsCXLyjc7VguNVS+h6f+FgPhoU/79YN7iNfQzgGjtIbPh4M28y3ncURxkXi75fj0Hb9fpECXwt5Ow= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(396003)(39860400002)(346002)(376002)(136003)(366004)(451199015)(86362001)(38100700002)(31696002)(4744005)(83380400001)(2906002)(41300700001)(8936002)(5660300002)(6506007)(6512007)(26005)(53546011)(186003)(2616005)(6916009)(316002)(66476007)(66556008)(8676002)(4326008)(66946007)(6486002)(478600001)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWt0SWpHazZacHU1ZnBXQ2xqQmZ4eHhjN0xaMkRocjluektMd0V1QlMvMXow?= =?utf-8?B?YkYrOEp2L1lrakd1b0s0czcrcTZLU1VwOEtOTkhZVm9lYmhJUDdJWUhmZUJP?= =?utf-8?B?aVpHYVk1ZmdPVGwxazBRcUdSOTQwUnlqazIzcUVmNHorYlhNeklmd1NnZTZn?= =?utf-8?B?Mm1RajhvVEpqNVFHaThqRWEyZk5ZMW5pSE50K2hSYXhNN3ZzQUFQbUV0L1Ew?= =?utf-8?B?S3V0RXVwSTBkQ2xOSmkrUVFHWHNjTi96UFp2bGJaWVpiYytTSFNHbkRpUWZl?= =?utf-8?B?aGRndkUwODROV252Z2JTeHBVV05vMG9WelJxR1BlVkRVWU5kejRieU9qTmJS?= =?utf-8?B?djBrVXo1RjFVZUJPWW5obDQvRVo4YXpuOFNSRXlKdXdmajBVaFhlOENnd20w?= =?utf-8?B?OSs3UjJFZmkrcERBSE1RQ1kxYVdaczFDYkJhODlleG8vdExXQ3g4VFozcndS?= =?utf-8?B?MkdIK0oyc1VtWWduL3NjbkUyRXVxdlVxdEcyQ1ROcUFRU3pzZ01SZ1BRU1px?= =?utf-8?B?bzdaaU9BUDFLNVJBc3dWdmYyMng3Y2RuMnZWR2V6QUtlbHlPVllxeURxODRh?= =?utf-8?B?b2ViYWYySlJoTWl3RFNYU3ZrSHR2Z1lGTXZLbi9zckZtNEZVS0pKR1JPZDda?= =?utf-8?B?dUU3bkpCYjc0US9rSklVdW5kMXFDTHcrQWVWaU5ianBWMVl0eC9PY29SbXB1?= =?utf-8?B?c29GMlgzVTV5bW5POW1qdEdjaFYveW9wcVVDblUrK0JhWkwzRkM0UjVDenF2?= =?utf-8?B?V21OSTh1UW1mRzNaUS9aMnFOdVpCU1B2cytMdW9NUkhxRFVKWVcvVUZJRXQ2?= =?utf-8?B?MGxFVXhwc0tyUkxVblZrNkQ2YjZsNStLYTBzQXhudXdYS3FOekR5Y3NoS3VO?= =?utf-8?B?aW4xYVpsRzlOYzNZMlpuYUZ1S2UyeFk5Q0FNQUhoaWtUd2hPQXM5bjExaTVE?= =?utf-8?B?dmVxTnNMcUo2NlYwRHNKaFJkekI4cXdiVzRVbTczeER0RzhZVmE0MkhNRkxn?= =?utf-8?B?c3pBMWZUS2QySXVLMnZkL3J0M3NxVXllWStoOUx6M2RmNElHdXMyM2JzWTg0?= =?utf-8?B?UHdMZEJ1OFV2eS9YUHBJdEpGVE1aaVBGaVNrYmVBMTlMVzRFak5nL0NvZ2Zu?= =?utf-8?B?VVN0LzMwYmlMZEU1SW9WUjdzUzhtSC9XdUhrYXd0Q0FsWlNsRkE5RG5nUXZX?= =?utf-8?B?ZUZKTVZ0UHUyUTlPMVdiangvT1ZuNnF0ZFdSTXVkWWdCUmp1YS9FcURrb3ZP?= =?utf-8?B?Z0d6S0hrUW1XWUUvN1NZeStQbnp5T29UNlNkR1UzeFJvTXh5Y3pSdlRsRkVG?= =?utf-8?B?V0daRlN4M0xkem0ydzlTci9RMldMMDhtUm1hM0dSekFiSEpBbWs4cHo4QmQz?= =?utf-8?B?a2llUXRCK3lueWhHMjF2TlpRcGxBdmRIcUNYeTNRQUlTcHZEOEZWRnRDbC9O?= =?utf-8?B?d2VkMTlCcVNoeW5Fa29GblQ0cCs1VFV4alRFNmpzc2Q0S00veVptZ0NrMXJZ?= =?utf-8?B?NzM1N2RHaGZiOElibFg0LzVMK0V1YjdYYUE1R2s4U1FBVkswTGVMemJ6UHNj?= =?utf-8?B?NXlxbldSYkVCUnE3Y3c3akxIWEFhVU1NVWVnY2F6YUxwZ3NPWS9iUStOWEta?= =?utf-8?B?Z3YzQVp2NUhqTmFqY0tGOU04d21mWHhPUHN6SGM3Q3NMaVIybTZDSGRpdXNl?= =?utf-8?B?N1JDc3RWZG5jbmNwQzZMNVdKQW9YVkJGN2JzWVBTT1BvaVFpOXhXRExjYVdV?= =?utf-8?B?VjMvazUxcXJWV3ZnVVJZdU8rZXFvZm9sbFdtK3VaYUhrTWNMMHBkMVJPVEZ6?= =?utf-8?B?Rk9WdFlVRW91dVkvR0c2dENDN2V4L0hQMkQ4YUtrTzd1aGpvQm1Cd1R0UWd5?= =?utf-8?B?SFh6WjJUZXNMNzVSTXVrVmNyaFoyWXQ2SWQvUDU5WGZpL0hTQ3pjMUNRakhB?= =?utf-8?B?UzdROS9PTGZzelVhb0RFdTVmTWpCRGRwT055MEtYV2NhMlplSEl3MHJWazdr?= =?utf-8?B?cjJFQzYwT3g0Tll1am9vUUxCaHFkZ3NQMlRhZkF4UnMzYW9MNVNLb1JZRzdt?= =?utf-8?B?bWtRbldxRm8xMEZjY0p3ZW5UUjhMYmNxQlZpNWpKSHBrNDMxVHRpMm1ONEFW?= =?utf-8?Q?hB/XZ/keH7gq1ExsAvYorT9C8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cd0777a-dd60-4b7c-2ae4-08dad6b2190a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Dec 2022 11:16:04.1622 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /ezmGdH0oUP86IAX2BReWTH/ZQidzH/PD4i3tBc7rbuPbfJkBILqyNU7XgwTcntQN6qCACs0vp5yqnauVeY2+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8926 X-Spam-Status: No, score=-3029.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05.12.2022 03:53, Haochen Jiang wrote: > For all the xh_mode usage in table, they are all using %XH, which will > print "{bad}" while EVEX.W=1. This makes this vex.w check unnecessary. I agree with this part. > Another reason for removing this check is because xh_mode with > broadcast usage should not indicate the vex.w bit. Instead it should > be handled by a W table entry. There are no broadcast insns using xh_mode, and you can't really mean embedded broadcast (because EVEX.W needs to be properly encoded there). Hence I don't follow what you're talking about here. The code change is okay, but if the above is to become the commit message, the raised question will need addressing first. Jan