* [PATCH] elf_slurp_symbol_table, return if count == zero
@ 2007-07-27 21:46 msnyder
2007-08-01 7:56 ` Alan Modra
0 siblings, 1 reply; 2+ messages in thread
From: msnyder @ 2007-07-27 21:46 UTC (permalink / raw)
To: binutils
[-- Attachment #1: Type: text/plain, Size: 52 bytes --]
Pretty sure it doesn't do anything in this case...
[-- Attachment #2: elfcode.txt --]
[-- Type: text/plain, Size: 944 bytes --]
2007-07-27 Michael Snyder <msnyder@access-company.com>
* elfcode.h (elf_slurp_symbol_table): Return if count is zero.
Index: elfcode.h
===================================================================
RCS file: /cvs/src/src/bfd/elfcode.h,v
retrieving revision 1.84
diff -p -r1.84 elfcode.h
*** elfcode.h 9 Jul 2007 21:23:37 -0000 1.84
--- elfcode.h 27 Jul 2007 21:41:59 -0000
*************** elf_slurp_symbol_table (bfd *abfd, asymb
*** 1204,1210 ****
ebd = get_elf_backend_data (abfd);
symcount = hdr->sh_size / sizeof (Elf_External_Sym);
if (symcount == 0)
! sym = symbase = NULL;
else
{
isymbuf = bfd_elf_get_elf_syms (abfd, hdr, symcount, 0,
--- 1204,1210 ----
ebd = get_elf_backend_data (abfd);
symcount = hdr->sh_size / sizeof (Elf_External_Sym);
if (symcount == 0)
! return 0; /* Nothing to do. */
else
{
isymbuf = bfd_elf_get_elf_syms (abfd, hdr, symcount, 0,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] elf_slurp_symbol_table, return if count == zero
2007-07-27 21:46 [PATCH] elf_slurp_symbol_table, return if count == zero msnyder
@ 2007-08-01 7:56 ` Alan Modra
0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2007-08-01 7:56 UTC (permalink / raw)
To: msnyder; +Cc: binutils
On Fri, Jul 27, 2007 at 02:44:27PM -0700, msnyder@sonic.net wrote:
> * elfcode.h (elf_slurp_symbol_table): Return if count is zero.
No, we should still call elf_backend_symbol_table_processing, and
assign *symptrs = 0. Rejected.
--
Alan Modra
Australia Development Lab, IBM
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-01 7:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-27 21:46 [PATCH] elf_slurp_symbol_table, return if count == zero msnyder
2007-08-01 7:56 ` Alan Modra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).