From: Tristan Gingold <gingold@adacore.com>
To: Nick Clifton <nickc@redhat.com>
Cc: Richard Sandiford <rdsandiford@googlemail.com>,
binutils <binutils@sourceware.org>
Subject: Re: Ping [Patch] include/coff/xcoff.h: add new macros
Date: Wed, 27 Apr 2011 15:04:00 -0000 [thread overview]
Message-ID: <18C0284C-FBBA-4E9F-B07B-334F78355483@adacore.com> (raw)
In-Reply-To: <4DB7E854.1010004@redhat.com>
On Apr 27, 2011, at 11:56 AM, Nick Clifton wrote:
> Hi Tristan,
>
>> It looks like I indeed get the definitions of:
>>
>> + #define F_LPTEXT 0x0400
>> + #define F_LPDATA 0x0800
>> + #define F_LOADONLY 0x4000
>> + #define F_NONEXEC 0x8000
>>
>> directly from the AIX headers. But F_LPDATA is mentioned in AIX 6.1 doc for ld, so is F_LOADONLY in strip command.
>>
>> F_NONEXEC is documented in:
>>
>> http://www.ibm.com/developerworks/aix/library/au-appdev-aix5l.html
>>
>> So only F_LPTEXT doesn't appear in IBM doc, but it appears in Valgrind code.
>>
>>> I trust you that they're correct. The reason I held back was that
>>> I was worried about copyright issues if the patch was a bulk copy of
>>> macros from the AIX header files.
>>
>> I can remove these macros as they aren't yet used in binutils. Tell me what do you prefer.
>
> I think that it would be best to remove them. If they are not needed and we cannot be sure of their copyright status, then lets leave them out. A patch with this change is pre-approved.
Ok, committed.
Tristan.
prev parent reply other threads:[~2011-04-27 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 14:28 Tristan Gingold
2011-04-26 7:43 ` Ping " Tristan Gingold
2011-04-26 8:19 ` Richard Sandiford
2011-04-26 8:38 ` Tristan Gingold
2011-04-27 9:56 ` Nick Clifton
2011-04-27 15:04 ` Tristan Gingold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18C0284C-FBBA-4E9F-B07B-334F78355483@adacore.com \
--to=gingold@adacore.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).