From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 530E138708E1 for ; Fri, 15 Dec 2023 12:15:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 530E138708E1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 530E138708E1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702642535; cv=none; b=vyjzxY+bW0EuWJXBMYbdlDd3kkpEy/a0JgjRHRLKb6Zpz9hHn1sFembEf1vvy5i12C+jkIwrtCzXv3JfrprQDfAdkL4P7mVm+vwLu+gcOB58SSA9ugplN9r8CDqzLeeAJXpTnv0oX8ziUlktc+ZtWmmTnU8K9HE6opFNJ4k6FKc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702642535; c=relaxed/simple; bh=gUovaGw/TOUw2gtIWqmDYq9uyLsEeQNVrHMjfRidAWk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=GZ0mw1lrOW8mQvLEOuPJrppGlCtpy/HJXGWsCUeCKYGE8kPQwuHfJUpjGSSZJ4sivirECMKQxaL0E0T3C+axJ95OsSNU5bTJchBFe8rEq5K4VgrUXGtNaBOSFbYh8GENJqmmvsKZT3S5Vh1h3O8dc/cb4m666Fskd8/r3Je/Cmo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a22fb5f71d9so102302766b.0 for ; Fri, 15 Dec 2023 04:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702642533; x=1703247333; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=o4uWp47J8Qo+MPoUxW9IWVgyCIVu2A5Y8tLwKQyvGeU=; b=MQdysTFHMbUAWXa8ph/ITyFjNqwLipXsN1dyoEX/XH2L5heiXiQwXQ2wnj5I69euLt +v49qhANMOhwJZKTllMx91Qjh2+cZbVGA45ps8p+JXyLmSqJobuidUqOBKUkCmpcDrj9 pTgcVBvLN6BZ1CSsZro45S7WYV97jqAvyUAons4QCSsdx3bLR4PmrGiL/35/VmT8v9bb HejeNtcsuVH5HScvJNN31OLs0NLVNUcVN6USgRuscadVmVf1RKpowpaZe7jDV0VcU9gn yDeleqFwlWibeHju644JWE9XyQTdHTV2vpdYs9FsO5IA9pT6zJ4AUvfXqZl82f7F4ZI3 OQ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702642533; x=1703247333; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o4uWp47J8Qo+MPoUxW9IWVgyCIVu2A5Y8tLwKQyvGeU=; b=K2pvd+V4zpw1X5t6WeMe6eu0hbjobCb5/XycKcpZMDn9vdWBkSXoQ5QxKTlaTBb7RH +T/gKf1MH5kT0W1c7yqEsEWeLzgq6lCFhw4M4ArvsAPPrEWaM0fPbXkyq2QPx7usjVIp k66uRtNXlx2SwJ9FwtB7ieZhhiRafTvHIjPsZt34SN3EvIMo7qpg07s4UN3hIcf7cJSL ZJgHkwQDHi+MCU5r0RZI1jEbvWt5eMImHHBK28mE/EhCnSP9+L+CtQ953hreh425K9hV eT381V3PCcNQyUlcE7jy7xyF5Mp7d3iRIW/U08AIAkBKsRk3TqhQ2zZldZmu8FV+HlqW bYOQ== X-Gm-Message-State: AOJu0YxFghwOcNpVF9TFE8lCWAvdi8EGL2+auLcufzqc6Cw8zZosFijc CgZUlpc9YSTMVKZs6mohk54fItKh0q+gL1cJLpFe X-Google-Smtp-Source: AGHT+IHy/u5Zrn7MGfXzOkF3D1IYWkcWV0+cUEiMTFAQ3k1qiFu/lR7mE7qjeVth22xKgaG8127kYw== X-Received: by 2002:a17:907:270f:b0:a1e:a558:748c with SMTP id w15-20020a170907270f00b00a1ea558748cmr11790045ejk.18.1702642533001; Fri, 15 Dec 2023 04:15:33 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id k9-20020a056e02156900b0035da74cd896sm4764564ilu.77.2023.12.15.04.15.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Dec 2023 04:15:32 -0800 (PST) Message-ID: <197fe193-abf7-45e1-8db2-2343da226309@suse.com> Date: Fri, 15 Dec 2023 13:15:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 13/22] visium: drop .bss and .skip overrides Content-Language: en-US From: Jan Beulich To: Binutils Cc: Nick Clifton , Alan Modra , Eric Botcazou References: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <5e1fe3bc-78ca-4c54-a19c-f8efa015f839@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The comment in s_bss() looks bogus (perhaps simply stale, or wrongly copied from another target). It also doesn't look to be a good idea to override the custom handler that ELF has (afaict doing so broke .previous as well as sub-section specification). The override for .skip is simply pointless, for read.c having exactly the same. While there also drop two adjacent redundant (with read.h) declarations (which would be outright dangerous if read.h wasn't included anyway). --- a/gas/config/tc-visium.c +++ b/gas/config/tc-visium.c @@ -163,40 +163,19 @@ tc_gen_reloc (asection *section ATTRIBUT return reloc; } -extern char *input_line_pointer; - - -static void s_bss (int); static void visium_rdata (int); static void visium_update_parity_bit (char *); static char *parse_exp (char *, expressionS *); -/* These are the back-ends for the various machine dependent pseudo-ops. */ -void demand_empty_rest_of_line (void); - - -static void -s_bss (int ignore ATTRIBUTE_UNUSED) -{ - /* We don't support putting frags in the BSS segment, we fake it - by marking in_bss, then looking at s_skip for clues. */ - - subseg_set (bss_section, 0); - demand_empty_rest_of_line (); -} - - /* This table describes all the machine specific pseudo-ops the assembler - has to support. The fields are: + has to support, and that aren't handled elsewhere. The fields are: 1: Pseudo-op name without dot. 2: Function to call to execute this pseudo-op. 3: Integer arg to pass to the function. */ const pseudo_typeS md_pseudo_table[] = { - {"bss", s_bss, 0}, - {"skip", s_space, 0}, {"align", s_align_bytes, 0}, {"noopt", s_ignore, 0}, {"optim", s_ignore, 0},