From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nick Clifton <nickc@cygnus.com>
To: binutils@sourceware.cygnus.com
Subject: name collision for ELF reloc sections
Date: Thu, 01 Jul 1999 00:00:00 -0000
Message-id: <199905101504.IAA16902@elmo.cygnus.com>
X-SW-Source: 1999-q2/msg00005.html

Hi Guys,

  What do you think of the following patch?  It is an attempt to fix a
  problem encountered with the ARM ecos toolchain assembling a file
  that contains a .section directive that looks like this:

	.section .release__10Cyg_Thread,"ax",@progbits

  This section has been derived from a C++ function declared like
  this: 

	void Cyg_Thread::release()

  with -ffunction-sections enabled.  The problem is that
  elf_fake_sections() thinks that the section is a REL section, since
  it starts with .rel, and so it does not assign a file position to
  it.  Later on, when a fixup inside the section is being processed an
  error occurs because BFD cannot seek to its location.

  The patch solves this problem by making elf_fake_section look for
  ".rel." as the start of a name of a REL section (and similarly
  ".rela." for the start of a name of a RELA section).  Looking for
  the extra period guarantees that the section name cannot have been
  generated from a real C/C++ function name, but I do not know if this
  is safe.  Is it possible to generate an ELF rel or rela section that
  starts with .rel{a} but which does not have a second period
  immediately following it ?

Cheers
	Nick


1999-05-10  Nick Clifton  <nickc@cygnus.com>

	* elf.c (elf_fake_sections): Check for .rel. as start of rel
	section, not just .rel.  Same for .rela.

Index: elf.c
===================================================================
RCS file: /cvs/cvsfiles/devo/bfd/elf.c,v
retrieving revision 1.228
diff -p -r1.228 elf.c
*** elf.c	1999/04/08 15:37:28	1.228
- --- elf.c	1999/05/10 14:37:12
*************** elf_fake_sections (abfd, asect, failedpt
*** 1490,1502 ****
        this_hdr->sh_type = SHT_DYNAMIC;
        this_hdr->sh_entsize = bed->s->sizeof_dyn;
      }
!   else if (strncmp (asect->name, ".rela", 5) == 0
  	   && get_elf_backend_data (abfd)->use_rela_p)
      {
        this_hdr->sh_type = SHT_RELA;
        this_hdr->sh_entsize = bed->s->sizeof_rela;
      }
!   else if (strncmp (asect->name, ".rel", 4) == 0
  	   && ! get_elf_backend_data (abfd)->use_rela_p)
      {
        this_hdr->sh_type = SHT_REL;
- --- 1490,1502 ----
        this_hdr->sh_type = SHT_DYNAMIC;
        this_hdr->sh_entsize = bed->s->sizeof_dyn;
      }
!   else if (strncmp (asect->name, ".rela.", 6) == 0
  	   && get_elf_backend_data (abfd)->use_rela_p)
      {
        this_hdr->sh_type = SHT_RELA;
        this_hdr->sh_entsize = bed->s->sizeof_rela;
      }
!   else if (strncmp (asect->name, ".rel.", 5) == 0
  	   && ! get_elf_backend_data (abfd)->use_rela_p)
      {
        this_hdr->sh_type = SHT_REL;