From: Richard Henderson <rth@cygnus.com>
To: mark@codesourcery.com
Cc: binutils@sourceware.cygnus.com
Subject: Re: PATCH for uninitialized junk in .dynsym
Date: Thu, 01 Jul 1999 00:00:00 -0000 [thread overview]
Message-ID: <19990613171634.A9797@cygnus.com> (raw)
In-Reply-To: <19990613135107N.mitchell@codesourcery.com>
On Sun, Jun 13, 1999 at 01:51:07PM -0700, mark@codesourcery.com wrote:
> + /* Remove the section from the output list. */
> + for (spp = &abfd->sections;
> + *spp != section->output_section;
> + spp = &(*spp)->next)
> + ;
> + *spp = section->output_section->next;
> + --abfd->section_count;
Please use _bfd_strip_section_from_output instead. I know it does
slightly more than required for these specific examples, but...
Otherwise it looks fine.
r~
next prev parent reply other threads:[~1999-07-01 0:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-07-01 0:00 mark
1999-07-01 0:00 ` Richard Henderson [this message]
1999-07-01 0:00 ` Ian Lance Taylor
1999-07-01 0:00 ` Richard Henderson
1999-07-01 0:00 ` mark
1999-07-01 0:00 ` Ian Lance Taylor
1999-07-01 0:00 ` Franz Sirl
1999-07-01 0:00 ` mark
1999-07-01 0:00 ` Franz Sirl
1999-07-01 0:00 ` Ian Lance Taylor
1999-07-01 0:00 ` Franz Sirl
1999-07-01 0:00 ` mark
1999-07-01 0:00 ` Franz Sirl
1999-07-01 0:00 ` Ian Lance Taylor
1999-07-01 0:00 ` Ian Lance Taylor
1999-07-01 0:00 ` mark
1999-07-01 0:00 ` Franz Sirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19990613171634.A9797@cygnus.com \
--to=rth@cygnus.com \
--cc=binutils@sourceware.cygnus.com \
--cc=mark@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).