From: Mumit Khan <khan@xraylith.wisc.EDU>
To: Ian Lance Taylor <ian@zembu.com>
Cc: binutils@sourceware.cygnus.com
Subject: Re: (fixed patch) pe-dll fix for exporting common symbols
Date: Thu, 01 Jul 1999 00:00:00 -0000 [thread overview]
Message-ID: <199906242230.RAA10360@mercury.xraylith.wisc.edu> (raw)
In-Reply-To: <19990624231639.20198.qmail@daffy.airs.com>
Ian Lance Taylor <ian@zembu.com> writes:
>
> The linker lays out common symbols in lang_common in ld/ldlang.c.
>
> I believe the code you are patching is run in the after_open emulation
> routine, which is before the linker has laid out common symbols. By
> the time of the before_allocation emulation routine, the linker will
> have laid out the common symbols (see lang_process or ldint.texinfo).
> Assuming you are not doing a relocateable link, there should be no
> more bfd_link_hash_common symbols after that point.
Thank you! I believe you just pointed me to the correct fix. The problem
is that currently the i386-pe ld is trying to write out the export
table in after_open, hence there are actually symbols with
bfd_link_hash_common, and things are going haywire. I'll redo it so that
it's done in ldemul_finish instead.
Regards,
Mumit
next prev parent reply other threads:[~1999-07-01 0:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-07-01 0:00 Mumit Khan
1999-07-01 0:00 ` Ian Lance Taylor
1999-07-01 0:00 ` Mumit Khan
1999-07-01 0:00 ` Ian Lance Taylor
1999-07-01 0:00 ` Mumit Khan [this message]
1999-07-01 0:00 ` DJ Delorie
1999-07-01 0:00 ` take 2: " Mumit Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199906242230.RAA10360@mercury.xraylith.wisc.edu \
--to=khan@xraylith.wisc.edu \
--cc=binutils@sourceware.cygnus.com \
--cc=ian@zembu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).