From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mumit Khan To: Ian Lance Taylor Cc: binutils@sourceware.cygnus.com Subject: Re: (fixed patch) pe-dll fix for exporting common symbols Date: Thu, 01 Jul 1999 00:00:00 -0000 Message-id: <199906242230.RAA10360@mercury.xraylith.wisc.edu> References: <19990624231639.20198.qmail@daffy.airs.com> X-SW-Source: 1999-q2/msg00347.html Ian Lance Taylor writes: > > The linker lays out common symbols in lang_common in ld/ldlang.c. > > I believe the code you are patching is run in the after_open emulation > routine, which is before the linker has laid out common symbols. By > the time of the before_allocation emulation routine, the linker will > have laid out the common symbols (see lang_process or ldint.texinfo). > Assuming you are not doing a relocateable link, there should be no > more bfd_link_hash_common symbols after that point. Thank you! I believe you just pointed me to the correct fix. The problem is that currently the i386-pe ld is trying to write out the export table in after_open, hence there are actually symbols with bfd_link_hash_common, and things are going haywire. I'll redo it so that it's done in ldemul_finish instead. Regards, Mumit