From: Mark Mitchell <mark@codesourcery.com>
To: ian@zembu.com
Cc: rth@cygnus.com, binutils@sourceware.cygnus.com
Subject: Re: Patches for IRIX6 N32-ABI ld
Date: Thu, 01 Jul 1999 00:00:00 -0000 [thread overview]
Message-ID: <19990626134622L.mitchell@codesourcery.com> (raw)
In-Reply-To: <19990626192703.9669.qmail@daffy.airs.com>
>>>>> "Ian" == Ian Lance Taylor <ian@zembu.com> writes:
Ian> I for one would be much more comfortable with testing a
Ian> boolean expression rather than writing a test based on the
Ian> assumption that an enum value is and will remain zero. It
Ian> seems too easy for somebody to change the enum and thus
Ian> unexpectedly change the behaviour of the code. I believe the
Ian> patch as written introduces a maintenance pitfall.
Wow, I'd hoped only to get controversial at the time we started
talking about relocation processing and stuff like that. :-)
Ian> In other words, I think either SGI_COMPAT should continue to
Ian> be defined as a clearly boolean value (e.g., 1) or you should
Ian> modify all the tests of SGI_COMPAT to work in some different
Ian> manner.
I understand what you're saying. But, this is a common programming
idiom, and well understood. How about explicitly setting `sct_none'
to zero:
enum {
sct_none = 0,
...
}
together with a comment?
--
Mark Mitchell mark@codesourcery.com
CodeSourcery, LLC http://www.codesourcery.com
next prev parent reply other threads:[~1999-07-01 0:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-07-01 0:00 Mark Mitchell
1999-07-01 0:00 ` Richard Henderson
1999-07-01 0:00 ` Mark Mitchell
1999-07-01 0:00 ` Ian Lance Taylor
1999-07-01 0:00 ` Mark Mitchell [this message]
1999-07-01 0:00 ` Ian Lance Taylor
1999-07-01 0:00 ` Mark Mitchell
1999-07-01 0:00 ` Richard Henderson
1999-07-01 0:00 ` Mark Mitchell
1999-07-01 0:00 ` Ian Lance Taylor
1999-07-01 0:00 ` Mark Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19990626134622L.mitchell@codesourcery.com \
--to=mark@codesourcery.com \
--cc=binutils@sourceware.cygnus.com \
--cc=ian@zembu.com \
--cc=rth@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).