public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Mumit Khan <khan@xraylith.wisc.EDU>
To: Ian Lance Taylor <ian@zembu.com>
Cc: ts1@cma.co.jp, binutils@sourceware.cygnus.com
Subject: Re: patch for i386-pe section header [Re: section bug?]
Date: Thu, 01 Jul 1999 00:00:00 -0000	[thread overview]
Message-ID: <199906270131.UAA03243@mercury.xraylith.wisc.edu> (raw)
In-Reply-To: <19990627012422.14497.qmail@daffy.airs.com>

On 26 Jun 1999, Ian Lance Taylor wrote:

>
> In the second new line, shouldn't that be
>     flags |= IMAGE_SCN_MEM_READ | IMAGE_SCN_MEM_WRITE
> ?
>
> I would almost just check that in, but I thought I'd better check to
> see if I was missing something.

For correctness yes, but never noticed it since NT doesn't seem to care. 
Btw, I'm just about to fix a few other section attribute things in the 
same routine, so let's wait till I send an update. It'll also give me 
time to run the testsuite + test W9x, where something always goes wrong.

Regards,
Mumit

  reply	other threads:[~1999-07-01  0:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-07-01  0:00 section bug? SONE Takeshi
1999-07-01  0:00 ` patch for i386-pe section header [Re: section bug?] Mumit Khan
1999-07-01  0:00   ` Ian Lance Taylor
1999-07-01  0:00     ` Mumit Khan [this message]
1999-07-01  0:00     ` Mumit Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199906270131.UAA03243@mercury.xraylith.wisc.edu \
    --to=khan@xraylith.wisc.edu \
    --cc=binutils@sourceware.cygnus.com \
    --cc=ian@zembu.com \
    --cc=ts1@cma.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).