From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Lance Taylor To: jeffdb@goodnet.com Cc: mark@codesourcery.com, binutils@sourceware.cygnus.com Subject: Re: Your change to ldlang.c Date: Fri, 02 Jul 1999 07:25:00 -0000 Message-id: <19990702142452.29262.qmail@daffy.airs.com> References: <19990702024311.26848.qmail@daffy.airs.com> <19990701203004Q.mitchell@codesourcery.com> <19990702033408.27051.qmail@daffy.airs.com> <19990701231549K.mitchell@codesourcery.com> <37805886.7337996@mail.goodnet.com> <37805886.7337996@mail.goodnet.com> X-SW-Source: 1999-q3/msg00014.html From: jeffdbREMOVETHIS@goodnet.com (Mikey) Date: Fri, 02 Jul 1999 06:13:57 GMT > /* When linking, duplicate sections of the same name should be > discarded, rather than being combined into a single section as > is usually done. This is similar to how common symbols are > handled. See SEC_LINK_DUPLICATES below. */ This is incorrect, it should read /* When linking, duplicate sections of the same name AND COMDAT SYMBOL should be discarded. Pei ld/bfd does not implement this correctly, which is part of the reason linking with vc5 implibs doesn't work. Yes, I didn't want to get mired in this aspect of the issue. It's true that although SEC_LINK_ONCE sections were inspired by COMDAT sections, they don't actually implement them correctly. Fortunately Don Terry has patches to fix these problems with the PE format, and he is working with me to get them into the mainline sources. Ian