From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Lance Taylor To: hjl@varesearch.com Cc: binutils@sourceware.cygnus.com Subject: Re: A weak symbol patch Date: Wed, 07 Jul 1999 15:30:00 -0000 Message-id: <19990707222907.17838.qmail@daffy.airs.com> References: <19990707205323.DB1B83FC1@varesearch.com> X-SW-Source: 1999-q3/msg00068.html Date: Wed, 7 Jul 1999 13:53:23 -0700 (PDT) From: hjl@varesearch.com (H.J. Lu) You missed a piece in mine. If you don't set ELF_LINK_HASH_REF_REGULAR when clearing ELF_LINK_HASH_DEF_REGULAR, no relocation will be generated at all and you will get a linker error: Thanks for the note. I tweaked the patch in a couple of ways. I was also running into trouble when dealing with weak versioned symbols; the existing code let it wind up setting up an indirection from a symbol to itself. Ian